From: Pekka Enberg <penberg@kernel.org>
To: Cong Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Christoph Hellwig <hch@lst.de>, Hugh Dickins <hughd@google.com>,
Dave Hansen <dave@linux.vnet.ibm.com>,
Lennart Poettering <lennart@poettering.net>,
Kay Sievers <kay.sievers@vrfy.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
linux-mm@kvack.org
Subject: Re: [V3 PATCH 1/2] tmpfs: add fallocate support
Date: Wed, 23 Nov 2011 11:06:57 +0200 [thread overview]
Message-ID: <CAOJsxLGeGyU26AUwzajwFO_o+PEajN6SFfoQqnLf2iOfw+YeZw@mail.gmail.com> (raw)
In-Reply-To: <1322038412-29013-1-git-send-email-amwang@redhat.com>
On Wed, Nov 23, 2011 at 10:53 AM, Cong Wang <amwang@redhat.com> wrote:
> Systemd needs tmpfs to support fallocate [1], to be able
> to safely use mmap(), regarding SIGBUS, on files on the
> /dev/shm filesystem. The glibc fallback loop for -ENOSYS
> on fallocate is just ugly.
>
> This patch adds fallocate support to tmpfs, and as we
> already have shmem_truncate_range(), it is also easy to
> add FALLOC_FL_PUNCH_HOLE support too.
>
> 1. http://lkml.org/lkml/2011/10/20/275
>
> V2->V3:
> a) Read i_size directly after holding i_mutex;
> b) Call page_cache_release() too after shmem_getpage();
> c) Undo previous changes when -ENOSPC.
>
> Cc: Pekka Enberg <penberg@kernel.org>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Hugh Dickins <hughd@google.com>
> Cc: Dave Hansen <dave@linux.vnet.ibm.com>
> Cc: Lennart Poettering <lennart@poettering.net>
> Cc: Kay Sievers <kay.sievers@vrfy.org>
> Cc: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> Signed-off-by: WANG Cong <amwang@redhat.com>
Looks reasonable to me.
Acked-by: Pekka Enberg <penberg@kernel.org>
Did someone actually test this with systemd?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2011-11-23 9:07 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 8:53 Cong Wang
2011-11-23 8:53 ` [PATCH 2/2] fs: wire up .truncate_range and .fallocate Cong Wang
2011-11-23 10:38 ` Christoph Hellwig
2011-11-23 19:16 ` Hugh Dickins
2011-11-23 9:06 ` Pekka Enberg [this message]
2011-11-23 19:07 ` [V3 PATCH 1/2] tmpfs: add fallocate support Hugh Dickins
2011-11-24 3:18 ` Cong Wang
2011-11-23 19:59 ` KOSAKI Motohiro
2011-11-23 21:11 ` Pekka Enberg
2011-11-23 22:20 ` Hugh Dickins
2011-11-24 3:15 ` Cong Wang
2011-11-24 1:52 ` KAMEZAWA Hiroyuki
2011-11-24 2:46 ` KOSAKI Motohiro
2011-11-24 3:01 ` KAMEZAWA Hiroyuki
2011-11-24 3:22 ` Cong Wang
2011-11-24 4:23 ` KAMEZAWA Hiroyuki
2011-11-24 5:52 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJsxLGeGyU26AUwzajwFO_o+PEajN6SFfoQqnLf2iOfw+YeZw@mail.gmail.com \
--to=penberg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=dave@linux.vnet.ibm.com \
--cc=hch@lst.de \
--cc=hughd@google.com \
--cc=kay.sievers@vrfy.org \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=lennart@poettering.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox