From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx179.postini.com [74.125.245.179]) by kanga.kvack.org (Postfix) with SMTP id B3BC26B0036 for ; Sun, 7 Jul 2013 12:41:55 -0400 (EDT) Received: by mail-wg0-f49.google.com with SMTP id a12so3156751wgh.16 for ; Sun, 07 Jul 2013 09:41:54 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <0000013f9aeb70c6-f6dad22c-bb88-4313-8602-538a3f5cedf5-000000@email.amazonses.com> References: <1372069394-26167-1-git-send-email-liwanp@linux.vnet.ibm.com> <1372069394-26167-2-git-send-email-liwanp@linux.vnet.ibm.com> <0000013f9aeb70c6-f6dad22c-bb88-4313-8602-538a3f5cedf5-000000@email.amazonses.com> Date: Sun, 7 Jul 2013 19:41:54 +0300 Message-ID: Subject: Re: [PATCH 2/3] mm/slab: Sharing s_next and s_stop between slab and slub From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Christoph Lameter Cc: David Rientjes , Wanpeng Li , Matt Mackall , Glauber Costa , Andrew Morton , Joonsoo Kim , "linux-mm@kvack.org" , LKML On Mon, Jul 1, 2013 at 6:48 PM, Christoph Lameter wrote: > On Mon, 24 Jun 2013, David Rientjes wrote: > >> On Mon, 24 Jun 2013, Wanpeng Li wrote: >> >> > This patch shares s_next and s_stop between slab and slub. >> > >> >> Just about the entire kernel includes slab.h, so I think you'll need to >> give these slab-specific names instead of exporting "s_next" and "s_stop" >> to everybody. > > He put the export into mm/slab.h. The headerfile is only included by > mm/sl?b.c . But he then went on to add globally visible symbols "s_next" and "s_stop" which is bad... Please send me an incremental patch on top of slab/next to fix this up. Otherwise I'll revert it before sending a pull request to Linus. Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org