From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx160.postini.com [74.125.245.160]) by kanga.kvack.org (Postfix) with SMTP id 9AEDD6B0068 for ; Wed, 31 Oct 2012 02:56:16 -0400 (EDT) Received: by mail-ea0-f169.google.com with SMTP id k11so529727eaa.14 for ; Tue, 30 Oct 2012 23:56:15 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <5085370F.80204@parallels.com> References: <1350907471-2236-1-git-send-email-elezegarcia@gmail.com> <5085370F.80204@parallels.com> Date: Wed, 31 Oct 2012 08:56:15 +0200 Message-ID: Subject: Re: [PATCH 2/2] mm/slob: Use free_page instead of put_page for page-size kmalloc allocations From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Glauber Costa Cc: Ezequiel Garcia , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tim Bird , Christoph Lameter , Matt Mackall > On 10/22/2012 04:04 PM, Ezequiel Garcia wrote: >> When freeing objects, the slob allocator currently free empty pages >> calling __free_pages(). However, page-size kmallocs are disposed >> using put_page() instead. >> >> It makes no sense to call put_page() for kernel pages that are provided >> by the object allocator, so we shouldn't be doing this ourselves. >> >> This is based on: >> commit d9b7f22623b5fa9cc189581dcdfb2ac605933bf4 >> Author: Glauber Costa On Mon, Oct 22, 2012 at 3:07 PM, Glauber Costa wrote: > Acked-by: Glauber Costa Applied, thanks Ezequiel! -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org