From: Pekka Enberg <penberg@kernel.org>
To: Ezequiel Garcia <elezegarcia@gmail.com>
Cc: linux-mm@kvack.org, Christoph Lameter <cl@linux.com>,
Glauber Costa <glommer@parallels.com>
Subject: Re: [PATCH 1/2] mm, slob: Prevent false positive trace upon allocation failure
Date: Wed, 15 Aug 2012 15:43:05 +0300 [thread overview]
Message-ID: <CAOJsxLGN-nZHm3P2ebthV+Hh-MDqY9bdpTrOWLPgXUr_eh+B5A@mail.gmail.com> (raw)
In-Reply-To: <CALF0-+VXA+4us1CSz5DGcSmKr37SnVF6ZMNbh8iLNsM7VYVnQQ@mail.gmail.com>
On Wed, Aug 15, 2012 at 3:34 PM, Ezequiel Garcia <elezegarcia@gmail.com> wrote:
> As you can see this patch prevents to trace a kmem event if the allocation
> fails.
>
> I'm still unsure about tracing or not this ones, and I'm considering tracing
> failures, perhaps with return=0 and allocated size=0.
>
> In this case, it would be nice to have SLxB all do the same.
> Right now, this is not the case.
>
> You can see how slob::kmem_cache_alloc_node traces independently
> of the allocation succeeding.
> I have no problem trying a fix for this, but I don't now how to trace
> this cases.
>
> Although it is a corner case, I think it's important to define a clear
> and consistent behaviour to make tracing reliable.
Agreed on consistency. I think it's valuable to be able to trace
allocation failures and let userspace filter them out if they don't
need them.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-08-15 12:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 14:38 Ezequiel Garcia
2012-08-14 14:38 ` [RFC/PATCH 2/2] mm, slob: Save real allocated size in page->private Ezequiel Garcia
2012-08-14 14:56 ` Christoph Lameter
2012-08-14 15:06 ` Ezequiel Garcia
2012-08-14 14:52 ` [PATCH 1/2] mm, slob: Prevent false positive trace upon allocation failure Christoph Lameter
2012-08-15 12:34 ` Ezequiel Garcia
2012-08-15 12:43 ` Pekka Enberg [this message]
2012-09-04 7:32 ` Pekka Enberg
2012-09-04 9:39 ` Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJsxLGN-nZHm3P2ebthV+Hh-MDqY9bdpTrOWLPgXUr_eh+B5A@mail.gmail.com \
--to=penberg@kernel.org \
--cc=cl@linux.com \
--cc=elezegarcia@gmail.com \
--cc=glommer@parallels.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox