From: Pekka Enberg <penberg@kernel.org>
To: Sasha Levin <levinsasha928@gmail.com>
Cc: dan.magenheimer@oracle.com, konrad.wilk@oracle.com,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 02/10] mm: frontswap: trivial coding convention issues
Date: Fri, 8 Jun 2012 23:16:39 +0300 [thread overview]
Message-ID: <CAOJsxLG2H_G3CrmqNSxEnYRB+mACRyeG4dOQZ6wasXV1V0vGYg@mail.gmail.com> (raw)
In-Reply-To: <1339182919-11432-3-git-send-email-levinsasha928@gmail.com>
On Fri, Jun 8, 2012 at 10:15 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
> Signed-off-by: Sasha Levin <levinsasha928@gmail.com>
> ---
> mm/frontswap.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/mm/frontswap.c b/mm/frontswap.c
> index 557e8af4..b619d29 100644
> --- a/mm/frontswap.c
> +++ b/mm/frontswap.c
> @@ -150,6 +150,7 @@ int __frontswap_store(struct page *page)
> inc_frontswap_failed_stores();
> } else
> inc_frontswap_failed_stores();
> + }
This looks wrong. Did you compile it?
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2012-06-08 20:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 19:15 [PATCH v2 00/10] minor frontswap cleanups and tracing support Sasha Levin
2012-06-08 19:15 ` [PATCH v2 01/10] mm: frontswap: remove casting from function calls through ops structure Sasha Levin
2012-06-08 19:15 ` [PATCH v2 02/10] mm: frontswap: trivial coding convention issues Sasha Levin
2012-06-08 20:16 ` Pekka Enberg [this message]
2012-06-08 20:36 ` Sasha Levin
2012-06-08 19:15 ` [PATCH v2 03/10] mm: frontswap: split out __frontswap_curr_pages Sasha Levin
2012-06-08 19:15 ` [PATCH v2 04/10] mm: frontswap: split out __frontswap_unuse_pages Sasha Levin
2012-06-08 19:15 ` [PATCH v2 05/10] mm: frontswap: split frontswap_shrink further to simplify locking Sasha Levin
2012-06-08 19:15 ` [PATCH v2 06/10] mm: frontswap: make all branches of if statement in put page consistent Sasha Levin
2012-06-08 19:15 ` [PATCH v2 07/10] mm: frontswap: remove unnecessary check during initialization Sasha Levin
2012-06-08 19:15 ` [PATCH v2 08/10] mm: frontswap: add tracing support Sasha Levin
2012-06-08 19:15 ` [PATCH v2 09/10] mm: frontswap: split out function to clear a page out Sasha Levin
2012-06-08 19:15 ` [PATCH v2 10/10] mm: frontswap: remove unneeded headers Sasha Levin
2012-06-08 22:04 ` [PATCH v2 00/10] minor frontswap cleanups and tracing support Konrad Rzeszutek Wilk
2012-06-08 22:38 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJsxLG2H_G3CrmqNSxEnYRB+mACRyeG4dOQZ6wasXV1V0vGYg@mail.gmail.com \
--to=penberg@kernel.org \
--cc=dan.magenheimer@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=levinsasha928@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox