Re: [PATCH] slub: correct return errno on slab_sysfs_init failure

[Pekka Enberg <penberg@kernel.org>]

On Thu, Jun 12, 2014 at 3:56 PM, Jeff Liu <jeff.liu@oracle.com> wrote:
> From: Jie Liu <jeff.liu@oracle.com>
>
> Return ENOMEM instead of ENOSYS if slab_sysfs_init() failed
>
> Signed-off-by: Jie Liu <jeff.liu@oracle.com>
> ---
>  mm/slub.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 2b1ce69..75ca109 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -5304,7 +5304,7 @@ static int __init slab_sysfs_init(void)
>         if (!slab_kset) {
>                 mutex_unlock(&slab_mutex);
>                 printk(KERN_ERR "Cannot register slab subsystem.\n");
> -               return -ENOSYS;
> +               return -ENOMEM;

What is the motivation for this change? AFAICT, kset_create_and_add()
can fail for other reasons than ENOMEM, no?

>         }
>
>         slab_state = FULL;

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>