From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FAA2C433E0 for ; Fri, 3 Jul 2020 07:47:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 418B22064B for ; Fri, 3 Jul 2020 07:47:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CYN/dONK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 418B22064B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CD46E8D0060; Fri, 3 Jul 2020 03:47:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C83F48D005E; Fri, 3 Jul 2020 03:47:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B73378D0060; Fri, 3 Jul 2020 03:47:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 9F19D8D005E for ; Fri, 3 Jul 2020 03:47:38 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 24E34485C for ; Fri, 3 Jul 2020 07:47:38 +0000 (UTC) X-FDA: 76995984996.28.unit19_5b1637026e90 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id EF0516C0B for ; Fri, 3 Jul 2020 07:47:37 +0000 (UTC) X-HE-Tag: unit19_5b1637026e90 X-Filterd-Recvd-Size: 3475 Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Fri, 3 Jul 2020 07:47:37 +0000 (UTC) Received: by mail-qt1-f194.google.com with SMTP id j10so23254060qtq.11 for ; Fri, 03 Jul 2020 00:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VZtEbxIRBIRflU8UoImAzW+G0W3pp330LtWYjBLtamo=; b=CYN/dONKSTsQV87cq5Eo5dQPmZVv8CWLnGtm4ZW52KJn3xC4A5nW2YY0Hp4mlCqN7u yO1ELrSz0iegM6ob4cAYP1U5nRYnEKAL9vVq4ge+cX3DTlNTNFBgfqgJuz92jp0rxL3G zlc0lUp0pPRwP1Niz0sEOAzhznIJ0ubPEIUmuKnNhyxS+idAKaEfnYB78RPZFvvRGTtk pb5HVmZxtasLTOLJ4nDwL5RxBgEF6JTTd7BboDuTI9MXvio+eLi/lbo8HD0479Fwi3Uu c9RHGfAa00mcoHXp64XRfm2x8PbIlcimuELzz2awBXBhArCa9sjya5EEJXtX3LoqNDoG T38A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VZtEbxIRBIRflU8UoImAzW+G0W3pp330LtWYjBLtamo=; b=J6t6qWLxZiNaJjWmBIPkqxnG3UzTRuMjqvLBC/vC0z80Gj4hSHg3+iDtWZS7cjJLaO LSPFsmEvNOHM+mOrS8l1/CFpLCtXtd9j7oilOEdn3jUaIYLiG0k/8GZ1ywz+B1amgEOC mhPemue0QJVUlayDhLL3/0XyO5AL/oiSy4dSkZsngowVmxASZkztLpFM6RHpVCFf2c1l D+COdJ6NNR/6lvYoMjZ3YT+d8VrRRrygJmqx1R9t9v3J1796bV4RJqnt4a1xzNHTJjvH mABy1O4OIRUX0R38eW2x/T9q5r7AhbhIOFKkwXyNg+tVgzgLe/NA0Y9AWtRDpsiRHr+z G2ew== X-Gm-Message-State: AOAM533kgJde2pY+1wBilDPs9RvN75M9u5eKdByf1mxM5uurgIBlMBvP fd5sCGPYJ14RLXHbg24rPDJifvOZDX0mbPJ2FnQ= X-Google-Smtp-Source: ABdhPJxms9b7K2WE/47/589yQkiyABa4IQDRfwhFipGDfReyghivC9nYx7vhdgupgU+2xz/mgO/WrW08PLYs6g5wCHY= X-Received: by 2002:ac8:66d1:: with SMTP id m17mr35232055qtp.88.1593762456982; Fri, 03 Jul 2020 00:47:36 -0700 (PDT) MIME-Version: 1.0 References: <20200703061350.94474-1-songmuchun@bytedance.com> In-Reply-To: From: Pekka Enberg Date: Fri, 3 Jul 2020 10:47:20 +0300 Message-ID: Subject: Re: [PATCH RESEND] mm/page_alloc: skip setting nodemask when we are in interrupt To: David Hildenbrand Cc: Muchun Song , Andrew Morton , "linux-mm@kvack.org" , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EF0516C0B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 03.07.20 08:34, Pekka Enberg wrote: > > if (cpusets_enabled()) { > > *alloc_mask |= __GFP_HARDWALL; > > if (!in_interrupt() && !ac->nodemask) > > ac->nodemask = &cpuset_current_mems_allowed; > > else > > *alloc_flags |= ALLOC_CPUSET; > > } On Fri, Jul 3, 2020 at 10:20 AM David Hildenbrand wrote: > ^ looks much cleaner as well. Do we want to add a summarizing comment? I see no harm in adding one. I'm sure the next person starting a journey in the maze some call the page allocator will appreciate it. - Pekka