From: Pekka Enberg <penberg@gmail.com>
To: David Hildenbrand <david@redhat.com>
Cc: Muchun Song <songmuchun@bytedance.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH RESEND] mm/page_alloc: skip setting nodemask when we are in interrupt
Date: Fri, 3 Jul 2020 10:47:20 +0300 [thread overview]
Message-ID: <CAOJsxLFpj1iZ8BVPwoSQJjBBtWnREQ=dVLNRV5fm4_Gvyn_DTw@mail.gmail.com> (raw)
In-Reply-To: <fe891223-9f83-d112-b185-643d6121712d@redhat.com>
On 03.07.20 08:34, Pekka Enberg wrote:
> > if (cpusets_enabled()) {
> > *alloc_mask |= __GFP_HARDWALL;
> > if (!in_interrupt() && !ac->nodemask)
> > ac->nodemask = &cpuset_current_mems_allowed;
> > else
> > *alloc_flags |= ALLOC_CPUSET;
> > }
On Fri, Jul 3, 2020 at 10:20 AM David Hildenbrand <david@redhat.com> wrote:
> ^ looks much cleaner as well. Do we want to add a summarizing comment?
I see no harm in adding one. I'm sure the next person starting a
journey in the maze some call the page allocator will appreciate it.
- Pekka
prev parent reply other threads:[~2020-07-03 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-03 6:13 Muchun Song
2020-07-03 6:34 ` Pekka Enberg
2020-07-03 7:20 ` David Hildenbrand
2020-07-03 7:47 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOJsxLFpj1iZ8BVPwoSQJjBBtWnREQ=dVLNRV5fm4_Gvyn_DTw@mail.gmail.com' \
--to=penberg@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=songmuchun@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox