From: Pekka Enberg <penberg@kernel.org>
To: David Rientjes <rientjes@google.com>
Cc: Joonsoo Kim <js1304@gmail.com>,
Christoph Lameter <cl@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH] slub: fix a possible memory leak
Date: Wed, 16 May 2012 09:37:38 +0300 [thread overview]
Message-ID: <CAOJsxLFao1nP92mUH7M6UsQu16UqzP_Vi3WasSkQw8Q8tFBDjg@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.00.1205142327580.19403@chino.kir.corp.google.com>
On Tue, May 15, 2012 at 9:28 AM, David Rientjes <rientjes@google.com> wrote:
> On Fri, 11 May 2012, Joonsoo Kim wrote:
>
>> Memory allocated by kstrdup should be freed,
>> when kmalloc(kmem_size, GFP_KERNEL) is failed.
>>
>> Signed-off-by: Joonsoo Kim <js1304@gmail.com>
>
> Acked-by: David Rientjes <rientjes@google.com>
>
> kmem_cache_create() in slub would significantly be improved with a rewrite
> to have a clear error path and use of return values of functions it calls.
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-05-16 6:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 15:32 Joonsoo Kim
2012-05-10 15:41 ` Christoph Lameter
2012-05-15 6:28 ` David Rientjes
2012-05-16 6:37 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOJsxLFao1nP92mUH7M6UsQu16UqzP_Vi3WasSkQw8Q8tFBDjg@mail.gmail.com \
--to=penberg@kernel.org \
--cc=cl@linux-foundation.org \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox