From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx123.postini.com [74.125.245.123]) by kanga.kvack.org (Postfix) with SMTP id 6F8526B0033 for ; Wed, 15 May 2013 14:10:53 -0400 (EDT) Received: by mail-we0-f172.google.com with SMTP id w60so1926732wes.17 for ; Wed, 15 May 2013 11:10:51 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <1368637812-7329-1-git-send-email-sanweidaying@gmail.com> References: <1368637812-7329-1-git-send-email-sanweidaying@gmail.com> Date: Wed, 15 May 2013 21:10:51 +0300 Message-ID: Subject: Re: [PATCH] mm, slab: corrected the comment 'kmem_cache_alloc' to 'slab_alloc_node' From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Zhouping Liu Cc: "linux-mm@kvack.org" , Zhouping Liu , Christoph Lameter , Matt Mackall , LKML On Wed, May 15, 2013 at 8:10 PM, Zhouping Liu wrote: > From: Zhouping Liu > > commit 48356303ff(mm, slab: Rename __cache_alloc() -> slab_alloc()) > forgot to update the comment 'kmem_cache_alloc' to 'slab_alloc_node'. > > Signed-off-by: Zhouping Liu > --- > mm/slab.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/slab.c b/mm/slab.c > index 8ccd296..8efb5f7 100644 > --- a/mm/slab.c > +++ b/mm/slab.c > @@ -3339,7 +3339,7 @@ done: > } > > /** > - * kmem_cache_alloc_node - Allocate an object on the specified node > + * slab_alloc_node - Allocate an object on the specified node > * @cachep: The cache to allocate from. > * @flags: See kmalloc(). > * @nodeid: node number of the target node. The point of the comment is to document kernel API and whereas slab_alloc_node() is internal to the slab allocator. Can you please just move it on top of kmem_cache_alloc_node() definition in the same file? Pekka -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org