From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx193.postini.com [74.125.245.193]) by kanga.kvack.org (Postfix) with SMTP id 7AB2F6B008C for ; Sat, 8 Sep 2012 04:39:16 -0400 (EDT) Received: by wgbdq12 with SMTP id dq12so279212wgb.26 for ; Sat, 08 Sep 2012 01:39:14 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20120906222933.GR2448@linux.vnet.ibm.com> References: <5044692D.7080608@linux.vnet.ibm.com> <5046B9EE.7000804@linux.vnet.ibm.com> <0000013996b6f21d-d45be653-3111-4aef-b079-31dc673e6fd8-000000@email.amazonses.com> <504812E7.3000700@linux.vnet.ibm.com> <20120906222933.GR2448@linux.vnet.ibm.com> Date: Sat, 8 Sep 2012 11:39:14 +0300 Message-ID: Subject: Re: [PATCH] slab: fix the DEADLOCK issue on l3 alien lock From: Pekka Enberg Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: paulmck@linux.vnet.ibm.com Cc: Michael Wang , Christoph Lameter , LKML , linux-mm@kvack.org, Matt Mackall , Andrew Morton On Fri, Sep 7, 2012 at 1:29 AM, Paul E. McKenney wrote: > On Thu, Sep 06, 2012 at 11:05:11AM +0800, Michael Wang wrote: >> On 09/05/2012 09:55 PM, Christoph Lameter wrote: >> > On Wed, 5 Sep 2012, Michael Wang wrote: >> > >> >> Since the cachep and cachep->slabp_cache's l3 alien are in the same lock class, >> >> fake report generated. >> > >> > Ahh... That is a key insight into why this occurs. >> > >> >> This should not happen since we already have init_lock_keys() which will >> >> reassign the lock class for both l3 list and l3 alien. >> > >> > Right. I was wondering why we still get intermitted reports on this. >> > >> >> This patch will invoke init_lock_keys() after we done enable_cpucache() >> >> instead of before to avoid the fake DEADLOCK report. >> > >> > Acked-by: Christoph Lameter >> >> Thanks for your review. >> >> And add Paul to the cc list(my skills on mailing is really poor...). > > Tested-by: Paul E. McKenney I'd also like to tag this for the stable tree to avoid bogus lockdep reports. How far back in release history should we queue this? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org