From: Pekka Enberg <penberg@kernel.org>
To: Glauber Costa <glommer@parallels.com>
Cc: linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
Christoph Lameter <cl@linux.com>,
Andrew Morton <akpm@linux-foundation.org>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH v2] slub: use free_page instead of put_page for freeing kmalloc allocation
Date: Thu, 16 Aug 2012 09:25:46 +0300 [thread overview]
Message-ID: <CAOJsxLEkJGgu7mnFXwqFewvho7AT+rC1vk0=_yMOKQTKtaTThQ@mail.gmail.com> (raw)
In-Reply-To: <1344019897-3769-1-git-send-email-glommer@parallels.com>
On Fri, Aug 3, 2012 at 9:51 PM, Glauber Costa <glommer@parallels.com> wrote:
> When freeing objects, the slub allocator will most of the time free
> empty pages by calling __free_pages(). But high-order kmalloc will be
> diposed by means of put_page() instead. It makes no sense to call
> put_page() in kernel pages that are provided by the object allocators,
> so we shouldn't be doing this ourselves. Aside from the consistency
> change, we don't change the flow too much. put_page()'s would call its
> dtor function, which is __free_pages. We also already do all of the
> Compound page tests ourselves, and the Mlock test we lose don't really
> matter.
>
> [v2: modified Changelog ]
>
> Signed-off-by: Glauber Costa <glommer@parallels.com>
> Acked-by: Christoph Lameter <cl@linux.com>
> CC: David Rientjes <rientjes@google.com>
> CC: Pekka Enberg <penberg@kernel.org>
Applied, thanks!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-08-16 6:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-03 18:51 Glauber Costa
2012-08-16 6:25 ` Pekka Enberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAOJsxLEkJGgu7mnFXwqFewvho7AT+rC1vk0=_yMOKQTKtaTThQ@mail.gmail.com' \
--to=penberg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=glommer@parallels.com \
--cc=hannes@cmpxchg.org \
--cc=linux-mm@kvack.org \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox