From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F018FC433E0 for ; Mon, 6 Jul 2020 11:50:13 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A158620724 for ; Mon, 6 Jul 2020 11:50:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gwrb8q1f" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A158620724 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 07E7D6B0003; Mon, 6 Jul 2020 07:50:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 030456B0005; Mon, 6 Jul 2020 07:50:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E60E06B0006; Mon, 6 Jul 2020 07:50:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0047.hostedemail.com [216.40.44.47]) by kanga.kvack.org (Postfix) with ESMTP id D008B6B0003 for ; Mon, 6 Jul 2020 07:50:12 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5A73E824805A for ; Mon, 6 Jul 2020 11:50:12 +0000 (UTC) X-FDA: 77007482664.30.sofa17_30019a826eab Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 2A6C4180B3C8B for ; Mon, 6 Jul 2020 11:50:12 +0000 (UTC) X-HE-Tag: sofa17_30019a826eab X-Filterd-Recvd-Size: 3401 Received: from mail-qv1-f65.google.com (mail-qv1-f65.google.com [209.85.219.65]) by imf06.hostedemail.com (Postfix) with ESMTP for ; Mon, 6 Jul 2020 11:50:11 +0000 (UTC) Received: by mail-qv1-f65.google.com with SMTP id di5so12081634qvb.11 for ; Mon, 06 Jul 2020 04:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HJPS9i68AMwe08ob266SMGfaNOxK2LzyyRESTVDvAq8=; b=gwrb8q1fpMTbIIY+b98bPBgNhHC9YXFytB4yndrISbMQrXTdynTfT3rTtMJrliss9x erJD+p3yZxRqXXvy6ytWhvzyRPXafkIQ1DgcxO7PNK7Jdpc69H7TWhU/j11tArTdwfGo aXF6HcW5XBkKo0Zf0o9W8iSnrTGiSyrphmjbPmec/KIfQgEhg5i+KtkhCSHxs6XOawqI PRp4Gr9thqc+rEYeLoWK4Bu/pGXceBTFR/y0eLu/dsRBjPuOqkE0lEE+4/IhK10q6g5P JGVi/SSTbRtWI9eAeRX+yBvyCldrbTU2z8giLdxKHyYKTa+zplEHvc1kkX9CbJn1f3mN ZxUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HJPS9i68AMwe08ob266SMGfaNOxK2LzyyRESTVDvAq8=; b=fylMbMECUliMHblVApS+4/W79or30OTv2Mrou0S47TzcR1DzRRGWnaNmoQB+e93hMQ YE+YlLk5/ic3thjqyv8epLz4Kk7xnGPg7QcladQhrYypGztJ/JviAeAONJCwRA9J/4Nc cV0UKC8czu2ms5/WAP8yieoPT4ttENIrOGP7IKjmRQbbGvVFgOEW05RrLpqMLmPoU8fj NIaUZOaEWP5eF8naJn6PuwV1ZHskYfgELb1d/1Ew3S/mGDHVIBt+pWRwsXI2tcD+myFS 90C0ppgqvgARZuUgjeNQEbkBu+0O4Kp98RQz8+RZ/DkIUFZEnLI3sNQgbgSLv7Rdb+sM k2fg== X-Gm-Message-State: AOAM532D73z4vHvvCZY/P4WZ67CmfLIHYMt7EoxlwdjddNIo5yFICESG ybuYX5Q2PzlDLQt/vEfK8a42bSdCPAexBHxI0nA= X-Google-Smtp-Source: ABdhPJwzhKnIeBJyg6Hdvrq0O2HRc6A2LQH4oD4siELH9amza/RljlZvEd4qxDGulKPGQ9WRBSHHijY40XERUUjP8r8= X-Received: by 2002:a0c:e78b:: with SMTP id x11mr41855150qvn.103.1594036211296; Mon, 06 Jul 2020 04:50:11 -0700 (PDT) MIME-Version: 1.0 References: <20200706025921.53683-1-songmuchun@bytedance.com> In-Reply-To: <20200706025921.53683-1-songmuchun@bytedance.com> From: Pekka Enberg Date: Mon, 6 Jul 2020 14:49:55 +0300 Message-ID: Subject: Re: [PATCH v2] mm/page_alloc: skip setting nodemask when we are in interrupt To: Muchun Song Cc: Andrew Morton , David Hildenbrand , "linux-mm@kvack.org" , LKML Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 2A6C4180B3C8B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jul 6, 2020 at 5:59 AM Muchun Song wrote: > When we are in the interrupt context, it is irrelevant to the > current task context. If we use current task's mems_allowed, we > can fair to alloc pages in the fast path and fall back to slow > path memory allocation when the current node(which is the current > task mems_allowed) does not have enough memory to allocate. In > this case, it slows down the memory allocation speed of interrupt > context. So we can skip setting the nodemask to allow any node > to allocate memory, so that fast path allocation can success. > > Signed-off-by: Muchun Song Reviewed-by: Pekka Enberg