From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD1D4C433E0 for ; Wed, 1 Jul 2020 11:46:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 9D1A52073E for ; Wed, 1 Jul 2020 11:46:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="aYbnmJqI" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D1A52073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 0D2758D0015; Wed, 1 Jul 2020 07:46:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0833E8D0013; Wed, 1 Jul 2020 07:46:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB23F8D0015; Wed, 1 Jul 2020 07:46:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0073.hostedemail.com [216.40.44.73]) by kanga.kvack.org (Postfix) with ESMTP id D1C758D0013 for ; Wed, 1 Jul 2020 07:46:36 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 63BDE180AD80F for ; Wed, 1 Jul 2020 11:46:36 +0000 (UTC) X-FDA: 76989329592.28.legs23_050ef5526e80 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 42B626C2D for ; Wed, 1 Jul 2020 11:46:36 +0000 (UTC) X-HE-Tag: legs23_050ef5526e80 X-Filterd-Recvd-Size: 3564 Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Wed, 1 Jul 2020 11:46:35 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id 145so19330319qke.9 for ; Wed, 01 Jul 2020 04:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=iYqF4GJWJhiq0zr8OJJzrOWqCriyzTSLkTobBVYc5/s=; b=aYbnmJqIMQKblPHiJRycAGb04R3B72H7jsqO/6ylS2mppwKkBIpk9UoHyuSrey4Jvy 6BTgKhlaLOmMMEkE4nS9kML7tlq7mQndDNYznC+xFMZAGwM0g4dEEOWnMJhfTnmyeqf6 /0VPnqwBNsXnkbmL6cJyjYO1SnqrCOj5N3RSVkj8b6xd6DIj62VvqyS3RUzY2ITAfNkV rje1wpA18rBWsCRXuPbD/rikd6/O9Wc7eMLEw4X7l+NLoGY8RtpvOKgbKfHA4qvxaiky ZslzS9cEDmKfKm4YWS+xc1cgzD2dX7sqoitreAdvsynJGA0jlDiXviF0lCBODxmGfxju e+8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=iYqF4GJWJhiq0zr8OJJzrOWqCriyzTSLkTobBVYc5/s=; b=rYZz3nR2vcHK0Cxa53Bl5/NB68li2qChhCz/Qd5xoRHXupkPsGSZCzqEvhxDX1/CWt yPyUKlbaJVzAy53eKjsBCZFQE6Ib8f3PGFdP4UH45gEBhsYgP2AamjROUj3GCh13v+5w OF5afJAvUFH2/80anq9Rda/0iFN0092X5XWCDitgaC6tuNeb+b6ncUD/cu5+m0+vM0id dcD9FSglvOy7GQpgz0TJtlzA+KDb9RA6j4Y5wd23vnlfXOVlDYlyjf29MvROBGYkzDh/ NME3Vz6N1paexkk0EsCeGLpZmY96WixGcM08Npcj9JTlXk4c4YDDprNTZbnHcl+dkEbc dPqA== X-Gm-Message-State: AOAM532neQDnKb5jACrAfaTYwxsM8ZS83bfrG0TOKX1Mc5kfT5zR2viN prHWGv8VIgOJVLN8pVDAW96ItyDXxFVQTo1FGjc= X-Google-Smtp-Source: ABdhPJwqu1fXRrwg0M7novYpBkm8DNW5TDfTOFJuqqC9PKaa+vMtnobtum6nx6izu14USV4vL6yPP+gCUj1N4kPnoVo= X-Received: by 2002:ae9:f803:: with SMTP id x3mr23680182qkh.488.1593603995183; Wed, 01 Jul 2020 04:46:35 -0700 (PDT) MIME-Version: 1.0 References: <20200626223130.199227-1-peterx@redhat.com> <20200626223625.199813-1-peterx@redhat.com> In-Reply-To: <20200626223625.199813-1-peterx@redhat.com> From: Pekka Enberg Date: Wed, 1 Jul 2020 14:46:24 +0300 Message-ID: Subject: Re: [PATCH 17/26] mm/riscv: Use general page fault accounting To: Peter Xu Cc: "linux-mm@kvack.org" , LKML , Andrew Morton , Linus Torvalds , Gerald Schaefer , Andrea Arcangeli , Will Deacon , Michael Ellerman , Paul Walmsley , Palmer Dabbelt , Albert Ou , linux-riscv@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 42B626C2D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Peter, On Sat, Jun 27, 2020 at 1:36 AM Peter Xu wrote: > Use the general page fault accounting by passing regs into handle_mm_fault(). > It naturally solve the issue of multiple page fault accounting when page fault > retry happened. I sent a patch to fix up riscv page fault accounting some days ago: http://lists.infradead.org/pipermail/linux-riscv/2020-June/000775.html However, your fix is obviously even better. For the generic and riscv parts: Reviewed-by: Pekka Enberg - Pekka