From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0673C433EF for ; Wed, 15 Dec 2021 12:41:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 23AE26B0073; Wed, 15 Dec 2021 07:41:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E9F26B0074; Wed, 15 Dec 2021 07:41:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0B36A6B0075; Wed, 15 Dec 2021 07:41:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id F26BA6B0073 for ; Wed, 15 Dec 2021 07:41:18 -0500 (EST) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C024E180CB051 for ; Wed, 15 Dec 2021 12:41:08 +0000 (UTC) X-FDA: 78919988616.11.220AE6A Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf05.hostedemail.com (Postfix) with ESMTP id 60EF1100017 for ; Wed, 15 Dec 2021 12:41:07 +0000 (UTC) Received: by mail-ed1-f43.google.com with SMTP id y22so3256079edq.2 for ; Wed, 15 Dec 2021 04:41:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=pa5P7TJTPoCcI6iCLMQS9O9zVLDm47/fvRV9xdvs9Gk=; b=kZwDtXK8NdFCbdiSQ62IKZJiYJUsIKUYlCJlBbmgkykwXRjfGnZU86rUx7f/8n4tyY N1Y6VQgyd5N70AHYTFH0CuKbITY0nHwJ1V4DXx30+HnXy7JgddzSWrksWaxzbAcAt5ss MyzVwCBnyv6gLHbo6WPFSnyZ8aBYQwBN+s80XJ2c2PkFFdgx23bTgSt4281ms4toLqrp 2udw7QoXKg/lyon1/bHBSLDa/rESK62RSClfJkHeWGHl32mbhfM4ibHPP2qPP2vi2duP ytnAXCG9fypdJbH88CUXiSQ6I3CJyBtNEi2eGN4rKkuk+u7BHQ5Ktwv7RY1VpzxvBpZu IO4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=pa5P7TJTPoCcI6iCLMQS9O9zVLDm47/fvRV9xdvs9Gk=; b=SFABQrLoIljGPjkpqHIUtj0wY4UYPr4kC4O9AeK1XcNLcGDthalHEQsGr1zfHvDTvX qA1UkSnJxFIWXwe4+u5Pa3PhMAosSSb7YT0vszSXm9K5MwpiiK5ptGHY87ZbsDq2F4c7 8Ar4O5hgQHzbnnxGs4Qmlf4CM2aSxlhxdj022ubTt2YZjL9c0U+jxe3jO2CBFoYd0kuG 4Mhr6W4eqzHcs3Qa1BZT0z+EnlePJavO3NDS3k8bY/vRlpzoeJRbAShNaBysM+by3jaK jh7WQCu/tcbhfd0bZmaxfqzSpOfyOQ44emQw532S6toh7We3DdFXgKe8RPQ+ZsFC65n1 7UGA== X-Gm-Message-State: AOAM532/yG+VWRrM9I1/vbRJtmgwrKuC8okfLuIQ3BEd4pVq/ZSBVnD5 4E5qMH19Rpsz9kksrtIPpncekC2V8zoT78Oy8xc= X-Google-Smtp-Source: ABdhPJyqx50oqjtiQUFh6Za0gonG95YEHb7EWF3cYk2Vcnzwxdbz3gtLfbbRkCZaiY/HO3n7MW1Im7CTK5HmtEwCmpE= X-Received: by 2002:a05:6402:14f:: with SMTP id s15mr14355960edu.118.1639572066575; Wed, 15 Dec 2021 04:41:06 -0800 (PST) MIME-Version: 1.0 References: <1638619795-71451-1-git-send-email-wang.yong12@zte.com.cn> In-Reply-To: From: yong w Date: Wed, 15 Dec 2021 20:40:48 +0800 Message-ID: Subject: Re: [PATCH v2 linux-next] delayacct: track delays from memory compact To: Balbir Singh Cc: Andrew Morton , "Peter Zijlstra (Intel)" , mingo@kernel.org, LKML , Linux MM , yang.yang29@zte.com.cn, wang.yong12@zte.com.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 60EF1100017 X-Stat-Signature: d8mdwsjdjhk516sfwcqrk1dkuh38j7br Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kZwDtXK8; spf=pass (imf05.hostedemail.com: domain of yongw.pur@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=yongw.pur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam10 X-HE-Tag: 1639572067-816408 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Balbir Singh =E4=BA=8E2021=E5=B9=B412=E6=9C=8814=E6= =97=A5=E5=91=A8=E4=BA=8C 13:49=E5=86=99=E9=81=93=EF=BC=9A > > On Mon, Dec 13, 2021 at 09:56:08PM +0800, yong w wrote: > > Hello, is this patch OK? > > > > Thanks. > > > > yong w =E4=BA=8E2021=E5=B9=B412=E6=9C=888=E6=97= =A5=E5=91=A8=E4=B8=89 00:50=E5=86=99=E9=81=93=EF=BC=9A > > > > > > Balbir Singh =E4=BA=8E2021=E5=B9=B412=E6=9C= =887=E6=97=A5=E5=91=A8=E4=BA=8C 13:16=E5=86=99=E9=81=93=EF=BC=9A > > > > > > > > On Sun, Dec 05, 2021 at 07:08:02PM +0800, yong w wrote: > > > > > Balbir Singh =E4=BA=8E2021=E5=B9=B412=E6= =9C=885=E6=97=A5=E5=91=A8=E6=97=A5 16:17=E5=86=99=E9=81=93=EF=BC=9A > > > > > > > > > > > > On Sat, Dec 04, 2021 at 04:09:55AM -0800, yongw.pur@gmail.com w= rote: > > > > > > > From: wangyong > > > > > > > > > > > > > > Delay accounting does not track the delay of memory compact. > > > > > > > When there is not enough free memory, tasks can spend > > > > > > > a amount of their time waiting for compact. > > > > > > > > > > > > > > To get the impact of tasks in direct memory compact, measure > > > > > > > the delay when allocating memory through memory compact. > > > > > > > > > > > > > > > > > > > Should we call this DIRECT_COMPACT and through documentation > > > > > > or name change imply that this won't work for kcompactd the > > > > > > kernel thread - based on my reading of the patches. > > > > > > > > > > > Using DIRECT_COMPACT is a little redundant=EF=BC=8Cbecause the > > > > > delayacct stats of delay accounting is specific to tasks, it has > > > > > nothing to do with kcompactd, which is similar to the RECLAIM fie= ld. > > > > > > > > > > > > > What would we expect when we call delayacct -p > > > > to be output? > > > If the slow path of memory allocation is invoked in the kcompacd proc= ess, > > > there may be delays being recorded. > > > > > > > Don't feel to strongly, but it can be confusing that kcompactd > > > > has spent no time in compact'ing? Not that delayacct is used for > > > > kernel threads, but I am not sure if that use case exists today. > > > Yes, delayacct does not restrict the process of obtaining information= =EF=BC=8C > > > but kcompactd is used for compaction, the compact delay of > > > kcompatd is not actually a delay.Maybe it can be added to the > > > document later to make it clearer. > > > > > > Thanks for your reply! > > Please avoid top posting, when you say added later, I presume more > patches for documentation are coming. I am OK with the patch in that > case. > > Reviewed-by: Balbir Singh > > Balbir Singh OK=EF=BC=8CThank you!