From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5B6C433EF for ; Mon, 13 Dec 2021 13:56:44 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D023C6B0074; Mon, 13 Dec 2021 08:56:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB2356B0075; Mon, 13 Dec 2021 08:56:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA08B6B0078; Mon, 13 Dec 2021 08:56:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0032.hostedemail.com [216.40.44.32]) by kanga.kvack.org (Postfix) with ESMTP id AA6166B0074 for ; Mon, 13 Dec 2021 08:56:33 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 63B28181AEF09 for ; Mon, 13 Dec 2021 13:56:23 +0000 (UTC) X-FDA: 78912920646.19.7E2AC37 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf18.hostedemail.com (Postfix) with ESMTP id 762351C0005 for ; Mon, 13 Dec 2021 13:56:20 +0000 (UTC) Received: by mail-ed1-f54.google.com with SMTP id t5so52041012edd.0 for ; Mon, 13 Dec 2021 05:56:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=zrtRpR8eA02n90RUwfo1A3PioW6t9aLRijcZi5AYw44=; b=Gr/l8gjmasnhOeyi4byACXdu1YfG5jl2KSTRaw5qc2izpQ4Ojz71h7I1rmOXQmK27R 97zOBvJZL/2Rd6XJTZOAmihFqO0gNx2kvVoKZkI4+Wqq1HVhybjtwkd84yTUWDRSf7mR ZrLl/MUwAexAV8V1+UZ/zprNEKooaryECmfhpwNYDBPjaXJ7WdPdcM1J9sq3/EjnlzEV N6EnBSPlgu5cpLhc0/Sb5QDJZs0TQkfIqQU2kYk4sBaDCI8RYtmvG0BYFC/qCMG2vK7j KeDzTQidnMTl77ctP6WQ47yaa2Kl/O1cBsv2RP43UrlXeF7c03u2ZeRwxKDc1hfAOcsv nWKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=zrtRpR8eA02n90RUwfo1A3PioW6t9aLRijcZi5AYw44=; b=Mxqu9na7bubkIsFQpNgccOTwnduCcvXNFn9+O5WnLuuPwzxRqKGrveXyzevMSNL7ZW wxfwszMrt/be/8hZ1T+98dGYZcQb8QIq2NzkB+k6joK2BciphkMOXhvLZ/wX003t32Jx tTSJz4BGAWqG7fbi8GblYnINmcJpHhMNavjZ+n4UReQaxEtJ0Vrw54ABYYjbS19eIUch JnOUgTKViVYKBbHP8E8eoqS16FxjpsQxJEQ5lWOjVWJXtaGt517+Dla2v528CFao7aGa hi0S7u9SsmwuGbocsUxyD50tBVVDol9X52OJLRDvpAoy7pDGbWfMxmuOU1gb9p2edd5U G3+g== X-Gm-Message-State: AOAM530c0yo9ymfwEK5DUh1RJX7qeyteDS+QY+iemUARZu9xuqEnGkZ3 BBM/sr7kVnrg2rdqqWGANvDZX5j5PoS9LubLTUk= X-Google-Smtp-Source: ABdhPJzu6Sy0E4ASvjWdK04f3wVR79VFUqLTwERbCTzG1yv15MbFMEi1BYmN3V3vffxNAKrnuq7q+wxehLaP0obMRJ4= X-Received: by 2002:aa7:c415:: with SMTP id j21mr65957272edq.357.1639403781408; Mon, 13 Dec 2021 05:56:21 -0800 (PST) MIME-Version: 1.0 References: <1638619795-71451-1-git-send-email-wang.yong12@zte.com.cn> In-Reply-To: From: yong w Date: Mon, 13 Dec 2021 21:56:08 +0800 Message-ID: Subject: Re: [PATCH v2 linux-next] delayacct: track delays from memory compact To: Balbir Singh , Andrew Morton , "Peter Zijlstra (Intel)" , mingo@kernel.org Cc: LKML , Linux MM , yang.yang29@zte.com.cn, wang.yong12@zte.com.cn Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 762351C0005 Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b="Gr/l8gjm"; spf=pass (imf18.hostedemail.com: domain of yongw.pur@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=yongw.pur@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspamd-Server: rspam04 X-Stat-Signature: gi697hny85p8bqdc6egnmjsu1wcxjs4p X-HE-Tag: 1639403780-596211 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hello, is this patch OK? Thanks. yong w =E4=BA=8E2021=E5=B9=B412=E6=9C=888=E6=97=A5=E5= =91=A8=E4=B8=89 00:50=E5=86=99=E9=81=93=EF=BC=9A > > Balbir Singh =E4=BA=8E2021=E5=B9=B412=E6=9C=887= =E6=97=A5=E5=91=A8=E4=BA=8C 13:16=E5=86=99=E9=81=93=EF=BC=9A > > > > On Sun, Dec 05, 2021 at 07:08:02PM +0800, yong w wrote: > > > Balbir Singh =E4=BA=8E2021=E5=B9=B412=E6=9C= =885=E6=97=A5=E5=91=A8=E6=97=A5 16:17=E5=86=99=E9=81=93=EF=BC=9A > > > > > > > > On Sat, Dec 04, 2021 at 04:09:55AM -0800, yongw.pur@gmail.com wrote= : > > > > > From: wangyong > > > > > > > > > > Delay accounting does not track the delay of memory compact. > > > > > When there is not enough free memory, tasks can spend > > > > > a amount of their time waiting for compact. > > > > > > > > > > To get the impact of tasks in direct memory compact, measure > > > > > the delay when allocating memory through memory compact. > > > > > > > > > > > > > Should we call this DIRECT_COMPACT and through documentation > > > > or name change imply that this won't work for kcompactd the > > > > kernel thread - based on my reading of the patches. > > > > > > > Using DIRECT_COMPACT is a little redundant=EF=BC=8Cbecause the > > > delayacct stats of delay accounting is specific to tasks, it has > > > nothing to do with kcompactd, which is similar to the RECLAIM field. > > > > > > > What would we expect when we call delayacct -p > > to be output? > If the slow path of memory allocation is invoked in the kcompacd process, > there may be delays being recorded. > > > Don't feel to strongly, but it can be confusing that kcompactd > > has spent no time in compact'ing? Not that delayacct is used for > > kernel threads, but I am not sure if that use case exists today. > Yes, delayacct does not restrict the process of obtaining information=EF= =BC=8C > but kcompactd is used for compaction, the compact delay of > kcompatd is not actually a delay.Maybe it can be added to the > document later to make it clearer. > > Thanks for your reply!