From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD24FC11D2F for ; Mon, 24 Feb 2020 16:19:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 898CE20838 for ; Mon, 24 Feb 2020 16:19:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="Cw1HT55F" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 898CE20838 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 258886B0005; Mon, 24 Feb 2020 11:19:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 209806B0006; Mon, 24 Feb 2020 11:19:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11E4E6B0007; Mon, 24 Feb 2020 11:19:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0191.hostedemail.com [216.40.44.191]) by kanga.kvack.org (Postfix) with ESMTP id EF5076B0005 for ; Mon, 24 Feb 2020 11:19:46 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C5335180AD817 for ; Mon, 24 Feb 2020 16:19:46 +0000 (UTC) X-FDA: 76525531572.08.place08_1b18220fdd616 X-HE-Tag: place08_1b18220fdd616 X-Filterd-Recvd-Size: 4319 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 24 Feb 2020 16:19:46 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id y17so2282510wrn.6 for ; Mon, 24 Feb 2020 08:19:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=19j0trO9Mv3wrvKzfdH1BS//FW2UKY+OrcE5cOGi9/I=; b=Cw1HT55FGFoyD6E0iMpdCHp8w7pAVLI/g2wPIpKjKTb5pxUdt8pOFFjBbPq6CJb5i9 0itvZmEqL7fK3eAzrENC65BmVO6yoTEs11jci0P6njUwvEWxMWj0xoNQBJuNSHN6E3Oq u5A5CEANEG3NWiQdRBvexVujjFefbakQ/SsuE92Zn3sQdrnXofC0osFBZaFt4VYs+5or YU1dMFj5bNqKknCv4/NbiQYavhyLEWv2dMu0oPkkr2EBTTlKZyOhjway8ig8zsYdb8aT eIgu7CPIzZgyylRUyzAWyZEhYZbMiZ4Ed7tKAL7IyEgnig86CdOj1G/oe8UtsjVbuO7i bZfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=19j0trO9Mv3wrvKzfdH1BS//FW2UKY+OrcE5cOGi9/I=; b=YCFMUKCTmgx3MIryQxzFk8DTXMA2CRD++QbalZtc6DlgwnFprA2c4ktOJfHqzC0KqZ SvLKqRI5ZVnVa/bxlFetlA9FD6TH/h4LEkar48z447wIGurtugI8y8zIrWlg11wH7s6r T+OhE27h3d+mNM+lM7vV+SdRSVMaKOGYoA79KZAOgajQ8IFKN1ER0/BDo2FNVuIGxMAS Oy5T5aLuFauGOusp69A3ZOuqoWvccdZ7LN5sklyKLlZCDNpzhhJNFSYgwbsbrWaKMntR wQWD0JjDwrE1qgzR99EbfyK+RXlt/bUUYqEtrmXQf6IP46tLv6kvuJfNsXJAd+dVEiLC RoGA== X-Gm-Message-State: APjAAAVaELbkPMWjI6oSSAMaBYd9xE3ddLQuiqL6OdnEZ3g7llBnmmah HwM6tGX/d7Nxy/Fc3eyVeJgqBkjSpD95aybl9ZMu7A== X-Google-Smtp-Source: APXvYqxU9FUwoF+m5Q66zIMPAB7qaBWxrQS7ZCHR00X4HQuD5lXLTm339u0a6mc2/vAuanTvw3mbbCusDtmw7SArI30= X-Received: by 2002:adf:dfcc:: with SMTP id q12mr66447402wrn.171.1582561184425; Mon, 24 Feb 2020 08:19:44 -0800 (PST) MIME-Version: 1.0 References: <20200128025958.43490-1-arjunroy.kdev@gmail.com> <20200128025958.43490-3-arjunroy.kdev@gmail.com> <20200212185605.d89c820903b7aa9fbbc060b2@linux-foundation.org> <20200223193710.596fb5d9ebb23959a3fee187@linux-foundation.org> In-Reply-To: <20200223193710.596fb5d9ebb23959a3fee187@linux-foundation.org> From: Arjun Roy Date: Mon, 24 Feb 2020 08:19:33 -0800 Message-ID: Subject: Re: [PATCH resend mm,net-next 3/3] net-zerocopy: Use vm_insert_pages() for tcp rcv zerocopy. To: Andrew Morton Cc: Arjun Roy , David Miller , netdev@vger.kernel.org, linux-mm@kvack.org, Eric Dumazet , Soheil Hassas Yeganeh Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Feb 23, 2020 at 7:37 PM Andrew Morton wrote: > > On Fri, 21 Feb 2020 13:21:41 -0800 Arjun Roy wrote: > > > I remain a bit concerned regarding the merge process for this specific > > patch (0003, the net/ipv4/tcp.c change) since I have other in-flight > > changes for TCP receive zerocopy that I'd like to upstream for > > net-next - and would like to avoid weird merge issues. > > > > So perhaps the following could work: > > > > 1. Andrew, perhaps we could remove this particular patch (0003, the > > net/ipv4/tcp.c change) from mm-next; that way we merge > > vm_insert_pages() but not the call-site within TCP, for now. > > 2. net-next will eventually pick vm_insert_pages() up. > > 3. I can modify the zerocopy code to use it at that point? > > > > Else I'm concerned a complicated merge situation may result. > > > > What do you all think? > > We could do that. > > For now, I'll stage the entire patch series after linux-next and shall > wait and see whether things which appear in linux-next cause serious > merge issues to occur. Sound OK? Sounds good for now; the conflict itself would be easy enough to fix when it does crop up. Thanks, -Arjun