From: Arjun Roy <arjunroy@google.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Arjun Roy <arjunroy.kdev@gmail.com>,
David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, Soheil Hassas Yeganeh <soheil@google.com>,
Eric Dumazet <edumazet@google.com>,
Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH mm 1/2] mm: Define pte_index as macro for x86
Date: Thu, 27 Feb 2020 19:04:16 -0800 [thread overview]
Message-ID: <CAOFY-A1NwpnbT2GASSKg69Wj4nG6R0mVswWR19_-SHrs2eN+Ug@mail.gmail.com> (raw)
In-Reply-To: <20200228115719.01c1cf57@canb.auug.org.au>
On Thu, Feb 27, 2020 at 4:57 PM Stephen Rothwell <sfr@canb.auug.org.au> wrote:
>
> Hi Arjun,
>
> On Thu, 27 Feb 2020 16:46:56 -0800 Arjun Roy <arjunroy.kdev@gmail.com> wrote:
> >
> > diff --git a/arch/x86/include/asm/pgtable.h b/arch/x86/include/asm/pgtable.h
> > index 7e118660bbd9..6658c04bce83 100644
> > --- a/arch/x86/include/asm/pgtable.h
> > +++ b/arch/x86/include/asm/pgtable.h
> > @@ -823,6 +823,9 @@ static inline unsigned long pmd_index(unsigned long address)
> > */
> > #define mk_pte(page, pgprot) pfn_pte(page_to_pfn(page), (pgprot))
> >
> > +/* Degenerative definition so we can test if pte_index is defined for arch. */
> > +#define pte_index pte_index
>
> You should put this definition directly above the static inline function.
>
> i.e.
>
> #define pte_index pte_index
> static inline unsigned long pte_index(unsigned long address)
> ...
>
Done.
-Arjun
> --
> Cheers,
> Stephen Rothwell
prev parent reply other threads:[~2020-02-28 3:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 0:46 Arjun Roy
2020-02-28 0:46 ` [PATCH mm 2/2] mm: vm_insert_pages() checks if pte_index defined Arjun Roy
2020-02-28 0:57 ` [PATCH mm 1/2] mm: Define pte_index as macro for x86 Stephen Rothwell
2020-02-28 3:04 ` Arjun Roy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOFY-A1NwpnbT2GASSKg69Wj4nG6R0mVswWR19_-SHrs2eN+Ug@mail.gmail.com \
--to=arjunroy@google.com \
--cc=akpm@linux-foundation.org \
--cc=arjunroy.kdev@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=geert@linux-m68k.org \
--cc=linux-mm@kvack.org \
--cc=sfr@canb.auug.org.au \
--cc=soheil@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox