From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D94AC433DB for ; Tue, 16 Mar 2021 06:22:42 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B82F46520E for ; Tue, 16 Mar 2021 06:22:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B82F46520E Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 28C806B006C; Tue, 16 Mar 2021 02:22:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 23C986B006E; Tue, 16 Mar 2021 02:22:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0DD5B6B0070; Tue, 16 Mar 2021 02:22:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0253.hostedemail.com [216.40.44.253]) by kanga.kvack.org (Postfix) with ESMTP id E3C176B006C for ; Tue, 16 Mar 2021 02:22:40 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8AFBF181AF5F4 for ; Tue, 16 Mar 2021 06:22:40 +0000 (UTC) X-FDA: 77924743680.14.722A88A Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by imf07.hostedemail.com (Postfix) with ESMTP id 21588A0009C5 for ; Tue, 16 Mar 2021 06:22:40 +0000 (UTC) Received: by mail-pj1-f41.google.com with SMTP id lr10-20020a17090b4b8ab02900dd61b95c5eso809644pjb.4 for ; Mon, 15 Mar 2021 23:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xHVFZ6ek9UWH6gJaYSFsmDxhb9ekTRVKDZq6Jazc5rQ=; b=pnrONYLdoVlRUvqukdeM+bXd8Ij3mjhE5t0V3KUkfpk/yrSbJMiTCr/S7UD0odUa02 dWaR7hogUC6ysiqCkMkPEk2Rm3IVlquKQdHRqaOjcwbaGU5bYrQgZbR/QG+VhgyITwf6 e/ragJyDp+NpS773hJSNltE3XoRaFmfNc8Iq8U25yWlB4aNnetpoVFz4yl7ETuoMnP83 2M+UYJc9wZw4k2VjBiPyaeFI/Y9/7t/nEJhE31nhE3tiAMGH/f/B+TGq6ZdxRnsfEJnc y46UwmnnQfOkJuGmkcKJv5m/gRbBj8RETOssa7aTxyXocQ25FcQhbN+O8uXfxhn888eb XcQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xHVFZ6ek9UWH6gJaYSFsmDxhb9ekTRVKDZq6Jazc5rQ=; b=TXYaUo5NwbnwEoDJbrezU3l+5Z2mF6+GniMTP/5bqlDVFqe+dfxLHe9xY3HIvYoTp8 vi/4ljDODhfsU6O8IUiq0ox3aCG+hRK2jmCf792djhFlcS+SsjlaryGG05c/UUO0CU06 xm3Vq0K74q/guvFmLaIqEkSgBXt1aL4ttIJ+p4N+hUoptsyLVTNuKT1XN/6yvF7yO/IB lR51Dvp6Gqg2WP2omgYUwX92yluuR1VLwBdZcWt72YO5Una8/Cupe/BPxsDmJuFuqOHc VUfO/14Mko5FhrSLZKxWpoE583gh5jkcLVdYdd3skyjlU5L8/EAfLK1XjDpWeOudixhU wWLQ== X-Gm-Message-State: AOAM53320Pj4vv9T5pSPkalL89bMsNLkjEVPmR2lvduXKN9z3lWe3XaS YPEcm1bTSWjQummVgMjbE+oTCBlkDuVzViqkGP7s8Q== X-Google-Smtp-Source: ABdhPJzwigYVXz2vofcgYR8WF6McxMTqCfCE2w04XtmytRTQbUcrh1yt1B0vcVv1/ZkImkLny9NzW7QBJVGP8TQlx/s= X-Received: by 2002:a17:90a:ce0d:: with SMTP id f13mr3153239pju.85.1615875758578; Mon, 15 Mar 2021 23:22:38 -0700 (PDT) MIME-Version: 1.0 References: <20210316041645.144249-1-arjunroy.kdev@gmail.com> In-Reply-To: From: Arjun Roy Date: Mon, 15 Mar 2021 23:22:27 -0700 Message-ID: Subject: Re: [mm, net-next v2] mm: net: memcg accounting for TCP rx zerocopy To: Shakeel Butt Cc: Arjun Roy , Andrew Morton , David Miller , netdev , Linux Kernel Mailing List , Cgroups , Linux MM , Eric Dumazet , Soheil Hassas Yeganeh , Jakub Kicinski , Michal Hocko , Johannes Weiner , Yang Shi , Roman Gushchin Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: daxs9r1dk1n4cfcsepnjcb37cyxbugj8 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 21588A0009C5 Received-SPF: none (google.com>: No applicable sender policy available) receiver=imf07; identity=mailfrom; envelope-from=""; helo=mail-pj1-f41.google.com; client-ip=209.85.216.41 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615875759-239810 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Mar 15, 2021 at 9:29 PM Shakeel Butt wrote: > > On Mon, Mar 15, 2021 at 9:20 PM Arjun Roy wrote: > > > [...] > > > > > > > Apologies for the spam - looks like I forgot to rebase the first time > > I sent this out. > > > > Actually, on a related note, it's not 100% clear to me whether this > > patch (which in its current form, applies to net-next) should instead > > be based on the mm branch - but the most recent (clean) checkout of mm > > fails to build for me so net-next for now. > > > > It is due to "mm: page-writeback: simplify memcg handling in > test_clear_page_writeback()" patch in the mm tree. You would need to > reintroduce the lock_page_memcg() which returns the memcg and make > __unlock_page_memcg() non-static. To clarify, Shakeel - the tag "tag: v5.12-rc2-mmots-2021-03-11-21-49" fails to build on a clean checkout, without this patch, due to a compilation failure in mm/shmem.c, for reference: https://pastebin.com/raw/12eSGdGD (and that's why I'm basing this patch off of net-next in this email). -Arjun