From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f198.google.com (mail-qk0-f198.google.com [209.85.220.198]) by kanga.kvack.org (Postfix) with ESMTP id 72E186B0033 for ; Fri, 13 Oct 2017 12:00:32 -0400 (EDT) Received: by mail-qk0-f198.google.com with SMTP id q83so6089511qke.16 for ; Fri, 13 Oct 2017 09:00:32 -0700 (PDT) Received: from aserp1040.oracle.com (aserp1040.oracle.com. [141.146.126.69]) by mx.google.com with ESMTPS id c38si1068149qtb.450.2017.10.13.09.00.31 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 13 Oct 2017 09:00:31 -0700 (PDT) Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v9DG0U2F006597 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 13 Oct 2017 16:00:31 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v9DG0TGu014530 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Fri, 13 Oct 2017 16:00:30 GMT Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id v9DG0TpH028278 for ; Fri, 13 Oct 2017 16:00:29 GMT Received: by mail-oi0-f42.google.com with SMTP id m198so14983087oig.5 for ; Fri, 13 Oct 2017 09:00:29 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <20171009221931.1481-1-pasha.tatashin@oracle.com> <20171009221931.1481-8-pasha.tatashin@oracle.com> <20171010155619.GA2517@arm.com> <20171010171047.GC2517@arm.com> <20171013144319.GB4746@arm.com> <20171013154426.GC4746@arm.com> From: Pavel Tatashin Date: Fri, 13 Oct 2017 12:00:27 -0400 Message-ID: Subject: Re: [PATCH v11 7/9] arm64/kasan: add and use kasan_map_populate() Content-Type: text/plain; charset="UTF-8" Sender: owner-linux-mm@kvack.org List-ID: To: Will Deacon Cc: linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-arm-kernel@lists.infradead.org, x86@kernel.org, kasan-dev@googlegroups.com, borntraeger@de.ibm.com, heiko.carstens@de.ibm.com, davem@davemloft.net, willy@infradead.org, Michal Hocko , Ard Biesheuvel , Mark Rutland , catalin.marinas@arm.com, sam@ravnborg.org, mgorman@techsingularity.net, Steve Sistare , daniel.m.jordan@oracle.com, bob.picco@oracle.com BTW, don't we need the same aligments inside for_each_memblock() loop? How about change kasan_map_populate() to accept regular VA start, end address, and convert them internally after aligning to PAGE_SIZE? Thank you, Pavel On Fri, Oct 13, 2017 at 11:54 AM, Pavel Tatashin wrote: >> Thanks for sharing the .config and tree. It looks like the problem is that >> kimg_shadow_start and kimg_shadow_end are not page-aligned. Whilst I fix >> them up in kasan_map_populate, they remain unaligned when passed to >> kasan_populate_zero_shadow, which confuses the loop termination conditions >> in e.g. zero_pte_populate and the shadow isn't configured properly. > > This makes sense. Thank you. I will insert these changes into your > patch, and send out a new series soon after sanity checking it. > > Pavel -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org