From: Chanho Min <chanho.min@lge.com>
To: Johannes Weiner <hannes@cmpxchg.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Cong Wang <amwang@redhat.com>,
Nicolas Pitre <nicolas.pitre@linaro.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Mel Gorman <mel@csn.ul.ie>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Chanho Min <chanho0207@gmail.com>
Subject: Re: [PATCH] vmalloc: Remove alloc_map from vmap_block.
Date: Fri, 8 Feb 2013 12:37:13 +0900 [thread overview]
Message-ID: <CAOAMb1BwVCPMLRMkMZuHhoi-meULJ-jG+O5sU4ppkR_MLDQ5dg@mail.gmail.com> (raw)
In-Reply-To: <CAOAMb1AZaXHiW47MbstoVaDVEbVaSC+fqcZoSM0EXC5RpH7nHw@mail.gmail.com>
>I started looking for workloads to profile but then lost interest.
>The current code can theoretically end up walking through a lot of
>partially used blocks if a string of allocations never fit any of
>them. The number of these blocks depends on previous allocations that
>leave them unusable for future allocations and whether any other
>vmalloc/vmap user recently flushed them all. So it's painful to think
>about it and hard to impossible to pin down should this ever actually
>result in a performance problem.
vm_map_ram() is allowed to be called by external kernel module.
I profiled some kernel module as bellow perf log. Its mapping behavior
was most of the workload. yes, we can improve its inefficient mapping.
But, This shows the allocation bitmap has the potential to cause significant
overhead.
# Overhead Command Shared Object
Symbol
# ........ ............... ...................
.............................................
#
42.74% XXXXXXTextureSc [kernel.kallsyms] [k] __reg_op
|
--- __reg_op
|
|--5.39%-- 0xaf57de00
| |
| --100.00%-- malloc
|
|--2.35%-- 0xaf57da00
| |
| --100.00%-- malloc
|
|--2.10%-- 0xaf57ce00
| |
| --100.00%-- malloc
|
|--1.46%-- 0xaf57c800
| |
| --100.00%-- malloc
|
|--1.43%-- 0xaf57dc00
| |
| --100.00%-- malloc
|
|--1.36%-- 0xaf57c200
| |
| --100.00%-- malloc
|
|--1.34%-- 0xaf57c000
| |
| --100.00%-- malloc
|
|--1.26%-- 0xae915400
| |
| --100.00%-- malloc
|
|--0.80%-- 0xae914200
| |
| --100.00%-- malloc
|
|--0.79%-- 0xaf57ca00
| |
| --100.00%-- malloc
|
|--0.67%-- 0xaf57d000
| |
| --100.00%-- malloc
|
|--0.52%-- 0xaf57cc00
| |
| --100.00%-- malloc
--80.54%-- [...]
17.39% XXXXXXTextureSc [kernel.kallsyms] [k]
bitmap_find_free_region
|
--- bitmap_find_free_region
|
|--99.93%-- vm_map_ram
| 0x7f00097c
| 0x7f00985c
| |
| |--99.79%-- 0x7f009948
| | |
| | |--50.24%-- 0x7f00ab90
| | | 0x7f006c50
| | | 0x7f00e948
| | | 0x7f019630
| | | 0x7f00f0ac
| | | 0x7f002384
| | | vfs_ioctl
| | | do_vfs_ioctl
| | | sys_ioctl
| | | ret_fast_syscall
| | |
| | |--49.60%-- 0x7f00acfc
| | | 0x7f006bfc
| | | 0x7f018fac
| | | 0x7f00f0ac
| | | 0x7f002384
| | | vfs_ioctl
| | | do_vfs_ioctl
| | | sys_ioctl
| | | ret_fast_syscall
| | | malloc
| | --0.16%-- [...]
...
Thanks
Chanho Min
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-02-08 3:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 2:27 Chanho Min
2013-02-07 8:11 ` Johannes Weiner
2013-02-08 3:37 ` Chanho Min [this message]
2013-02-08 7:01 ` Johannes Weiner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOAMb1BwVCPMLRMkMZuHhoi-meULJ-jG+O5sU4ppkR_MLDQ5dg@mail.gmail.com \
--to=chanho.min@lge.com \
--cc=akpm@linux-foundation.org \
--cc=amwang@redhat.com \
--cc=chanho0207@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=nicolas.pitre@linaro.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox