From: Yosry Ahmed <yosry@kernel.org>
To: "Kanchana P. Sridhar" <kanchanapsridhar2026@gmail.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
herbert@gondor.apana.org.au, senozhatsky@chromium.org
Subject: Re: [PATCH 0/2] zswap pool per-CPU acomp_ctx simplifications
Date: Mon, 16 Mar 2026 12:32:28 -0700 [thread overview]
Message-ID: <CAO9r8zPkzru3NeO6fcGqecFVH5N2gwVhkYL7Qw=0dvOrpU3AEQ@mail.gmail.com> (raw)
In-Reply-To: <CACpmpodX-EqcS6e83W82YtSnRmFhbF6Evgaot3deqAVGFeV24w@mail.gmail.com>
> > > > Actually looking at zswap_cpu_comp_dead(), is the IS_ERR_OR_NULL()
> > > > check on acomp_ctx also misleading? Should that also just be a NULL
> > > > check?
> > >
> > > Even a NULL check would be redundant in this case, per my
> > > understanding, because if the alloc_percpu() call in
> > > zswap_pool_create() had failed, pool creation would have failed.
> > >
> > > I think a NULL check on the acomp_ctx would still be a good idea, just
> > > in case, since this is all part of CPU hotplug. I agree, we don't need
> > > an IS_ERR() check on acomp_ctx.
> >
> > So I think we do one patch to convert both IS_ERR_OR_NULL() to NULL
> > checks, and then the current patch 1, right?
>
> Yes.
Sounds good, thanks for bearing with me :)
prev parent reply other threads:[~2026-03-16 19:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-14 5:16 Kanchana P. Sridhar
2026-03-14 5:16 ` [PATCH 1/2] mm: zswap: Tie per-CPU acomp_ctx lifetime to the pool Kanchana P. Sridhar
2026-03-16 15:07 ` Yosry Ahmed
2026-03-16 18:21 ` Kanchana P. Sridhar
2026-03-14 5:16 ` [PATCH 2/2] mm: zswap: Consistently use IS_ERR_OR_NULL() to check acomp_ctx resources Kanchana P. Sridhar
2026-03-15 0:11 ` [PATCH 0/2] zswap pool per-CPU acomp_ctx simplifications Andrew Morton
2026-03-15 3:30 ` Kanchana P. Sridhar
2026-03-16 15:06 ` Yosry Ahmed
2026-03-16 15:09 ` Yosry Ahmed
2026-03-16 18:22 ` Kanchana P. Sridhar
2026-03-16 18:20 ` Kanchana P. Sridhar
2026-03-16 18:30 ` Yosry Ahmed
2026-03-16 19:21 ` Kanchana P. Sridhar
2026-03-16 19:24 ` Yosry Ahmed
2026-03-16 19:31 ` Kanchana P. Sridhar
2026-03-16 19:32 ` Yosry Ahmed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9r8zPkzru3NeO6fcGqecFVH5N2gwVhkYL7Qw=0dvOrpU3AEQ@mail.gmail.com' \
--to=yosry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=kanchanapsridhar2026@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox