From: Yosry Ahmed <yosry@kernel.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Kanchana P. Sridhar" <kanchanapsridhar2026@gmail.com>,
hannes@cmpxchg.org, nphamcs@gmail.com, chengming.zhou@linux.dev,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
herbert@gondor.apana.org.au, senozhatsky@chromium.org
Subject: Re: [PATCH v2 0/2] zswap pool per-CPU acomp_ctx simplifications
Date: Tue, 17 Mar 2026 12:48:00 -0700 [thread overview]
Message-ID: <CAO9r8zPHpfGHaz_crbSwB6hhyLpZ6+L22XjtM9WY=NvC87n9Yg@mail.gmail.com> (raw)
In-Reply-To: <20260317124528.961ebeaac03f69e65cb767e8@linux-foundation.org>
On Tue, Mar 17, 2026 at 12:45 PM Andrew Morton
<akpm@linux-foundation.org> wrote:
>
> On Mon, 16 Mar 2026 18:48:00 -0700 "Kanchana P. Sridhar" <kanchanapsridhar2026@gmail.com> wrote:
>
> > This patchset first removes redundant checks on the acomp_ctx and its
> > "req" member in zswap_cpu_comp_dead().
> >
> > Next, it persists the zswap pool's per-CPU acomp_ctx resources to
> > last until the pool is destroyed. It then simplifies the per-CPU
> > acomp_ctx mutex locking in zswap_compress()/zswap_decompress().
> >
> > Code comments added after allocation and before checking to deallocate
> > the per-CPU acomp_ctx's members, based on expected crypto API return
> > values and zswap changes this patchset makes.
> >
> > Patch 2 is an independent submission of patch 23 from [1], to
> > facilitate merging.
>
> Thanks.
>
> What happened with "mm: zswap: Consistently use IS_ERR_OR_NULL() to
> check acomp_ctx resources"? Still relevant?
>
> https://lkml.kernel.org/r/20260314051632.17931-3-kanchanapsridhar2026@gmail.com
We decided to drop it (and patch 1 here kinda sorta takes its place):
https://lore.kernel.org/all/CACpmpoeo0LhxkoA5Wx6q+9=2scn_az0u=3bar-JgBvTA-ZBkZg@mail.gmail.com/
next prev parent reply other threads:[~2026-03-17 19:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-17 1:48 Kanchana P. Sridhar
2026-03-17 1:48 ` [PATCH v2 1/2] mm: zswap: Remove redundant checks in zswap_cpu_comp_dead() Kanchana P. Sridhar
2026-03-17 19:19 ` Yosry Ahmed
2026-03-17 21:09 ` Kanchana P. Sridhar
2026-03-17 1:48 ` [PATCH v2 2/2] mm: zswap: Tie per-CPU acomp_ctx lifetime to the pool Kanchana P. Sridhar
2026-03-27 2:23 ` Andrew Morton
2026-03-27 19:30 ` Kanchana P. Sridhar
2026-03-30 18:32 ` Yosry Ahmed
2026-03-30 18:51 ` Andrew Morton
2026-03-30 18:52 ` Yosry Ahmed
2026-03-30 18:59 ` Kanchana P. Sridhar
2026-03-30 19:12 ` Andrew Morton
2026-03-30 19:13 ` Yosry Ahmed
2026-03-30 21:53 ` Kanchana P. Sridhar
2026-03-30 21:47 ` Kanchana P. Sridhar
2026-03-17 19:45 ` [PATCH v2 0/2] zswap pool per-CPU acomp_ctx simplifications Andrew Morton
2026-03-17 19:48 ` Yosry Ahmed [this message]
2026-03-17 21:15 ` Kanchana P. Sridhar
2026-03-17 21:21 ` Kanchana P. Sridhar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9r8zPHpfGHaz_crbSwB6hhyLpZ6+L22XjtM9WY=NvC87n9Yg@mail.gmail.com' \
--to=yosry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=chengming.zhou@linux.dev \
--cc=hannes@cmpxchg.org \
--cc=herbert@gondor.apana.org.au \
--cc=kanchanapsridhar2026@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nphamcs@gmail.com \
--cc=senozhatsky@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox