From: Yosry Ahmed <yosry@kernel.org>
To: Li Wang <liwang@redhat.com>
Cc: akpm@linux-foundation.org, yosryahmed@google.com,
nphamcs@gmail.com, hannes@cmpxchg.org, mhocko@kernel.org,
mkoutny@suse.com, muchun.song@linux.dev, tj@kernel.org,
roman.gushchin@linux.dev, shakeel.butt@linux.dev,
longman@redhat.com, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v4 1/7] selftests/cgroup: skip test_zswap if zswap is globally disabled
Date: Mon, 23 Mar 2026 17:13:14 -0700 [thread overview]
Message-ID: <CAO9r8zOwPnP9_AMX7Z_w4jLMYP=Ujs3BxNLWVXHOEAKVGFGfmQ@mail.gmail.com> (raw)
In-Reply-To: <20260322061038.156146-2-liwang@redhat.com>
> diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zswap.c
> index 64ebc3f3f203..e69d845d3592 100644
> --- a/tools/testing/selftests/cgroup/test_zswap.c
> +++ b/tools/testing/selftests/cgroup/test_zswap.c
> @@ -589,9 +589,21 @@ struct zswap_test {
> };
> #undef T
>
> -static bool zswap_configured(void)
> +static void check_zswap_enabled(void)
> {
> - return access("/sys/module/zswap", F_OK) == 0;
> + char value[2];
> +
> + if (access("/sys/module/zswap", F_OK))
> + ksft_exit_skip("zswap isn't configured\n");
> +
> + if (read_text("/sys/module/zswap/parameters/enabled", value,
> + sizeof(value)) <= 0)
> + ksft_exit_fail_msg("Failed to read "
> + "/sys/module/zswap/parameters/enabled\n");
> +
> + if (value[0] == 'N')
> + ksft_exit_skip("zswap is disabled (hint: echo 1 > "
> + "/sys/module/zswap/parameters/enabled)\n");
> }
In the next version please put "/sys/module/zswap" and
"/sys/module/zswap/parameters/enabled" in macros to avoid all the line
breaks here.
next prev parent reply other threads:[~2026-03-24 0:13 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-22 6:10 [PATCH v4 0/7] selftests/cgroup: improve zswap tests robustness and support large page sizes Li Wang
2026-03-22 6:10 ` [PATCH v4 1/7] selftests/cgroup: skip test_zswap if zswap is globally disabled Li Wang
2026-03-24 0:13 ` Yosry Ahmed [this message]
2026-03-24 6:46 ` Li Wang
2026-03-27 18:21 ` Nhat Pham
2026-03-22 6:10 ` [PATCH v4 2/7] selftests/cgroup: avoid OOM in test_swapin_nozswap Li Wang
2026-03-22 6:10 ` [PATCH v4 3/7] selftests/cgroup: use runtime page size for zswpin check Li Wang
2026-03-22 6:10 ` [PATCH v4 4/7] selftests/cgroup: rename PAGE_SIZE to BUF_SIZE in cgroup_util Li Wang
2026-03-22 6:10 ` [PATCH v4 5/7] selftests/cgroup: replace hardcoded page size values in test_zswap Li Wang
2026-03-24 0:05 ` Yosry Ahmed
2026-03-22 6:10 ` [PATCH v4 6/7] selftest/cgroup: fix zswap test_no_invasive_cgroup_shrink on large pagesize system Li Wang
2026-03-22 6:10 ` [PATCH v4 7/7] selftest/cgroup: fix zswap attempt_writeback() on 64K " Li Wang
2026-03-22 16:18 ` [PATCH v4 0/7] selftests/cgroup: improve zswap tests robustness and support large page sizes Andrew Morton
2026-03-23 3:23 ` Li Wang
2026-03-24 0:12 ` Yosry Ahmed
2026-03-24 12:16 ` Li Wang
2026-03-24 20:28 ` Yosry Ahmed
2026-03-25 2:26 ` Li Wang
2026-03-25 2:49 ` Yosry Ahmed
2026-03-25 6:12 ` Li Wang
2026-03-25 6:17 ` Li Wang
2026-03-25 7:21 ` Li Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAO9r8zOwPnP9_AMX7Z_w4jLMYP=Ujs3BxNLWVXHOEAKVGFGfmQ@mail.gmail.com' \
--to=yosry@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwang@redhat.com \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=nphamcs@gmail.com \
--cc=roman.gushchin@linux.dev \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox