From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 814D8CFB440 for ; Mon, 7 Oct 2024 08:57:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CA9D26B00B3; Mon, 7 Oct 2024 04:57:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C30726B00B4; Mon, 7 Oct 2024 04:57:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF84D6B00B5; Mon, 7 Oct 2024 04:57:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 8D00A6B00B3 for ; Mon, 7 Oct 2024 04:57:32 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id EA4641214DF for ; Mon, 7 Oct 2024 08:57:31 +0000 (UTC) X-FDA: 82646202702.03.634DD70 Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by imf16.hostedemail.com (Postfix) with ESMTP id 38AC8180002 for ; Mon, 7 Oct 2024 08:57:30 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gH4euScH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of aha310510@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=aha310510@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728291302; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BItnmLiFpdp+oHJs3c/Wx0gYeM6qW5xxVzKlwJ1FPGY=; b=E94xVWN+PfYa3YTiqP7eXPTAr7bx3vy6/ER36YH0sV7RcNjO0XP2SKtGfIbhje1UD8D3hq tTxTOBV+18HBf2p1JGn5b8hxuptAODlxiMB6QSt8jXrbrZvGCpJPPIwQsAjaCE+zoQD5Bj h1kSmsx0i5PDom3So1bcmcnvo8RyPAE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728291302; a=rsa-sha256; cv=none; b=NQcnetZtmFPbjb4h/2fJdV61Me+7W47UsbZnlX1wPB7M8sWWNK+Jaqd49Gntncej6pOG1K LuZEx8UkyGfRRpgpBvVZCEu0MO4uepl85apW0/+27qiBUY/CwMw/H2YnyigFdG5RNh6HCS SxPSdft8Q5OFSuzd+8TQr7/+Nftj7VY= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=gH4euScH; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf16.hostedemail.com: domain of aha310510@gmail.com designates 209.85.216.53 as permitted sender) smtp.mailfrom=aha310510@gmail.com Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2e109539aedso3478922a91.0 for ; Mon, 07 Oct 2024 01:57:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1728291449; x=1728896249; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=BItnmLiFpdp+oHJs3c/Wx0gYeM6qW5xxVzKlwJ1FPGY=; b=gH4euScHBRcCsNy2VWAdz/lNJn9pyPa4CSXA0pNpD3OmFU7NbDg4hl5NnyuYQkmXA8 9QPUDguLr/DlxnSPw+kwhq8V9zQYov6/ZKXqSTTdfR711bcocdDHlQq3+fdrfUDRPAXz l49aJ2gSycSuZZnJmFcUaP13QFlU5iYo5xfT+cpYhvXiteKl4NubT4/96+pGiNlAwIvV zYCzzEUU+CHAAgSmc9eNTLrbvd2rbKhwfThdY4RYT14pCtYtADt6trArh9OdHGuEzY8n MAD4Gw/M5221qEYcPimdcidxUpAxk37FbUSDkGPe25Is5zNllUEKAG1xX5LQCxFX/k4K uHOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728291449; x=1728896249; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=BItnmLiFpdp+oHJs3c/Wx0gYeM6qW5xxVzKlwJ1FPGY=; b=SLUyTVBEqReQJSualhIndiwOm8G4QoJjR+CHOiZ1QeRaOt/E1wa4yK7POvHTmfKnWQ N0G2wKgElQT/C/IdQD3KWBiYvQoGdHqUGqveWvsdSLcZAuUe8mxf1F8Bkf5y7Xm0Y8Q+ pB0AUeJ2KwwhBdTJzuJU+SU24DeoZoddmeSTqD7evaL5xgUVDEJhTYhyvUw1TxXhpCtC zUmwJUOk1ceEQZAb1xdMQlPEBs9FmQEhGxkMD9d8ITq0Zh20mnbfH3nRtHRO6PLcezlV Eik9Ce8KXldq1mC3/YE+znkmiH11WgMztRswiMWQ9XQIKU/xrxCOghGMCzqNtGbDIAx8 5l0Q== X-Forwarded-Encrypted: i=1; AJvYcCV9bwQtLmotNLg0b2NFGbOCig6jTZ30+IMQ1krQeYx2fLU6IApVnA8lt4iLTDcsm2Gx/q2x9KCAaw==@kvack.org X-Gm-Message-State: AOJu0YzVDciApFluIjjqGQluPsdlsfS2jZ7g5nrEaLLhcA/C2DNfJGhj zQPVLTjK3VlDJZKDRv412oWJ23ivVDFv6s/PKAyX0xDoc0LLFJVgjgFKxtpTC5DUveqpb32/PKv t7cd/I8555JpxyOriWFiOjemoIO1r4GCg X-Google-Smtp-Source: AGHT+IEXWmQV0bh6jO3MKbhqkKxGQEjbmFmz4MGs5ETbgrmLuMpRzBG54K0IsT96JLIWKcCQ8RsDwafu2u4Z7SklZGk= X-Received: by 2002:a17:90a:b015:b0:2e1:ce67:5d2e with SMTP id 98e67ed59e1d1-2e1e6213b03mr16405915a91.5.1728291448818; Mon, 07 Oct 2024 01:57:28 -0700 (PDT) MIME-Version: 1.0 References: <20241007065307.4158-1-aha310510@gmail.com> <2024100748-exhume-overgrown-bf0d@gregkh> In-Reply-To: <2024100748-exhume-overgrown-bf0d@gregkh> From: Jeongjun Park Date: Mon, 7 Oct 2024 17:57:18 +0900 Message-ID: Subject: Re: [PATCH] mm: remove the newlines, which are added for unknown reasons and interfere with bug analysis To: Greg KH Cc: akpm@linux-foundation.org, usama.anjum@collabora.com, peterx@redhat.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 38AC8180002 X-Stat-Signature: f8ekrdnekg3c9i7m4k4ndp7meanwross X-Rspam-User: X-HE-Tag: 1728291450-837444 X-HE-Meta: U2FsdGVkX19e2krziqh8Glxu++i9yRvXn+BgxX9U4fUXZw4mD7svEIC5MWEC48jpPHmmbuJY0zmnkx8ev/8TzOTCG4Vm6O5D1Ht5AwzGCj07HRUEw94UWaaBj2Um2JMEwlq29cEKB9SiNHE671aB3OQmSFYKLqKgbS+QVK2+A//FM42uWJ4jxoWyWpH6fnAHqonNobz3be8GBSwyP9O/m6HknWUSfPE2UXWi7kiNUu8OlMEmxXyfqWvb9O4kgS2sLCyndolNXfBmkZeN6+JJpUFMdycTqAoFQR98pLNwSWd4VHeqA/ZdGrJbgzm671AKVSAAvIWYQ4HH+NusWONvqJ1IqQOF4j6whnlnbyevSBBYOymi12xS9K+h5MrjXfn8hce7zQiWp/DVm18WAuTGPBIQGqCiqeABafr2LI6MVt+OManvoeotaV24jQ5zheYoHuuV9T/IPSAgOe/xs02FYJ4Ph5zc47ku8GeoJNMhme/sFcgmqemma8cU6JGAoyzGLYMWo8rBYx4WaoyeHkLP3eQJJbDuQGX69HzCHgKbWAzpL206jbM9p2McWpsx6aMNTOqHasyUgG16BH1ZarmY0YXh9HzGUFaaK4bkwSPouxhTBdabY6hpG4KuZguAyhd+LtN9uHZKzHI/+dHLSD5n7sq99miQ5ST94pvNAggdErLURLzOgRF05KI8aHcXFHRa7LZVHbMQvJSuhrL87TZ3hXvI1Kjmf0/DGI8bJgyxlEEcbVnema63t6+TS13Fvz7ztSFCRB4SRZWC3oED6dfEBud0zN5WURIXrmg1rEYf7JWPwy3QP5VwA9IAAjVDMY7qfjXMt6k6KM5MWUFlSc/9rXDHyDXCa6945Oidb2BSu3b2Euj+webnnXDX0HWozM4+pBx5J109dfxx2xJUXFhApNmKX6B73JtOUKSh2jy2DmW7aC77KlN/GRShUCrJWijX9AFv0yOSG/xhYq2Uffn bj5h49Lr IB2rYR5CxS8J4XUnleqEl1kWRmLc6kQ5dsH4LvUiUfo/v60XmkjgWbimDcIbeKZCx5V0hbIQnjVftQXCrN5cQbKiJN6Q/WHOoGTYJ/0uuHYDNJJJ6zsL4ZLN99j2em3muvLIIhY0Npyv8Ma18vYd4lTb3iHxyIcVJpNKNWda2NjwMj//hDzQsPJczM6qjK4lOYytJP/1na89Ftiw0/WUjNcDKjWQOtalNp6JZJcI92xrnFtECoFWY673RTMdcIqAd0uyg/pnO3ZfBw6siaDKW3md2c8VouHRbachgUtfBNzPyjmaFCd9WD09Oi5k1141JzJ8jacO64blR2rGS8xzs0SPTLbN6+4v301lHOMql5xwj4iJfnThTy97o7R7AyD0dp7pl7MFr8v34z/8eBDXcjhtTEGprZxvxR8+OU668cSIUjtyDgFO6InGQOTHYYbAqr1pQdHc90ho3BVyAMhby53rg2Pf5z7WqoiTtgJJveFYd6R01lyo/er8nWOdW9MZRpffE X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Greg KH wrote: > > On Mon, Oct 07, 2024 at 03:53:07PM +0900, Jeongjun Park wrote: > > Looking at the source code links for mm/memory.c in the sample reports > > in the syzbot report links [1]. > > > > it looks like the line numbers are designated as lines that have been > > increased by 1. This may seem like a problem with syzkaller or the > > addr2line program that assigns the line numbers, but there is no problem > > with either of them. > > > > In the previous commit d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC"), > > when modifying mm/memory.c, an unknown line break is added to the very first > > line of the file. However, the git.kernel.org site displays the source code > > with the added line break removed, so even though addr2line has assigned > > the correct line number, it looks like the line number has increased by 1. > > > > This may seem like a trivial thing, but I think it would be appropriate > > to remove all the newline characters added to the upstream and stable > > versions, as they are not only incorrect in terms of code style but also > > hinder bug analysis. > > > > [1] > > > > https://syzkaller.appspot.com/bug?extid=4145b11cdf925264bff4 > > https://syzkaller.appspot.com/bug?extid=fa43f1b63e3aa6f66329 > > https://syzkaller.appspot.com/bug?extid=890a1df7294175947697 > > > > Fixes: d61ea1cb0095 ("userfaultfd: UFFD_FEATURE_WP_ASYNC") > > Cc: stable@vger.kernel.org > > Signed-off-by: Jeongjun Park > > --- > > mm/memory.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/mm/memory.c b/mm/memory.c > > index 2366578015ad..7dffe8749014 100644 > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -1,4 +1,3 @@ > > - > > This sounds like you have broken tools that can not handle an empty line > in a file. > > Why not fix those? As I mentioned above, there is no problem with addr2line's ability to parse the code line that called the function in the calltrace of the crash report. However, when the source code of mm/memory.c is printed on the screen on the git.kernel.org site, the line break character that exists in the first line of the file is deleted and printed, so as a result, all code lines in the mm/memory.c file are located at line numbers that are -1 less than the actual line. You can understand it easily if you compare the source code of mm/memory.c on github and git.kernel.org. https://github.com/torvalds/linux/blob/master/mm/memory.c https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/mm/memory.c Since I cannot modify the source code printing function of the git.kernel.org site, the best solution I can suggest is to remove the unnecessary line break character that exists in all versions. > > Also, your changelog text has trailing whitespace, ironic for a patch > that does a whitespace cleanup :) > Oops, I forgot to remove the trailing space in the patch description. If you absolutely must remove the space, I'll write a v2 patch and send it to you. Regards, Jeongjun Park > thanks, > > greg k-h