From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08069C7EE30 for ; Tue, 1 Jul 2025 16:01:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A46496B0099; Tue, 1 Jul 2025 12:01:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A1DBA6B009A; Tue, 1 Jul 2025 12:01:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 95B1D6B009C; Tue, 1 Jul 2025 12:01:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 819146B0099 for ; Tue, 1 Jul 2025 12:01:27 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3CEA359686 for ; Tue, 1 Jul 2025 16:01:27 +0000 (UTC) X-FDA: 83616160614.26.1902175 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf18.hostedemail.com (Postfix) with ESMTP id 5196B1C000A for ; Tue, 1 Jul 2025 16:01:25 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="C/KGqJD5"; spf=pass (imf18.hostedemail.com: domain of aha310510@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=aha310510@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751385685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uisESkonBUWUBmIeoW49mxXUGOwwBm+Ncm8zQB5RiFA=; b=dvYUE9FwgbaxIbgdoucNyYN6/61tBi485zLt8bf6CmocnKFbKGjnzDNgKLwCmz/NofA0GP iw46nLdUZEGxdOr+X8/t5ji8lruLP4zjhlMsxgWLELVS5V6GvwHwuUMOX3J3sdAxDX8EQr DGhBe/fQ/HXNCYYUwWAzBahS5nffC/k= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b="C/KGqJD5"; spf=pass (imf18.hostedemail.com: domain of aha310510@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=aha310510@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751385685; a=rsa-sha256; cv=none; b=Qeohgj7zTHLr4guyufTMF4yiSQ/2dadS0KifdSbniLJ6/fZCIZbIe0oIwOqhbFd4Jp+6GB 5tQBbMoUYWRstoPel9zDx1/FeWujqaHzcIoAbSGLBc1/l+UpTi+/VvJ/7+qjyi/5CxdYrG t5ZO3OdrINyma8EAlCILYLltLCQ1igg= Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-3135f3511bcso2768069a91.0 for ; Tue, 01 Jul 2025 09:01:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751385684; x=1751990484; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=uisESkonBUWUBmIeoW49mxXUGOwwBm+Ncm8zQB5RiFA=; b=C/KGqJD5hMJlzNjaggKjMWsI2iweK9GO+XsZ6Zeyp2kqMjWt1MY67aQrvuUnqEZddD lj4IqYn62WQsS9+Wk3WhWGxX5MKdr5rTort+3cmZV3HAWKI8Xgfw3IM1a8fAkGiwy8jz xLzNPIbo3H1FgtQ7FMjuYkkXeMjtGWfBCTxzsITigw3c05bHj9vVt9AfT9J6hEXgzslw aUAuQZTUbXUq5XaZE2TKPnIka99kMXugRRZnOJ5/tlQHP1B356f3sCJ83+SneMHMZ8Ya zvSruQft4eVgZd8eUmhYvivWbv3193COaTC8FExXSA+EOYW6RRFWXh9WvDyP2Knd8EGd QHcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751385684; x=1751990484; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=uisESkonBUWUBmIeoW49mxXUGOwwBm+Ncm8zQB5RiFA=; b=tzdM1UAjirt3tHvF4ykwQHwqxIQVJQDEzBfGO9lwZULXQ/4acdrf02ijJdkED0dR/j EINPnGyK9TxxP/HBwHTNQ7IOp+A5w2KPC+oC5jvF+E37T6h2RrWoJ84QUMtlK+l5w8of 0w+Y+VRz8PxiEZuq1a8SL/rLhw4B1ZpIzsl6sTTFNZoESBlJis9ItUWsfmGoWMtvuZdM myA1WUY0OQaaEXcrHYIcUD1J3KhpyCAlokyVjfsgAkOfW9tATcRwUEkxXjTAFq2LcALM b+WM2O5xSTCFxgvZPf2EXmeZX0g9BH5Je+WtcjZ8/lZusoJO4UgzxPSPMlvP8CnuQ7/6 Mn2Q== X-Forwarded-Encrypted: i=1; AJvYcCWkJ147W0Ey0eH592jfXxY5gotgLek4AD19nIqiBTQBrkdwQ5Fko1mXlc6iL5OZV6W4gJFgc7i7Jw==@kvack.org X-Gm-Message-State: AOJu0YyvdAMKkAYzMCgDrgb+47bGcG+ZvFaYX0CpiJ3K/pXposmSRGGn YXBdLCxea6Q97vn6Uu9A01zXZne47edkXd/AwUPKlVh55RMxvjocYQzXMPaiKqsBVudd3gIunJP HcWdeCJ4ayFkdQlmxkDeejQb84DTgTSO/ldwXIlI= X-Gm-Gg: ASbGncsmA6n9Yz5YBMAXN6sWdjKhNos78t5KNWpg9GcxfSg/WvpxLUSb2T7HToaZ4J2 D1YffIZ6mfQ2YI1ejuh53PTNedpkuZy5ZeBOtxtUQA/65imeCEVydzeKLa1MrLq1GASus9nJfCN ckYHZBs0j4IIlhiExUvhiP5bmki8uaasRfjinXJDtOEkGosQ== X-Google-Smtp-Source: AGHT+IH6Cx9Yc731Xxe2ydwQj2xiAkV7TV9T3hkfm6m9g8Kwhaxvt5PIVpOtZo27JQ1LkizhaXhQ5w02IZV2yYfdi54= X-Received: by 2002:a17:90b:2ccf:b0:312:ea46:3e66 with SMTP id 98e67ed59e1d1-318c9243c60mr23628437a91.21.1751385683857; Tue, 01 Jul 2025 09:01:23 -0700 (PDT) MIME-Version: 1.0 References: <20250508165620.15321-1-aha310510@gmail.com> In-Reply-To: From: Jeongjun Park Date: Wed, 2 Jul 2025 01:01:13 +0900 X-Gm-Features: Ac12FXyegzFC6xqckWv5nEFdajf7y1d6733Mt2qrt4c49r4d2EE_cE6cWOkSVyY Message-ID: Subject: Re: [PATCH v6] mm/vmalloc: fix data race in show_numa_info() To: Uladzislau Rezki Cc: akpm@linux-foundation.org, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: 37hkgwkshiwgu5oh8nytab61nqsx6ixq X-Rspamd-Queue-Id: 5196B1C000A X-Rspamd-Server: rspam11 X-Rspam-User: X-HE-Tag: 1751385685-234426 X-HE-Meta: U2FsdGVkX18WjYndFJzSeNaRbJ+xSKY81Jt2MdsjAah3wBSyqL0UYaR7S73Y2VOYMNiXeSY6mFVV4pSnArp+ex7sB2bo+4HeuWG7aDClXGu03yJz9H+Fsyhq1fO6a6QTY3eQGOnEsODHzhWM4IKgXu1tx1vD7sUbxOr7HQERzLN6gAfGSJxmh8yBiZTkVbAGxtdGLk+wBQgtibXpoxQB9aMotpzZYG/6M0wZ1+isMMUDSwv9r8eyz+/I99otzwulEyBFPoSW2R939xYQ/95FAbdHP5v/V0nMmqzRBCBRc6SL9Huu0pS7xcTDO2qjP7rE00Qd4McThaKhfcWb7J1zqoy7/dLciDUAoDEiiQdVhR6XDW9CBYkDIuGdzyd5R8netUq+Q5K+umrwjmS+x+wK0nJCiphmrwAiiZmiG/UBpoOkxG/qGFBbRl55z7pCCGSpasAxE1gD6Fs1GZpvdewUHZSuG0K2r0m6okcduauhB4vfmqAWYvD8E0nnctQSWryFFPqILVduHwLNNOkT1lSc0I82Cl2mrtUglb25RdaBKDI99lZ6adcArXJTP4Bw3UUBYa4Hbu+V9A5AX9UVjXFQ1QuWySJDRxXczTqbrQsVcJi2ABfJqztcuoEX9EgACCxc67+rd3oY4AnQeemfKjz96U4OKzABFaJUZBwyErwTzU4q7Vag63mchoHofP5sYbbEtGUaFMGUvBOQs360YT/UG0GVKxd2Hr1abN6PyuCfPefxuJhBVlUjcWPUXXQIGTlIA32OrnhYVVw0LDvKn5h8aG++x6EuECRgX7UNfsc9xufygH4O78lhjgowceUgLZU7GA9PWaq0f8uywRZZ+qivP9yeuxrS7m6Qa4t11QIMeU7H3oPc2MAC1D/ERtvck5PQU3Ogxc21qoTxb7HTU5IT0Tp5N8XKc2MNa50uB2zIPUZkFwOxSAlywH6SSUeIwRMV4wH6f42C1wn00NaAKzB GxXHwrNH nXGWxWx147gON02YwA4HbzOQZk51+mHn7EJ1TOi6WYVORC3WInu5IJpoehHjhd+AfgmJup28Ph9rq0CcOWaVeg83aIpU09za7wYPL36hTVW1E47zbS2/yf4tDbVQYsLvx6TsaKl6sWf6vumv2/bMu8/kzr75EURUZWPauht00LBmKoemDROD6Eykth8i84qvwjz+C65nfZdugZy8zbFpuNODBdPam93rJxi/HGFC1NmUEHXpB/fdYXU1BTMIJmSX9L5No9LIr4KmA2lcxcw0Z2nrrVnyWBBUB1+rJBzD2nvOJMU0/saPREd2x/FBMoRwx0dzww8X07OK69IylcFLb5mSid5S0JEC9LuvM/FGdLAantGl/j3XX/V831fXSNcdIFL4HjMFghbH+ZagnNv2F22GHxaxwDomMF+kDaUtEYmCXM/mforLu0/hsjrwJqIdcJgpbiIukuBXD46UC8AMlsfFfjg++EG2cZJQey0yRuLqEoaz6sdbBcdnL5pmx6SqBY0gAjK/b3m0wvnbC2nsOF0S/zJlBoIgmXPGpPQzAGuTOkyriEU458TQpDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Uladzislau Rezki wrote: > > On Thu, May 08, 2025 at 07:48:55PM +0200, Uladzislau Rezki wrote: > > On Fri, May 09, 2025 at 01:56:20AM +0900, Jeongjun Park wrote: > > > The following data-race was found in show_numa_info(): > > > > > > ================================================================== > > > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > > > > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > > > show_numa_info mm/vmalloc.c:4936 [inline] > > > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > > .... > > > > > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > > > show_numa_info mm/vmalloc.c:4934 [inline] > > > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > > .... > > > > > > value changed: 0x0000008f -> 0x00000000 > > > ================================================================== > > > > > > According to this report,there is a read/write data-race because m->private > > > is accessible to multiple CPUs. To fix this, instead of allocating the heap > > > in proc_vmalloc_init() and passing the heap address to m->private, > > > vmalloc_info_show() should allocate the heap. > > > > > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > > > Suggested-by: Eric Dumazet > > > Suggested-by: Uladzislau Rezki (Sony) > > > Suggested-by: Andrew Morton > > > Signed-off-by: Jeongjun Park > > > --- > > > v6: Change CONFIG_NUMA to must be check before doing any work related to the counters array. > > > - Link to v5: https://lore.kernel.org/all/20250508160800.12540-1-aha310510@gmail.com/ > > > v5: Change heap to be allocated only when CONFIG_NUMA is enabled > > > - Link to v4: https://lore.kernel.org/all/20250508065558.149091-1-aha310510@gmail.com/ > > > v4: Change the way counters array heap is allocated, per Andrew Morton's suggestion. > > > And fix it to call smp_rmb() in the correct location. > > > - Link to v3: https://lore.kernel.org/all/20250507142552.9446-1-aha310510@gmail.com/ > > > v3: Following Uladzislau Rezki's suggestion, we check v->flags beforehand > > > to avoid printing uninitialized members of vm_struct. > > > - Link to v2: https://lore.kernel.org/all/20250506082520.84153-1-aha310510@gmail.com/ > > > v2: Refactoring some functions and fix patch as per Eric Dumazet suggestion > > > - Link to v1: https://lore.kernel.org/all/20250505171948.24410-1-aha310510@gmail.com/ > > > --- > > > mm/vmalloc.c | 63 +++++++++++++++++++++++++++++----------------------- > > > 1 file changed, 35 insertions(+), 28 deletions(-) > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > index 3ed720a787ec..c1ea9713a1c0 100644 > > > --- a/mm/vmalloc.c > > > +++ b/mm/vmalloc.c > > > @@ -3100,7 +3100,7 @@ static void clear_vm_uninitialized_flag(struct vm_struct *vm) > > > /* > > > * Before removing VM_UNINITIALIZED, > > > * we should make sure that vm has proper values. > > > - * Pair with smp_rmb() in show_numa_info(). > > > + * Pair with smp_rmb() in vread_iter() and vmalloc_info_show(). > > > */ > > > smp_wmb(); > > > vm->flags &= ~VM_UNINITIALIZED; > > > @@ -4914,28 +4914,29 @@ bool vmalloc_dump_obj(void *object) > > > #endif > > > > > > #ifdef CONFIG_PROC_FS > > > -static void show_numa_info(struct seq_file *m, struct vm_struct *v) > > > -{ > > > - if (IS_ENABLED(CONFIG_NUMA)) { > > > - unsigned int nr, *counters = m->private; > > > - unsigned int step = 1U << vm_area_page_order(v); > > > > > > - if (!counters) > > > - return; > > > +/* > > > + * Print number of pages allocated on each memory node. > > > + * > > > + * This function can only be called if CONFIG_NUMA is enabled > > > + * and VM_UNINITIALIZED bit in v->flags is disabled. > > > + */ > > > +static void show_numa_info(struct seq_file *m, struct vm_struct *v, > > > + unsigned int *counters) > > > +{ > > > + unsigned int nr; > > > + unsigned int step = 1U << vm_area_page_order(v); > > > > > > - if (v->flags & VM_UNINITIALIZED) > > > - return; > > > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > > - smp_rmb(); > > > + if (!counters) > > > + return; > > > > > > - memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > > + memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > > > > > - for (nr = 0; nr < v->nr_pages; nr += step) > > > - counters[page_to_nid(v->pages[nr])] += step; > > > - for_each_node_state(nr, N_HIGH_MEMORY) > > > - if (counters[nr]) > > > - seq_printf(m, " N%u=%u", nr, counters[nr]); > > > - } > > > + for (nr = 0; nr < v->nr_pages; nr += step) > > > + counters[page_to_nid(v->pages[nr])] += step; > > > + for_each_node_state(nr, N_HIGH_MEMORY) > > > + if (counters[nr]) > > > + seq_printf(m, " N%u=%u", nr, counters[nr]); > > > } > > > > > > static void show_purge_info(struct seq_file *m) > > > @@ -4962,8 +4963,12 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > struct vmap_node *vn; > > > struct vmap_area *va; > > > struct vm_struct *v; > > > + unsigned int *counters; > > > int i; > > > > > > + if (IS_ENABLED(CONFIG_NUMA)) > > > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > > > + > > > for (i = 0; i < nr_vmap_nodes; i++) { > > > vn = &vmap_nodes[i]; > > > > > > @@ -4979,6 +4984,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > } > > > > > > v = va->vm; > > > + if (v->flags & VM_UNINITIALIZED) > > > + continue; > > > + > > > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > > + smp_rmb(); > > > > > > seq_printf(m, "0x%pK-0x%pK %7ld", > > > v->addr, v->addr + v->size, v->size); > > > @@ -5013,7 +5023,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > if (is_vmalloc_addr(v->pages)) > > > seq_puts(m, " vpages"); > > > > > > - show_numa_info(m, v); > > > + if (IS_ENABLED(CONFIG_NUMA)) > > > + show_numa_info(m, v, counters); > > > + > > > seq_putc(m, '\n'); > > > } > > > spin_unlock(&vn->busy.lock); > > > @@ -5023,19 +5035,14 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > > * As a final step, dump "unpurged" areas. > > > */ > > > show_purge_info(m); > > > + if (IS_ENABLED(CONFIG_NUMA)) > > > + kfree(counters); > > > return 0; > > > } > > > > > > static int __init proc_vmalloc_init(void) > > > { > > > - void *priv_data = NULL; > > > - > > > - if (IS_ENABLED(CONFIG_NUMA)) > > > - priv_data = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > > > - > > > - proc_create_single_data("vmallocinfo", > > > - 0400, NULL, vmalloc_info_show, priv_data); > > > - > > > + proc_create_single("vmallocinfo", 0400, NULL, vmalloc_info_show); > > > return 0; > > > } > > > module_init(proc_vmalloc_init); > > > -- > > LGTM: > > > > Reviewed-by: "Uladzislau Rezki (Sony)" > > > > Thank you! > > > Also one thing i have just noticed. The "Fixes tag" should be updated to > this: Fixes: 8e1d743f2c26 ("mm: vmalloc: support multiple nodes in vmallocinfo") > > the below one should not be blamed: > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > > Thanks! > > -- > Uladzislau Rezki I've been looking through the stable tree and it seems like this issue still exists in the stable tree, so I think this patch needs to be backported. What do you think? Regards, Jeongjun Park