From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7288AC3ABC0 for ; Thu, 8 May 2025 16:26:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E4516B0098; Thu, 8 May 2025 12:26:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1C7466B0099; Thu, 8 May 2025 12:26:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 089B46B009A; Thu, 8 May 2025 12:26:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DBEFA6B0098 for ; Thu, 8 May 2025 12:26:24 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6C565C0A44 for ; Thu, 8 May 2025 16:26:26 +0000 (UTC) X-FDA: 83420268372.30.65ACFB2 Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by imf13.hostedemail.com (Postfix) with ESMTP id 96BC420006 for ; Thu, 8 May 2025 16:26:24 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ttktk7th; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of aha310510@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=aha310510@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1746721584; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Ck8MhtIBXjdzy4GpZyx41rmV478wkvBcm54CEX5/g+I=; b=S0PA+BEAT32aXGKDw1dD4oQraHRWkd9y3Egn9RAAzv5FCGqsrAqsa6dW9HNRXdVfDg+XRX KUGmAp026YaDVb+95+S1M//8GyP1AfUkUNVfPPCWh7tPuofapgu1Yu+sWQ8qj3z8d39U10 yGU0ZdJlpZmLxDQiYCMB82wwFDqTQ38= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1746721584; a=rsa-sha256; cv=none; b=cwQxDzdRMvvSNqJWmwKQ30WUlz+J7XrCqiC663fXYksQb3Z+7DG29aSbIJVA1Oqspaz2B2 8A46QevSq4Cis5gzC3zivLp6Tv26mj9tDEh2G1lCKpzwzqBb5fz0eb2A46zkHoNdfM+ACW wi64wY/Po1WwtU4P5vU0WD2/AKGcjIk= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Ttktk7th; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf13.hostedemail.com: domain of aha310510@gmail.com designates 209.85.215.176 as permitted sender) smtp.mailfrom=aha310510@gmail.com Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-b07d607dc83so942297a12.1 for ; Thu, 08 May 2025 09:26:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1746721583; x=1747326383; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Ck8MhtIBXjdzy4GpZyx41rmV478wkvBcm54CEX5/g+I=; b=Ttktk7thWK06Shwn3+9yQwjT+WU+q2ukA+UN1Z0g8zlvsGAd5YRf+OCWtW3pOuLzM9 nRi/7T8y1oaRkpez6koFRLbEHGpqeyCZEfvKWRdxQUKHVeDJ0LA4TNfeo9W9+3GyzuWY hThTpOR+Ol9kuahbdWFWGG2o5XKrouMTsYT7dBiPllOdtDezN5QefDAqT4/UEP7h1Am5 /xJ+SxsP5+03oMa2xguNCQO8Arl8zyIOR/GX3GUw5SYXQif2d4x5XoEHO1s9lrajkzIj XoCih5xT3HWEhw+MBosM+5qgmYT9YukpNeFYTGZMIMARgw7nZFNDYJvYbOAM8CcPV0Ly q80w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1746721583; x=1747326383; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ck8MhtIBXjdzy4GpZyx41rmV478wkvBcm54CEX5/g+I=; b=UOcKAYTTCm8NUmwSixWXNG5GveVQnq//frj3zbmBqIfQnh3v7ODqsEXSNxcsu4PcmT TfR37t2wZ2V+5VH2tnUE3JV0Hm4QvGeTvcMLo5qZUdmTX61e+C/Oz554R/31Q4Vs3R4t YGNbeseIXH4hWWDlzKmDlTgE3Cs+dk84AiGL3WrxqoYnrakxFdVS19Hc36ClMJh/h3vk t1A9xhPnXl/H6hXUPLb5gEw2dZyP98MszV0sPrZQhQrEzsHx1ybGXSwmB4EKpnaS1kia XZ1x4tMtw4lROxXQBiSt0TVrVy1L1UJJY19baUTqKVXUHrkl1rA59Wwl1RneM3eQi5u6 iang== X-Forwarded-Encrypted: i=1; AJvYcCWWeBZpwOqOmxkNT2uDE3SKzgdIJn0g2dMaB8D47KMTJIbQOny25cuymNcSR4pF0TSPuEibBAZGWA==@kvack.org X-Gm-Message-State: AOJu0YxNY4st2Sbaoe487uTXvLRe5QM60K8fyLDnLPO/KBslWqsdrjxX 99lL++EiSsA1Zc4PEKVaPv8ycehduIp484FXusCQ+niXZmSjuLlF49uIvuxboowDxAJFFe8S2IU jaCFoPlvY1A47m38fnGacc0/Eud8= X-Gm-Gg: ASbGnctEY7xmb9ohf3CTbklwR1uIyBC3agchRfZp50VHXeEQl6cLOyr8T/8pKRwpaPS 56cQiBIowAbNDsFChEirMr4pUNYonFEWFBhsgmgl/Hs/kU5VPVml2s9eSPx26Er26prDDTixF7o 23U12qa2o9XDGSwMO6qLm3kzgb X-Google-Smtp-Source: AGHT+IHJSF64WcaamytQnP3dC6GwgbxGwn2M5VCuGw3Gg4I7VhI+u1ulQIjvXdKjF8rEka1c3Q5Dshy9E6oEW1MxcLk= X-Received: by 2002:a17:90b:3882:b0:2fe:80cb:ac05 with SMTP id 98e67ed59e1d1-30c3cefe5b5mr200351a91.9.1746721583289; Thu, 08 May 2025 09:26:23 -0700 (PDT) MIME-Version: 1.0 References: <20250508160800.12540-1-aha310510@gmail.com> In-Reply-To: From: Jeongjun Park Date: Fri, 9 May 2025 01:26:14 +0900 X-Gm-Features: ATxdqUHXGzNWpD4D8egncUm3vSMNi0tDslCh7EunS9i3px-Qdg7K-yBkt3ce22E Message-ID: Subject: Re: [PATCH v5] mm/vmalloc: fix data race in show_numa_info() To: Uladzislau Rezki Cc: akpm@linux-foundation.org, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 96BC420006 X-Rspam-User: X-Stat-Signature: 1qad8omfuu44g3h4akgtnje7x5d74t7p X-HE-Tag: 1746721584-40102 X-HE-Meta: U2FsdGVkX1+i2wH0Br8xlzFQ4CBNi+14mkCPUzjo4XhWYfOReY40iA5SL6wbz7TI6axkEgwGIhqXM3AtXx8XHDB1iVHr6VKigpQpwNrQN97cMhD5W2otcBO3D581k5Md0QgkRVCqPGCSbHyuSNcve+yc1nhkOoW3Vt0c/n7+ikWQMaV1hcHhY4SNRcdI/3jtSB4G9pwjmAEZ1AZCP5Vu4bnv79B6DZVwO6w0Hjd46icIA3K9X392Uk8j1INlc7vYA5qUbxvbGT9coBPqqVJuxG9iUwkIwTYazTTlncrPgF4r8vRlVlqp8KV5i5pZbZQjkjzGFbla2vAR7Ym9KPtegh2ckZXEjfDkmlZX5YK9nUQ9WRzP4hJJqmok/jLdmDU34NRS0PK/iddt7Os/YslNYNzwUEp+cR+pRc7E74wahonslb4gpZavlpRW6Fe8u5DjOAHYW28i3JJ527RdgkSfPbZyn0y/lDX4R7YdYCffoVbXrBY/T+IxG3i7juw1wRELOaAlbb8k+LzJ3wUdekiLRmSFvHRbA57InVGyLI/DCYxk7EGWHb7qbfmwjjKtzNioyofMRLh1IN5HWitwuXEk4jkAYIMQDN8oWxAVaDx4CIeAfOPUxTaDv1y9uEM4esEBTiZq0o6dBl2UxlyLjtsAkI74x9QnuuQblQtfv/wsvb1vU4J2a0214VWQoeoFvspMsLTaelDgUhw6TmH1q3+VYdtUU5LPiCnM1QOyWrgAE84iCGElanvoG+8zHFaHbbKeBoSTF4GTvcyqMUQBUS9GyFuUqrY1NnnED2hkpmhn85zwelWh+YPgzm6MH+ARoMO94yyrUp8vdKMa0aELkiO3IEFJWxFjK0YLPQOObZCYeFgrPaQjN/XU0I5RLFxzCucOJUx91mEpqwkuBQU42l/AIAOhXUA4uabJYm1FI0mMClQVAtoX+wLjAE3/EJ5D5ltdwa+g7LlF6pe6VDucYVD fR9c2OLu ReUi2jf/45NGwtKckNmmwfKAUIJaQQondP9xGY20wgX4gY4E/XVGvYdKd6jiLZpmQbkrADxnLA6TCVpsi6gb/XWbAiEYSQcuKQZE/V9YwrglYBau5LHdcXt6diMQy+EAfnhmz8jzqVDWOqAkJUwApbtmrEgi/IeTqO5s1kAnbaJg8oUHySlV4Gc5GV/5QY5j6fLlzK7AKfsbXaYQ+7ZN9/C+egeThNxI8jtZIA5UzlaRdhnz4YHwOR10gYJpGovYh6BUnrh3RVm2GgrnYztelRTLkRSJBjfeZDpa21wkeA/GLUCfnKCmg1tZvN5TdPipWTPU4tW9hnlstqHSJSqKX4v6RZBEAHq66lKHRUtqaL9LYgc+L4goKWgI0zaFzIn+hGMPXDba7aXkDiwHZOtYP1zRbwyA7enirtTbCXYlv4prhHoKo1xbMMvp57jzq4bvIq3GCucXqJoc8rvrL3RioCs5GoRPqUjArX/6nwWKB4FeHmEQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Uladzislau Rezki wrote: > > On Fri, May 09, 2025 at 01:07:59AM +0900, Jeongjun Park wrote: > > The following data-race was found in show_numa_info(): > > > > ================================================================== > > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > > show_numa_info mm/vmalloc.c:4936 [inline] > > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > .... > > > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > > show_numa_info mm/vmalloc.c:4934 [inline] > > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > .... > > > > value changed: 0x0000008f -> 0x00000000 > > ================================================================== > > > > According to this report,there is a read/write data-race because m->private > > is accessible to multiple CPUs. To fix this, instead of allocating the heap > > in proc_vmalloc_init() and passing the heap address to m->private, > > vmalloc_info_show() should allocate the heap. > > > > Fixes: a47a126ad5ea ("vmallocinfo: add NUMA information") > > Suggested-by: Eric Dumazet > > Suggested-by: Uladzislau Rezki (Sony) > > Suggested-by: Andrew Morton > > Signed-off-by: Jeongjun Park > > --- > > v5: Change heap to be allocated only when CONFIG_NUMA is enabled > > - Link to v4: https://lore.kernel.org/all/20250508065558.149091-1-aha310510@gmail.com/ > > v4: Change the way counters array heap is allocated, per Andrew Morton's suggestion. > > And fix it to call smp_rmb() in the correct location. > > - Link to v3: https://lore.kernel.org/all/20250507142552.9446-1-aha310510@gmail.com/ > > v3: Following Uladzislau Rezki's suggestion, we check v->flags beforehand > > to avoid printing uninitialized members of vm_struct. > > - Link to v2: https://lore.kernel.org/all/20250506082520.84153-1-aha310510@gmail.com/ > > v2: Refactoring some functions and fix patch as per Eric Dumazet suggestion > > - Link to v1: https://lore.kernel.org/all/20250505171948.24410-1-aha310510@gmail.com/ > > --- > > mm/vmalloc.c | 62 ++++++++++++++++++++++++++++------------------------ > > 1 file changed, 34 insertions(+), 28 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 3ed720a787ec..866f18766dfc 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3100,7 +3100,7 @@ static void clear_vm_uninitialized_flag(struct vm_struct *vm) > > /* > > * Before removing VM_UNINITIALIZED, > > * we should make sure that vm has proper values. > > - * Pair with smp_rmb() in show_numa_info(). > > + * Pair with smp_rmb() in vread_iter() and vmalloc_info_show(). > > */ > > smp_wmb(); > > vm->flags &= ~VM_UNINITIALIZED; > > @@ -4914,28 +4914,29 @@ bool vmalloc_dump_obj(void *object) > > #endif > > > > #ifdef CONFIG_PROC_FS > > -static void show_numa_info(struct seq_file *m, struct vm_struct *v) > > -{ > > - if (IS_ENABLED(CONFIG_NUMA)) { > > - unsigned int nr, *counters = m->private; > > - unsigned int step = 1U << vm_area_page_order(v); > > > > - if (!counters) > > - return; > > +/* > > + * Print number of pages allocated on each memory node. > > + * > > + * This function can only be called if CONFIG_NUMA is enabled > > + * and VM_UNINITIALIZED bit in v->flags is disabled. > > + */ > > +static void show_numa_info(struct seq_file *m, struct vm_struct *v, > > + unsigned int *counters) > > +{ > > + unsigned int nr; > > + unsigned int step = 1U << vm_area_page_order(v); > > > > - if (v->flags & VM_UNINITIALIZED) > > - return; > > - /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > - smp_rmb(); > > + if (!counters) > > + return; > > > > - memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > + memset(counters, 0, nr_node_ids * sizeof(unsigned int)); > > > > - for (nr = 0; nr < v->nr_pages; nr += step) > > - counters[page_to_nid(v->pages[nr])] += step; > > - for_each_node_state(nr, N_HIGH_MEMORY) > > - if (counters[nr]) > > - seq_printf(m, " N%u=%u", nr, counters[nr]); > > - } > > + for (nr = 0; nr < v->nr_pages; nr += step) > > + counters[page_to_nid(v->pages[nr])] += step; > > + for_each_node_state(nr, N_HIGH_MEMORY) > > + if (counters[nr]) > > + seq_printf(m, " N%u=%u", nr, counters[nr]); > > } > > > > static void show_purge_info(struct seq_file *m) > > @@ -4962,8 +4963,12 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > struct vmap_node *vn; > > struct vmap_area *va; > > struct vm_struct *v; > > + unsigned int *counters = NULL; > > int i; > > > > + if (IS_ENABLED(CONFIG_NUMA)) > > + counters = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > > + > > for (i = 0; i < nr_vmap_nodes; i++) { > > vn = &vmap_nodes[i]; > > > > @@ -4979,6 +4984,11 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > } > > > > v = va->vm; > > + if (v->flags & VM_UNINITIALIZED) > > + continue; > > + > > + /* Pair with smp_wmb() in clear_vm_uninitialized_flag() */ > > + smp_rmb(); > > > > seq_printf(m, "0x%pK-0x%pK %7ld", > > v->addr, v->addr + v->size, v->size); > > @@ -5013,7 +5023,9 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > if (is_vmalloc_addr(v->pages)) > > seq_puts(m, " vpages"); > > > > - show_numa_info(m, v); > > + if (counters) > > + show_numa_info(m, v, counters); > > + > Let's execute it for NUMA only. > > > seq_putc(m, '\n'); > > } > > spin_unlock(&vn->busy.lock); > > @@ -5023,19 +5035,13 @@ static int vmalloc_info_show(struct seq_file *m, void *p) > > * As a final step, dump "unpurged" areas. > > */ > > show_purge_info(m); > > + kfree(counters); > Let's execute it for NUMA only. > > > return 0; > > } > > > > static int __init proc_vmalloc_init(void) > > { > > - void *priv_data = NULL; > > - > > - if (IS_ENABLED(CONFIG_NUMA)) > > - priv_data = kmalloc(nr_node_ids * sizeof(unsigned int), GFP_KERNEL); > > - > > - proc_create_single_data("vmallocinfo", > > - 0400, NULL, vmalloc_info_show, priv_data); > > - > > + proc_create_single("vmallocinfo", 0400, NULL, vmalloc_info_show); > > return 0; > > } > > module_init(proc_vmalloc_init); > > -- > > You are so fast :) > oops sorry. I'm not sure why you'd want to avoid initializing "counters pointer" to NULL, but it's a simple change so I'll write a patch for it right away and send it out as a v6 patch. Regards, Jeongjun Park > -- > Uladzislau Rezki