From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F51FC83030 for ; Thu, 3 Jul 2025 12:49:30 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8F7D6B0184; Thu, 3 Jul 2025 08:49:29 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C19626B0185; Thu, 3 Jul 2025 08:49:29 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE1376B0186; Thu, 3 Jul 2025 08:49:29 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9769C6B0184 for ; Thu, 3 Jul 2025 08:49:29 -0400 (EDT) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 261DEC0197 for ; Thu, 3 Jul 2025 12:49:29 +0000 (UTC) X-FDA: 83622934458.01.27188D8 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf18.hostedemail.com (Postfix) with ESMTP id 4A2351C0011 for ; Thu, 3 Jul 2025 12:49:27 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JjFNKdwc; spf=pass (imf18.hostedemail.com: domain of aha310510@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=aha310510@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751546967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=6LiFOh64v/siwXdil08hktvYo8/cVuoCtLxNd2EEmBc=; b=xjosgx5NmSj2ikYfsmjKvEaZ6Fe0+HNw6tPVr5h/vsOMyweuwOa4mz+KaM9p/xnBAs9qjG HpYUuFTpqaySIyEsdozYLcIAPva2AIhfy2etmmXQ0FSyWf+a4S0izuvizM5SkokXYbpr+J nMwd9oqUZgsdeKrKGpGfozCUjYtQbKM= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=JjFNKdwc; spf=pass (imf18.hostedemail.com: domain of aha310510@gmail.com designates 209.85.214.175 as permitted sender) smtp.mailfrom=aha310510@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751546967; a=rsa-sha256; cv=none; b=V5f11HWSVDNyn8gfp3xtOKHg84Q5+TAACVJZ14qua+VvxYF6CowNO8sj6Eq0/qYSC9rwCd 2nfYeIoMFABQ1ad8JmrhXyIyYntbVrLDeICc4x0SRRjXyxawwqwrQkTQjelxbmw5Qks4Gn xt9GfqO3I1eNKhEth7KUbcHooUMrWD4= Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-2353a2bc210so52673235ad.2 for ; Thu, 03 Jul 2025 05:49:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751546966; x=1752151766; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6LiFOh64v/siwXdil08hktvYo8/cVuoCtLxNd2EEmBc=; b=JjFNKdwcnDL4l5FH17lIG88y9YiTyJZBw4eehvIvd35gAbTgV93rrcP2HKYmtEu+HT lCS1hstvKcEwJ6xZYlrJDsihAVfxiton9RjTdFcLfccsB1nvB250z+iry85zVeY44SsY prCFBpmFW/RgYhfu2E4LULBXmHwhs+zYQiKwuGBCEl/q7zR1QPk6EQ29CFW7+z982QiD CYJzBesmgyYrbbR8r6LAHwe6IGQ/kgURaovArqx1s8UU9g82teKxqgdcHpVdkcvv9hep 30Zh0ybff0A0oeLdXg2oiEXMoBivufU53DJngPZNwIkyDjEht23ivCZlXcX+y6bV2Zik 1pdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751546966; x=1752151766; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6LiFOh64v/siwXdil08hktvYo8/cVuoCtLxNd2EEmBc=; b=CqOIA21LZ8JWmmohgY5o5020hobzkXfMcv+uoBaeBUg9qAZDY4+3mLhHUPyUyeFkfB ljEeR7+U+R5i6BLffslXPLehAryQciYt5qedUMY9IwpIj9Z6QJmy2OwZccBi+dP+DxDS 52pBFxiKR1UXIMWcg8tXGGzHN/nepGBB1N02Gb2NWSu42tBGl2Q4wJ9fDQ78tDAQVHCV Nrec9AOdx9iChfpj3yUWBzPrtb+5MB0szwk3OCsXU0vipxVJA+yBZgYIzJvBbdfdDJEr TC+RcfY9ko9Gznj9JntFybu2xRCWEi9Y/oCcoIepixpX8yeUZPYIrJ9N+Z09AxEPz62j qcow== X-Forwarded-Encrypted: i=1; AJvYcCXe4mfpeeEZqvg7vRXopEBXptVINpvv4kzonOZYIErbL3mlQ8Vh+2zSZJURQe9kyxev0v+qW6Mngw==@kvack.org X-Gm-Message-State: AOJu0Yyd3B5O5y07XwvwWvQteF1fpJjvIuzxXjpCYDLer+ASgwDoDjyl zXvM9p9F+fIh1GMcOF5S2sDT4huiXHQuSoBMPiguuj2GA16q94n1Nmx50QuxFndSg2J4V7SW1K1 DnJULAwqaPfb5XuTl6/4Dqo5D87Mzixw= X-Gm-Gg: ASbGncuD73/Pk4XUmVUdJLxGklTj7nokLTTtYVvQ47oD4tmQj+mlpql9svINgMjqV9F Wgz5DQhLTzPv8Tb6Z2xWWEpIM5w7Haj56/nIffmInrbHwymsIMIdV0TWEkp5ZOoMV/SMP/brTGV 7AZx/k0fhmiNkmLQuUdYtr3oNdvgh59Nu6RBJApTHTUR76pjYV60XBYYVS X-Google-Smtp-Source: AGHT+IH48/BERJnuPtZYQjLpcSnA8IMxSKCWbJND9Uz0Hh0HUl6pAtP7F+1crfYQJpC40rwlfFoBgshJvPClIiy9Goo= X-Received: by 2002:a17:90b:3cc5:b0:311:c939:c851 with SMTP id 98e67ed59e1d1-31a9d52bcbcmr4116449a91.4.1751546965945; Thu, 03 Jul 2025 05:49:25 -0700 (PDT) MIME-Version: 1.0 References: <20250702153312.351080-1-aha310510@gmail.com> <2025070322-front-purchase-b66f@gregkh> In-Reply-To: <2025070322-front-purchase-b66f@gregkh> From: Jeongjun Park Date: Thu, 3 Jul 2025 21:49:19 +0900 X-Gm-Features: Ac12FXycYs6l1_4Q6i9Y6NhpTZ-YgwI7DO1P07o9n57x9nl5UTWxk6QJqmx-x3Q Message-ID: Subject: Re: [PATCH 6.15.y] mm/vmalloc: fix data race in show_numa_info() To: Greg KH Cc: stable@vger.kernel.org, urezki@gmail.com, akpm@linux-foundation.org, edumazet@google.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: bgzidbk4k8ds5swibiqxegy49pkwhu41 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: 4A2351C0011 X-Rspam-User: X-HE-Tag: 1751546967-927288 X-HE-Meta: U2FsdGVkX18gquUPhFXxpmHGvJ7qFxP/8I32B/JhySrcUq2kzrnmPtIIuDqqt9ojE5f/OwCllP7tnCIn4vzzXbByy767HHB58y895XT/vj+xo66Q/hDCe1BB2JiBe5Xn64ynuut9/oTH8RUULPUri9iieu3qt/myC0dwQ314/8ea1jb+yjNzUz05bcvlKGM8viV4PWC/CyuPLITfWuIjfUT9T15Ry2tmuStdslqZsU0njehxsooo237akoj4oF+FjLuFdkV9Q7EWuWT6UApK2qjDHEMTsvU+T891g1GhwlgYpyWNIIA5f4twgAYcV/2+h7kg63F23IPAUXFRqCjEFntgCfL2d42R01f3qv04Uz7rsuBuDQCFm1u43UzLGXxXGkPfU5abYuV0lD7LWARop0X9aDgSRMYnARj1XSuU1UPYsmVSXCBJrgCff31H4qA06QsmyvoAbM66LfTKHC0n3M6J/CvQF0P8xeTUJTaGp3gsuZDB0Qc1tyXO01I7XDZrP5lBvObNjstfGUAXHXvsPNUkrmsf2fIYX52PgZxI9XXWZe8vThYEu2+jWdd9SS2KzjYDFVQT1OTiYPGWNXMlS91nyih09gzjW1tboxfG7i2MX+GfkgWqD/rJHdiT1v0bQNqpPOEpueh0s7/DNmf9xcL9nuOU71M1VNYx0xYMUTNkEOaNoXGWZZUG0flGyGgM1S/29aQfa1Gfl8WXtauUTOK9+9pnd1+xd3xnde2VJa8n4fiwVq2UPrLmxSf4iBhpzlS99SPRmlWnXisEVd3nQp/DquQb7tkVCwAA6PyYsavtuSw8PKKQ2yLqc5t4wvbPEQjoRp9QIYT0b+69Bu2ft6fyQsOtrY9zwy02voCBG3EEFqFN5Yh7OznAGSAwK07NvoIqXPHtzqZRuCF5W+GNIiEBV9q0GB3Ri2Sg9MZGmFeOzb7bByxuY8iOylgcPEIN23Xlv7XPfOHqLeEy8XT od48h0mu b6DTYljkRtBRIQ/zq/EgmbmOykh84ngS2s0DbPxn0FJsiQ0geiGXzV77qSmDL4FkEqBCroB/F3ykS0Dr8d+nP/E5UQ8a2tUAtUiqiK7e7zieRccz8MhBVo1Qwn337vDlEpTjtOpY6yjtDne/4tzc8E7Bd1bAMl5eD71rBN6WNC/MLvykfnQuVidisWlxAD1HWYfJY2sicieJe6j0ELjDTBYf+5mCHJDsr8Awlmnx5vh8i/Y21KWp1ONHxBe7sSVSRD0fdX1w4tE5IEYr2VWdYY0sL5ZEFAwlWEaAHPsaB7Qi7V7dHIhZ+jcI83UE9QTa7Fs8h7XeJt36UD54qYNb62WeRMC+tBXk2sZ/q6XU8F/u8l8IZjqsYGJ70SWioCQFyWadbBU0xNlm1qoaHWZr6Jd1aAIEW/TAfPC7qjWVzggqD3sftuR7sQUs01uNtd2Dro5E/BCXvo21ZQc5J4TIgB4ebjeqyJ+Knu8YP00oO2jz3s+tVjUs3SpOqOYZWjc/H8eH0fJvbEaxOOxEY5fTAwgy80VJqPNmRcE81ciWIQbB5AVI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Greg KH wrote: > > On Thu, Jul 03, 2025 at 12:33:12AM +0900, Jeongjun Park wrote: > > commit 5c5f0468d172ddec2e333d738d2a1f85402cf0bc upstream. > > > > The following data-race was found in show_numa_info(): > > > > ================================================================== > > BUG: KCSAN: data-race in vmalloc_info_show / vmalloc_info_show > > > > read to 0xffff88800971fe30 of 4 bytes by task 8289 on cpu 0: > > show_numa_info mm/vmalloc.c:4936 [inline] > > vmalloc_info_show+0x5a8/0x7e0 mm/vmalloc.c:5016 > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > .... > > > > write to 0xffff88800971fe30 of 4 bytes by task 8287 on cpu 1: > > show_numa_info mm/vmalloc.c:4934 [inline] > > vmalloc_info_show+0x38f/0x7e0 mm/vmalloc.c:5016 > > seq_read_iter+0x373/0xb40 fs/seq_file.c:230 > > proc_reg_read_iter+0x11e/0x170 fs/proc/inode.c:299 > > .... > > > > value changed: 0x0000008f -> 0x00000000 > > ================================================================== > > > > According to this report,there is a read/write data-race because > > m->private is accessible to multiple CPUs. To fix this, instead of > > allocating the heap in proc_vmalloc_init() and passing the heap address to > > m->private, vmalloc_info_show() should allocate the heap. > > > > Link: https://lkml.kernel.org/r/20250508165620.15321-1-aha310510@gmail.com > > Fixes: 8e1d743 ("mm: vmalloc: support multiple nodes in vmallocinfo") > > Why did you change this line? Oops, I accidentally imported the commit message from GitHub, so this commit hash was shortened to 7 digits. I'll fix it right away and send v2 patch. > > > Signed-off-by: Jeongjun Park > > Suggested-by: Eric Dumazet > > Suggested-by: Andrew Morton > > Reviewed-by: "Uladzislau Rezki (Sony)" > > Signed-off-by: Andrew Morton > > --- > > mm/vmalloc.c | 63 +++++++++++++++++++++++++++++----------------------- > > 1 file changed, 35 insertions(+), 28 deletions(-) > > Please document what you changed from the original version, as this does > not match what is in Linus's tree. > > thanks, > > greg k-h Regards, Jeongjun Park