From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6C796D69104 for ; Thu, 28 Nov 2024 12:29:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02BAE6B0083; Thu, 28 Nov 2024 07:29:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF66C6B0089; Thu, 28 Nov 2024 07:29:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D49176B008C; Thu, 28 Nov 2024 07:29:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id B51776B0083 for ; Thu, 28 Nov 2024 07:29:17 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 6C7F2121538 for ; Thu, 28 Nov 2024 12:29:17 +0000 (UTC) X-FDA: 82835433786.05.F903BEB Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf18.hostedemail.com (Postfix) with ESMTP id 053BC1C0006 for ; Thu, 28 Nov 2024 12:29:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NF86R7YP; spf=pass (imf18.hostedemail.com: domain of amarkuze@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=amarkuze@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732796952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0Nxf6CkGK3NslY+JLgqPcTLt32q1OCumzkrHYUKQkbE=; b=Kd+/qnJIj12iEV3kDD2kF9hGlmEi5+A5rLddgxbHzcQ1Mc8nN5FreUMikC4lzo+V6Aa/S3 cXvzRDkRXbgI+EV5+OpxvLtez99IvVPABfBVlWZZRHkkZEWxskWgvIDgvfH8zYigyRs4G0 jtDCaVa0x/4CWJlDKgc2Gt1IOiD5tXY= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=NF86R7YP; spf=pass (imf18.hostedemail.com: domain of amarkuze@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=amarkuze@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732796952; a=rsa-sha256; cv=none; b=KsaFd7k9JvCOHO3BBlOojZ3JmeKLFRKHLpyuOd/ITPH7nq/1jtYOpqvoTotYyKggEHvFbp 8bAbpnwWyAdVs4j8AdE3Pr2+k8CXQ1d/D59GWh2JXCFg8bc0bSOvRrZtIAc3sRu5yJK6XO Jaebyr68THzhb1bPHvsbBL4cswF9qB8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732796954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0Nxf6CkGK3NslY+JLgqPcTLt32q1OCumzkrHYUKQkbE=; b=NF86R7YPaO4OmYapdN/YmkctK36hyatOwgFnMmypDgOYs+5hDSzw9VI6kPrX1Sfwh9Y/oh pkRUEbh4+BmMaTxCAagWRlwi7lwQxDFd7HAWNdry//JprUXWVkYB37Tpxs4gq9uxDC5E3q Hb7mXLh0aj/aMRbdo2tBNwPWG0P55Bs= Received: from mail-ed1-f69.google.com (mail-ed1-f69.google.com [209.85.208.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-633-dosa4CqnNtCckCUHhhEY5A-1; Thu, 28 Nov 2024 07:29:13 -0500 X-MC-Unique: dosa4CqnNtCckCUHhhEY5A-1 X-Mimecast-MFC-AGG-ID: dosa4CqnNtCckCUHhhEY5A Received: by mail-ed1-f69.google.com with SMTP id 4fb4d7f45d1cf-5cfbec85442so510282a12.1 for ; Thu, 28 Nov 2024 04:29:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732796952; x=1733401752; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0Nxf6CkGK3NslY+JLgqPcTLt32q1OCumzkrHYUKQkbE=; b=enFIaYHGOrLEll6HsAR2sRI/76sjJax9c0IPsTMCjD/RFbyhveBtiJLPnafopMXnIP pqEJM+/N7NJuiXiA+EA+0NuBWUfUpCke86oIuvdzezfL496eGm9dt1eKO1lswBdQv7/v RslNuDmRWcWQpplJj0Jqa2+0MhrmV1oyKw88PD6xs1pdnqcsVafqJC45/0n13V58T3ed sDmGUQ+O03QnG+VFc1A3a5HLvy/7yHBeFpLp8lFlhAxgb153hYO+gdy2xKxh1uMbeeX9 Gp5J+tJHZ/twls1Od5oHFCUWuQG1Z23r/Y4olCjdKokHxvhCBdw1vON6ZBWIf1OHG7s+ de1w== X-Forwarded-Encrypted: i=1; AJvYcCXKkFsuTDw76y8ChDzNhy1U+lvN71FiHcNOgzQtq6rR9bSBP6euNLBLYKtZkwWOicXhAyDLQbu28A==@kvack.org X-Gm-Message-State: AOJu0YwP2Ts8ZDIBPOKPgfJTmHbcDXUNwvkr//7y9DW7visPFXCQkhyb +2oGwis6DRLQa36sjMvb3ArX2rlFRqEuV3N2GSUifKNFAvk90RN8QlzoOcSO5IKjUD6AE3y2r9G /8/zbtJU831ILd4cafiUrxckOOQtRX+M320KtkjVmM0HdyKheuCePKFUWjryfqNN1TzRNYD2X8O a5iFEn2lLcJmAS2VtxDTdEGIY= X-Gm-Gg: ASbGncuw/9FLcbzg16WkGS/mTvS/scWUF2zKM3Upg+BLZrwHjlUkNA/C8mHgGPDhypw UCdU14qpVdTyb6vfqKloWOObx1tpiDCQ= X-Received: by 2002:a05:6402:5243:b0:5cf:e26b:9797 with SMTP id 4fb4d7f45d1cf-5d080c604fcmr5605096a12.29.1732796951924; Thu, 28 Nov 2024 04:29:11 -0800 (PST) X-Google-Smtp-Source: AGHT+IGuE0zkJ6zJza+fGet7qX+06h7Jmet7/bu0xRwgqC9A06SMAgod8PaoQJd1k5pY7KRDfw0cJAGqmNIglvOyUZo= X-Received: by 2002:a05:6402:5243:b0:5cf:e26b:9797 with SMTP id 4fb4d7f45d1cf-5d080c604fcmr5605060a12.29.1732796951475; Thu, 28 Nov 2024 04:29:11 -0800 (PST) MIME-Version: 1.0 References: <20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v1-18-19aadc34941b@linux.microsoft.com> In-Reply-To: <20241115-converge-secs-to-jiffies-v1-18-19aadc34941b@linux.microsoft.com> From: Alex Markuze Date: Thu, 28 Nov 2024 14:29:00 +0200 Message-ID: Subject: Re: [PATCH 18/22] ceph: Convert timeouts to secs_to_jiffies() To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: Wlbl2QnAx85CrQmKXuMgyAFWHKi9PnV5WmxNVdefxZ4_1732796952 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 053BC1C0006 X-Stat-Signature: cz1zy9ybwxwf7q85kc86c9f3rcpsg3c7 X-Rspam-User: X-Rspamd-Server: rspam11 X-HE-Tag: 1732796951-807333 X-HE-Meta: U2FsdGVkX18l2ldjbf3L9hsQBW9CcctQ0HndLnxQFfG062OKedAiiZ3n4G5QNmywLL6W3nA/epbX8T16GAjUmNYVZU8rp4Y45P7gWDVIQJVWKEOYlmDcPBLmSxk5M7XRxeBuaNSaVPsqqeeTvmWblq922SgtzTR6ltZGwhGLVq6jAVni+71ONL9sqSA7J0eBiBUHMoWpKn78ErMUYqrk7ONL1TFUyciF/mEBauJ1qVgirOjdaE8dHylmiQCNuLi7hZsRFF4T2fsX+pwCRFJ1XT43YPBn1rRiKc2aBF3gQcrBa2E8tmTh4Of9JRZzJax9IS5v6XgIuldbBM13oeDCm05weKk9vNQA9j9OIRHMS3Pvw3h3YkGxaH3jOb6BIVyb+aZxhg21Ef0rtr2zXmm3G1D4whs17szDwSKTkNhdllwyX30JY59ZaIRNSpdHupmYZvuXoCJdhwJH8RK5w5UCCrQJX8VyOaR/JRCcAwob5nLmU/K59/o7RvjUFTG9Ybh80hyyiVbPXjBIFBCDPpKb8kfR55L0lU62ybLRnScFatv1YUnS1CGty2i8gheHYqz6FwNXj+ee1WmEPWLLC1wT4dpEZkuLlluGA5m208NWYO5EdrYU81RDRfNstvdaMDOBjUwdWTlzzaLDy2x6QhFBUcCNQ1ovZKkoUDyxfhsdK4Lds6CMnolXj9GH8Csz3kiNlNHUdX8nyda7vaBxHFjjHWXU7210B0BsLDIaenZ8E5Ru2Lm3aRc8WqHoh/MI0gATBKUX/VJNLJdqx/XPGFPToXPZePmbLBR1DqbPqEEMq7pvDLCYIsiuyaYlzF3MPYkpzYefG/pskqoQcDGQq8o6oRRbpe8S9fRG0qzHFMUwLaWqsjrKKlwK5ymwLe7qd/sbapKoCFQj6PbVpIDIT5/x0D/MtHyQYO4ZSxJYf4dh9Q2ehEZD2Qzdmk8TBewOkB1c9V9TZSjvTAQ8bWuORuV TvPVyctt QVRRErhYls3TArFdqmHGaDNYo/xtWFBp5HtuPnlGOhNdRld7SlEneR97/A8FxZn5Whauj4e31V0bPvaFgnqYLL+gOms+KzUT2T6c6q0PGBtmWnoQfvKYbllDm4ji0SLD8HEKFhW1A9dxAYXjg6HyCyU7FVXrwBkpE0xcYAEYyFc8cYh5G6D9BFLk5WsDf6gdC1AWw4Z+bUofIZNqCTHKVJnlrmQDMiPPDUArI6SO5AReQXyyIlaxbBreu1PYiGbZPkswv9z0+oAH4tm7IY2OXR8T85EYnPl8DXcMqGBd4gVdH5/fLbdlSNrVR+GhMAqAkcpHygHINZIVzn/2bKtk6T6Lu7tXCaVOugDNXx86a0ksKCpnzvDjPXWF0Ys9PPASAq1vrw/nX1MLoX8YivIlCEF+1bQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: looks good On Fri, Nov 15, 2024 at 11:35=E2=80=AFPM Easwar Hariharan wrote: > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan > --- > fs/ceph/quota.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c > index 06ee397e0c3a6172592e62dba95cd267cfff0db1..d90eda19bcc4618f98bfed833= c10a6071cf2e2ac 100644 > --- a/fs/ceph/quota.c > +++ b/fs/ceph/quota.c > @@ -166,7 +166,7 @@ static struct inode *lookup_quotarealm_inode(struct c= eph_mds_client *mdsc, > if (IS_ERR(in)) { > doutc(cl, "Can't lookup inode %llx (err: %ld)\n", realm->= ino, > PTR_ERR(in)); > - qri->timeout =3D jiffies + msecs_to_jiffies(60 * 1000); /= * XXX */ > + qri->timeout =3D jiffies + secs_to_jiffies(60); /* XXX */ > } else { > qri->timeout =3D 0; > qri->inode =3D in; > > -- > 2.34.1 > >