From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5CD9D69105 for ; Thu, 28 Nov 2024 12:28:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 274CB6B0088; Thu, 28 Nov 2024 07:28:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1FD506B0089; Thu, 28 Nov 2024 07:28:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 050716B008C; Thu, 28 Nov 2024 07:28:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D876F6B0088 for ; Thu, 28 Nov 2024 07:28:57 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8BF24ADBBB for ; Thu, 28 Nov 2024 12:28:57 +0000 (UTC) X-FDA: 82835432988.04.19509D2 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf08.hostedemail.com (Postfix) with ESMTP id 6D3A2160013 for ; Thu, 28 Nov 2024 12:28:50 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SR+2143n; spf=pass (imf08.hostedemail.com: domain of amarkuze@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=amarkuze@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732796928; a=rsa-sha256; cv=none; b=q/drCUmqez4O3lpu5tPVRKPsyxrp0JFWo8C+VODOzEGEQAsjqkBmPnel7l76VBs70choqJ p1/DAhSjSPwXDCkESnsg/Jph9Pv9NwO2q3LJCGTDqQ4dle80MYe2OHT/MK0dFQBoDFfKmV luND/J/XylhBLuO03akey0X8P+wCr+M= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=SR+2143n; spf=pass (imf08.hostedemail.com: domain of amarkuze@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=amarkuze@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732796928; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZACMslqIaF7iVtmlx12c8LPoSlN7TzLegXngDuX2z78=; b=I+Wnm4ibuMj/rLx0/T3k4ci+EV5OOrxOg8R3IjuyCudofvJvQwGz7D6pAfHfERKpb4MKMN JkRwi5QeAG7J9MwaDUJa3lXk83eEAgYPU/8YaoMpPpfI3C+Ezq7xnyS8AGUCws2xeeQxeN 64gl+Gk14syKDK0tKCD9nYAUh8+3COI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732796934; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZACMslqIaF7iVtmlx12c8LPoSlN7TzLegXngDuX2z78=; b=SR+2143n/ny/c1ljGZjDnEADm/Ip4JnzZKHEGegX2fSpQuWWcE1/kNzNUvhvIvpffUaami pQnV8KfkLGfnmwFF1tW7gB4vxoTu6M1GGF94HZMZeKWCvFMHdHksmJydcDHl7j7pLyw10t usmZaRSuxFMIGWqNTbACv75cFVGLQL0= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-OjeBg4j_NmmCVBjn9IIUFw-1; Thu, 28 Nov 2024 07:28:53 -0500 X-MC-Unique: OjeBg4j_NmmCVBjn9IIUFw-1 X-Mimecast-MFC-AGG-ID: OjeBg4j_NmmCVBjn9IIUFw Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-38242c5b4ffso437459f8f.1 for ; Thu, 28 Nov 2024 04:28:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732796932; x=1733401732; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZACMslqIaF7iVtmlx12c8LPoSlN7TzLegXngDuX2z78=; b=OEG7O+Wl/1S0+xFkXBp0SvqagMs8b5u7wgLp4dQUhOdFxty4AU34U3MTNfSL4FUBnU 73NyKYONMsbZAdiPhHZFA3bQGKNGkFARGfptjgzlglOHniur0VgpQmLKDU5Z/WtGZIov j3/JOGe0hYyuy8v/9yiS5w5PibGWAnKQ4+gEhkVHLRXt293gWdaa7pog8SgWZDPdd7Qb ggo9vVuymaJ8rkZ5Q2rWtYKO6GcZrcARqMlomnNPG3xRxEuIEy9jh/lNwXzdSPV3gCt6 qSfNrFrGbPcljYNa3bGzlCIhj/tpNflMkqKAaC3EF9xOI08mI/EsCEefVe7kpKZqbLpB xXNw== X-Forwarded-Encrypted: i=1; AJvYcCWK6H7h44z2lejh919wPDSrAcx6sBxkTA9V5N0wodxFSXmCNiAyt3hXuhn52WzMpfq5pOrZn2Xldw==@kvack.org X-Gm-Message-State: AOJu0YyCHh7KWLOULQEWjgsb07nCtWK7UGBnqWawgc7we8Kf48z5PF3Y 4kmlzvo+Upm5ypjbUnDBaz/8PERM2IYqUGVwD6kOqqT5hvKp2iXNalZx7i6Bkp4UCMqUth7pbN2 KYMgNr51+2EeOvH0MK239+1KGMPm8gxn1MhzA0W4PIwPj2q+FKlVm7AgCA0ZWO1ZC3iexCWwmZN 23WEbkJMKWCiKe3beImz7sJWA= X-Gm-Gg: ASbGncu28+MZl7s2/X6ySIW/t/T7xIpI7n83nut8ShKbu/IG4GgKQE5/EwgG/2bEW4a np1B7KSkEUs9O+IFAx6s+8w7/bwEN2n0= X-Received: by 2002:a05:6000:18ac:b0:382:4a27:1319 with SMTP id ffacd0b85a97d-385c6eb5840mr5776181f8f.6.1732796932052; Thu, 28 Nov 2024 04:28:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGGOqoP8tsZ6KQpRsoqtGa6KHF61EJ3NUmj3Aw3MlprtODTvHQ/TDY7uTpa3Nw0Vy2Is2RlK3QrcXMwzmVV8rU= X-Received: by 2002:a05:6000:18ac:b0:382:4a27:1319 with SMTP id ffacd0b85a97d-385c6eb5840mr5776067f8f.6.1732796931576; Thu, 28 Nov 2024 04:28:51 -0800 (PST) MIME-Version: 1.0 References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-18-911fb7595e79@linux.microsoft.com> In-Reply-To: <20241115-converge-secs-to-jiffies-v2-18-911fb7595e79@linux.microsoft.com> From: Alex Markuze Date: Thu, 28 Nov 2024 14:28:40 +0200 Message-ID: Subject: Re: [PATCH v2 18/21] ceph: Convert timeouts to secs_to_jiffies() To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , =?UTF-8?Q?Thomas_Hellstr=C3=B6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: isWIS5zWCzCDH3xagolyssBxaHjSlWCFKCmS_9CYAB0_1732796932 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 6D3A2160013 X-Stat-Signature: rzg3m74ztbphcadji6fd37h4jeep8ekm X-Rspam-User: X-Rspamd-Server: rspam09 X-HE-Tag: 1732796930-595498 X-HE-Meta: U2FsdGVkX18GqwolaEaZAh6+cd1In5JAm9BIwZUk9Aa5ZP1H7fWsFYJcldHc4PlzOvVXxx6umDM+ZTOgxomkRhSO0Uet68XeWHtDy1G05WyeYPi7WHvmCBhzlov6ZxN461xhL3lsNqUF8Y1KH3Z+8uLsYvPDuhOxF5Jdi0+e798oafmb1rS5RlS2pRmoMxYD2i1wmqVBs7ChDYl8sx9g8tI+BIBbrr/WjOOKZeAymf37C02tDlf3tGLPMgX7vrxhkA8GOFMHYuFLF61EnCGDWknvbXKbvK8wBoJB4bqeKrrO6jJYsF6PGYkNQEQKnVrEzGUG2rLDgJ08BvgeUshQt+fsRqufmrZz+CzzkkQPlPb1xdjmU4vQ5mjw42JOUt6PgUFpIHHaL7mV9yUVvW0F3487D3Nk19Fb+CoqBdfyVovMEhwcIJwRYREYmvDbYCQ1WtgwcA4Y+d2YQ2dh776/EY4mED1jnX1gNRahCJYRV/0u79ysfmUi8/dwIETnbQYv4MStIMHdtkZPEkRbaYUGOe06eiTRVVaWREWVnNZIWvyIjdIhVRJoOaD0VOt1ASca6WyqtYYU6OjvItI8eJGCusbjcgCgsNHBolqggTNIEW4l7bDgOm/v85VivV9o5RPulQl27YWf7QxnQCyBdJKAWit7C/HEabEJkIGRwxFsyLV3zuN0FLZxNM0gWlWVtmW2O3nsYB3af4+B2/zZFB39qV6jc1mBe0nC0JNZswOiGAoCDqL4IpmdsSPot67TDyC2esytJurgOiAqV6SqQxdnlSZgUHl9hA4Q1BBkRxccq5/cwOC9benXrai9OR2DMW3SkMe5xJ4UrMkrSENC5ssi+yAbcvtbgIfIdDHfUlQH11wghyY7lQ5kf+bd9V0nQRUDcZ1RZuxkK3n3waWfdcROA0Jti5o0D6Y5PKEfeNhLVDr5VkEhJhGP4xobPLZqhE3pRK3urvNKZiWbfPigGbc 3hpc3CJP TSf/OxhxnO2Nk/mIw6SwhnTDUN+uD35P06qv+GL6Tlv881khEQD7J3vxwe0YB12ImJuSJQjow2diYr+ii0C5l2Rc4UewdosF1CkUMVO+xTHKbgngOkRwrlKBWi6qYr0SUZtYSXUjWs+wchZgRoOzEAv7cmt2ENwS8jnJwvq1Je+4rMsmgxRUoK0ZN17UAUAuOi0dwh+r0GhSepv/MTlrCsrPd75QnpoZYJAVW7x6c9r16g1XtQwpk6Wyi9GVRl3Q192Ic2wKAzx6mSL+ETCaDeAhSlg7Tu6V5zag3VuvjU2K84O1Tq7ZfWaUI7FOLla3ZzRv7DrazCQI5yFXETo95v/+pBHwCv6XDqi7CqpJVNTGHvWA77ocanv/yKlA+p9JxI++T3coiYX7qpqK9nmUNR7Bq8Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: looks good On Sat, Nov 16, 2024 at 12:32=E2=80=AFAM Easwar Hariharan wrote: > > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan > --- > fs/ceph/quota.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/ceph/quota.c b/fs/ceph/quota.c > index 06ee397e0c3a6172592e62dba95cd267cfff0db1..d90eda19bcc4618f98bfed833= c10a6071cf2e2ac 100644 > --- a/fs/ceph/quota.c > +++ b/fs/ceph/quota.c > @@ -166,7 +166,7 @@ static struct inode *lookup_quotarealm_inode(struct c= eph_mds_client *mdsc, > if (IS_ERR(in)) { > doutc(cl, "Can't lookup inode %llx (err: %ld)\n", realm->= ino, > PTR_ERR(in)); > - qri->timeout =3D jiffies + msecs_to_jiffies(60 * 1000); /= * XXX */ > + qri->timeout =3D jiffies + secs_to_jiffies(60); /* XXX */ > } else { > qri->timeout =3D 0; > qri->inode =3D in; > > -- > 2.34.1 > >