From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from psmtp.com (na3sys010amx122.postini.com [74.125.245.122]) by kanga.kvack.org (Postfix) with SMTP id 167836B004F for ; Fri, 27 Jan 2012 09:27:34 -0500 (EST) Received: by mail-tul01m020-f173.google.com with SMTP id up16so2286858obb.32 for ; Fri, 27 Jan 2012 06:27:33 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <00de01ccdce1$e7c8a360$b759ea20$%szyprowski@samsung.com> References: <1327568457-27734-1-git-send-email-m.szyprowski@samsung.com> <1327568457-27734-13-git-send-email-m.szyprowski@samsung.com> <00de01ccdce1$e7c8a360$b759ea20$%szyprowski@samsung.com> Date: Fri, 27 Jan 2012 08:27:33 -0600 Message-ID: Subject: Re: [Linaro-mm-sig] [PATCH 12/15] drivers: add Contiguous Memory Allocator From: "Clark, Rob" Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Sender: owner-linux-mm@kvack.org List-ID: To: Marek Szyprowski Cc: Ohad Ben-Cohen , Daniel Walker , Russell King , Arnd Bergmann , Jonathan Corbet , Mel Gorman , Jesse Barker , linux-kernel@vger.kernel.org, Michal Nazarewicz , Dave Hansen , linaro-mm-sig@lists.linaro.org, linux-mm@kvack.org, Kyungmin Park , KAMEZAWA Hiroyuki , Andrew Morton , linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org 2012/1/27 Marek Szyprowski : > Hi Ohad, > > On Friday, January 27, 2012 10:44 AM Ohad Ben-Cohen wrote: > >> With v19, I can't seem to allocate big regions anymore (e.g. 101MiB). >> In particular, this seems to fail: >> >> On Thu, Jan 26, 2012 at 11:00 AM, Marek Szyprowski >> wrote: >> > +static int cma_activate_area(unsigned long base_pfn, unsigned long co= unt) >> > +{ >> > + =A0 =A0 =A0 unsigned long pfn =3D base_pfn; >> > + =A0 =A0 =A0 unsigned i =3D count >> pageblock_order; >> > + =A0 =A0 =A0 struct zone *zone; >> > + >> > + =A0 =A0 =A0 WARN_ON_ONCE(!pfn_valid(pfn)); >> > + =A0 =A0 =A0 zone =3D page_zone(pfn_to_page(pfn)); >> > + >> > + =A0 =A0 =A0 do { >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 unsigned j; >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 base_pfn =3D pfn; >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 for (j =3D pageblock_nr_pages; j; --j, p= fn++) { >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 WARN_ON_ONCE(!pfn_valid(= pfn)); >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 if (page_zone(pfn_to_pag= e(pfn)) !=3D zone) >> > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 return -= EINVAL; >> >> The above WARN_ON_ONCE is triggered, and then the conditional is >> asserted (page_zone() retuns a "Movable" zone, whereas zone is >> "Normal") and the function fails. >> >> This happens to me on OMAP4 with your 3.3-rc1-cma-v19 branch (and a >> bunch of remoteproc/rpmsg patches). >> >> Do big allocations work for you ? > > I've tested it with 256MiB on Exynos4 platform. Could you check if the > problem also appears on 3.2-cma-v19 branch (I've uploaded it a few hours > ago) and 3.2-cma-v18? Both are available on our public repo: > git://git.infradead.org/users/kmpark/linux-samsung/ > > The above code has not been changed since v16, so I'm really surprised > that it causes problems. Maybe the memory configuration or layout has > been changed in 3.3-rc1 for OMAP4? is highmem still an issue? I remember hitting this WARN_ON_ONCE() but went away after I switched to a 2g/2g vm split (which avoids highmem) BR, -R > Best regards > -- > Marek Szyprowski > Samsung Poland R&D Center > > > > > _______________________________________________ > Linaro-mm-sig mailing list > Linaro-mm-sig@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-mm-sig -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org