From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 848A46B002C for ; Mon, 10 Oct 2011 08:02:20 -0400 (EDT) Received: by mail-gy0-f181.google.com with SMTP id 10so6231167gyd.12 for ; Mon, 10 Oct 2011 05:02:17 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: <1317909290-29832-1-git-send-email-m.szyprowski@samsung.com> <201110071827.06366.arnd@arndb.de> Date: Mon, 10 Oct 2011 07:02:17 -0500 Message-ID: Subject: Re: [Linaro-mm-sig] [PATCHv16 0/9] Contiguous Memory Allocator From: "Clark, Rob" Content-Type: text/plain; charset=ISO-8859-1 Sender: owner-linux-mm@kvack.org List-ID: To: Ohad Ben-Cohen Cc: Arnd Bergmann , linux-arm-kernel@lists.infradead.org, Daniel Walker , Russell King , Jonathan Corbet , Mel Gorman , Chunsang Jeong , linux-kernel@vger.kernel.org, Michal Nazarewicz , Dave Hansen , linaro-mm-sig@lists.linaro.org, Jesse Barker , Kyungmin Park , Ankita Garg , Andrew Morton , linux-media@vger.kernel.org, linux-mm@kvack.org, KAMEZAWA Hiroyuki On Mon, Oct 10, 2011 at 1:58 AM, Ohad Ben-Cohen wrote: > On Fri, Oct 7, 2011 at 6:27 PM, Arnd Bergmann wrote: >> IMHO it would be good to merge the entire series into 3.2, since >> the ARM portion fixes an important bug (double mapping of memory >> ranges with conflicting attributes) that we've lived with for far >> too long, but it really depends on how everyone sees the risk >> for regressions here. If something breaks in unfixable ways before >> the 3.2 release, we can always revert the patches and have another >> try later. > > I didn't thoroughly review the patches, but I did try them out (to be > precise, I tried v15) on an OMAP4 PandaBoard, and really liked the > result. > > The interfaces seem clean and convenient and things seem to work (I > used a private CMA pool with rpmsg and remoteproc, but also noticed > that several other drivers were utilizing the global pool). And with > this in hand we can finally ditch the old reserve+ioremap approach. > > So from a user perspective, I sure do hope this patch set gets into > 3.2; hopefully we can just fix anything that would show up during the > 3.2 cycle. > > Marek, Michal (and everyone involved!), thanks so much for pushing > this! Judging from the history of this patch set and the areas that it > touches (and from the number of LWN articles ;) it looks like a > considerable feat. > > FWIW, feel free to add my > > Tested-by: Ohad Ben-Cohen Marek, I guess I forgot to mention earlier, but I've been using CMA for a couple of weeks now with omapdrm driver, so you can also add my: Tested-by: Rob Clark BR, -R > (small and optional comment: I think it'd be nice if > dma_declare_contiguous would fail if called too late, otherwise users > of that misconfigured device will end up using the global pool without > easily knowing that something went wrong) > > Thanks, > Ohad. > > _______________________________________________ > Linaro-mm-sig mailing list > Linaro-mm-sig@lists.linaro.org > http://lists.linaro.org/mailman/listinfo/linaro-mm-sig > -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org