From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9163C3DA61 for ; Tue, 30 Jul 2024 02:28:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5FAB76B0085; Mon, 29 Jul 2024 22:28:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5AA1B6B0088; Mon, 29 Jul 2024 22:28:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 471F16B0089; Mon, 29 Jul 2024 22:28:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 29CEE6B0085 for ; Mon, 29 Jul 2024 22:28:03 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id B9A1F1C041F for ; Tue, 30 Jul 2024 02:28:02 +0000 (UTC) X-FDA: 82394834004.21.259C895 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) by imf29.hostedemail.com (Postfix) with ESMTP id EC7DD120005 for ; Tue, 30 Jul 2024 02:28:00 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D3SkJLzL; spf=pass (imf29.hostedemail.com: domain of chuanhuahan@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=chuanhuahan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722306427; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=zkoibKK9tbWkHu5YdOgJKQ1PYjdZREX4hpOxdsN90d8=; b=d6X56YsmQXdJLs3Q24OdRR0xCYftSnUHinRpuadrxdWf+/ia3M5GR759U5cOu4NUQiM/o3 EkpcbYI29PaU14KW0tJkmPRuYg2X7rBcsTKh4WkGEro1D/nrHxVDtMgrjuu73c0H49131Y 2YR+Mdpab1uA1Xcb2D1AuJRD/579Muc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722306427; a=rsa-sha256; cv=none; b=vYJQwqNbST3HQfppPPnvnlfiokbZW2kal2FnjYc//KkJxF0KIJ84EEU0qvMM9Pl9VZJUPf XtSsNCr2R3BBQyk9/q/onatiuUuP8/W11bZ/vA+HHy3KkkfqhuTW8g8kPFXDSANmQjljmO y1JtEW7MkWECMHRPDrbZh6qNOJsoVXc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=D3SkJLzL; spf=pass (imf29.hostedemail.com: domain of chuanhuahan@gmail.com designates 209.85.167.46 as permitted sender) smtp.mailfrom=chuanhuahan@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-52f01b8738dso4157430e87.1 for ; Mon, 29 Jul 2024 19:28:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722306479; x=1722911279; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=zkoibKK9tbWkHu5YdOgJKQ1PYjdZREX4hpOxdsN90d8=; b=D3SkJLzLtf9X/Ra8W84Xup4hMZHQ5D23YEEofYaabtA2gfR57J6mRfXcyK5h9ZyQno NupHZX4+JUKkP3z/Ujpyq0Yv4u5ND2GLAdUZ0AHapVuNmdj5W9VrgdmoyUMO312lXrTM cIQ0VjTBOmskUo1QXxfL8CmqevdBTK8C+melX0RdYo4f4B4//+4JwIH3YG/BmoxUa2jM YC4Y4vs/wdHSG4k5Txwjw/af8Pcifa+2xwQgCLHKXjzC4Bpy/eEA+aGQZpvL19gev5C/ SFcU/iAtyhB8U7ikzPYzkJ+v/bgBxCVQEqyGY/f0m7VQkyek6PeYl9JZVBc/v3+rfr5y +Dew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722306479; x=1722911279; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zkoibKK9tbWkHu5YdOgJKQ1PYjdZREX4hpOxdsN90d8=; b=nUIgXt17c+q3LAE0EPjeCs37hNm2vsd1CPZg81jhsubaZkHMaOe3Z+ioOkPL9DqEKg v5Y26fC2UKFk5xHKcVv9vHssNutOZWz2onBr8Jr+xgI/T6zB90cO+P2ZGVpu5sFy6Sho 57nGVqpSIc+WGGp+z0WnAF+AvrCiK4yqm13FZFFwfZd/4rRPXo7GnvQbdqwOrEm7M37U jycYQLFpIxm/BL6V7CVcGtgXRbn7Imc95PStaZ7Ick/KDdta0tt7UT1FSoscfgg0C5NR p+qAWsKK0nfo2ss+2O94ltfasc6LPN0B7QQ/U4hnd+En4KN/VFC5olK2Xqc6V7t66yHZ MoLw== X-Forwarded-Encrypted: i=1; AJvYcCVeXcOzIZzwqt+iY/cq0X11NVXHU+JZ++l2tbMP61EZTnejM0Mf2pTCb5wKvh8DBxiMABNegCi4lA==@kvack.org X-Gm-Message-State: AOJu0YxOB8TUkEa3wbkZZd7io9IEJd0ugv90TNpHUkOV2ZO7BMo+zRMM C7pYMkEksy7kFSr3HpiluvM0Y9xWt61feKbIPs+VMpzB90o91hitjKbCAIJrG0cPNu6Zg+ZkLDD wnmxajObBvuIkq7N7fhgRzpMDUGM= X-Google-Smtp-Source: AGHT+IG1WiuNTv/RAnpYSeYcxvZ7bwBEAwmNBLo3tjB1w85T0B1IjKVoPkYUzQ/9EDwR7NyynQjrewFJLJk8aNFkhQk= X-Received: by 2002:ac2:4f0f:0:b0:52c:cb8d:6381 with SMTP id 2adb3069b0e04-5309b270661mr8278719e87.13.1722306478671; Mon, 29 Jul 2024 19:27:58 -0700 (PDT) MIME-Version: 1.0 References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-5-21cnbao@gmail.com> In-Reply-To: From: Chuanhua Han Date: Tue, 30 Jul 2024 10:27:46 +0800 Message-ID: Subject: Re: [PATCH v5 4/4] mm: Introduce per-thpsize swapin control policy To: Christoph Hellwig Cc: Matthew Wilcox , Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, ying.huang@intel.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, yosryahmed@google.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: EC7DD120005 X-Stat-Signature: ub3m4j668pcpzz6bciy9q9wfqpwoetsg X-HE-Tag: 1722306480-483018 X-HE-Meta: U2FsdGVkX1/PkmOM6UOooLin7kf3ElhSkwJRXpt3XEd2YHbRTlbkcluR5F5zgkYc82kaJuJN0BfiReKGTv62m+Gy1+R9UpNo8GyDCq5LDhl4hTBNil5k1Y65AtLyfr2q/52/C7Cia0D0rjxOkNFl/AA8oJSLto7GadhNGRCLbqV10uw8RC4l6SeOTSNnk1sQyu1Q9nVqshd7VVuqlCJi4vUQcwzUd14vILdHsQofd/z2AWbQjRfssK4hRdU0ivraBKfU00Z3WhrCqw0XPhEcILoGyJuUVBvz2yd/vMFo9VA93HRVumSDGPwk4cenWaesM/8xzDK9ltylOmYswa96PoVQCm42HajEHtrYZ7oL5haclEQTX2U0uYns7Ip+C5oze88Kl8wvoCjPIKobRazjHthaKKPTmXerTCsvAIFqljt6Bb+xqtzk/CZHnrxCPkmRIhctlwCjR1U1vX0r50qQVFzWqujv80jiNYyZUQm+FR1HNYbbKx6R1pgvDNkP06oth8tMUgxAxbrnNGC2PLo5NyleGav4zrjxjLLudVSa+vcIWgjuo+Q8NHq3HkvfJByjl8hCPpE0EDuioIdDqvMS3kt2CUE2h7iWYJ9l/He5pF3+Z4cHFgGMi3hIe4Lum0cIC0NOeomnzpo2025MU6zMLGqtBsjuX3/Q25+wHUfW0gBqkkQKalDZOjpuKfZPIZgW7IyB4M5Seo+SmKUm/ui4uPQ9oW0XzKPyCuSFPQK28vO53IUEjdwoSczKBhhq0tkDZtOhUfLWcUAbLf0pJoHHX377ZWTPgORPpk8Pi0GhpEer8aUkR/rYlKptuuPs/Zo2AekTfB7mXq+ReOQHXpxDFm1ExHKB3zWi4kjar3/h3ofUNtwhpE8bSyHXYN/YMj1A2XrpCdBuKubgBCNh2xxoy9yqtFflEU/fQJ2J3WnqNSUJqLoHEfHQ4xC+52vt166T7LKJMOvku5yskCjzJAq +qFmMVZO 0nOBQjy8w9bR44fX6/lF7qOv3yaLPUaDPgO713Jz1xZgTBQ6vD6/gBgLK4nIZr72ut1P7ZTaYwLVWf6eEmjX5TIpC2qIKvPjoawjDGMpKA8/7Muo+9LORk2RxMU51Q96RKggMZzPuqUh1IE9Tuo4UaLJRNHif+P+/Cpc6uq6qbENyo3d+h8rqXseYSUu3UWAF3jSp/1J24CKoowobkg6ucJbAQDaeKGTO/HCZtgmWwWsoe3d1IxyQkQhrLbujkW22o3J714o8iPCvauChGfxsHxhd6Pfs1373po+mEDCD7hxdwAv0vev8zDCXmEpbOKRYjbpfMkMVs1NjlbRCMINagimfTi4RUUP2T2U7FIhpFPADfuw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000007, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Christoph Hellwig =E4=BA=8E2024=E5=B9=B47=E6=9C=8830=E6= =97=A5=E5=91=A8=E4=BA=8C 00:11=E5=86=99=E9=81=93=EF=BC=9A > > On Mon, Jul 29, 2024 at 04:52:30AM +0100, Matthew Wilcox wrote: > > I strongly disagree. Use the same sysctl as the other anonymous memory > > allocations. > > I agree with Matthew here. > > We also really need to stop optimizing for this weird zram case and move > people to zswap instead after fixing the various issues. A special > block device that isn't really a block device and needs various special > hooks isn't the right abstraction for different zwap strategies. I disagree, zram is most popular in embedded systems (like Android). > > --=20 Thanks, Chuanhua