From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F2E57C3DA61 for ; Mon, 29 Jul 2024 06:36:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BD236B0093; Mon, 29 Jul 2024 02:36:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 86CF26B0095; Mon, 29 Jul 2024 02:36:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 733F36B00A2; Mon, 29 Jul 2024 02:36:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 56F226B0093 for ; Mon, 29 Jul 2024 02:36:54 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id F1606160157 for ; Mon, 29 Jul 2024 06:36:53 +0000 (UTC) X-FDA: 82391832306.07.02E95DC Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf30.hostedemail.com (Postfix) with ESMTP id 2BCAB8000E for ; Mon, 29 Jul 2024 06:36:51 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hIlktu8P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of chuanhuahan@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=chuanhuahan@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1722235009; a=rsa-sha256; cv=none; b=SExeNCF7mi+zguK8HlE6YJ0zNNfnvdmjKRSvIgILXmbhl/lN7LGN3p2SMfYl6VbPY9L5q4 UF9MgcGNBw+T54g4iCHZNqItrm7LglnD9rUt0Y+3EIZLPMXyZjmcfMLsiD5viYu16f0+lV AeR78X7UpUU2Oj4js2kl/XCr0RSW5H4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=hIlktu8P; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf30.hostedemail.com: domain of chuanhuahan@gmail.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=chuanhuahan@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1722235008; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cGJ+4r8n52fnwh3nw7DAkXbq0FHhAsWnzXendtK6RBg=; b=u8d74ygPWTWwwfwlQ9YTUl3NBVw7Rmg3wfjX8cM9QS0moDZIbPOBrPV/cOD6HGqYbgYMOy 65HaAdXoJswv1y/oLEWumxOCD+91pGBsxWaLAgJhwRDpP4g0I01n/m4Ai+98hHvdov001h F4RcQHKpYqYb+kev9Abiw1VmokOATsI= Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2eecd2c6432so48522141fa.3 for ; Sun, 28 Jul 2024 23:36:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722235010; x=1722839810; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=cGJ+4r8n52fnwh3nw7DAkXbq0FHhAsWnzXendtK6RBg=; b=hIlktu8PFICu5Ya63oZBQtVu/OitTjhyvS7fzr5p9wr7rVKRRJynZ/vkz4pInqf7Fr PffKGZxWBsC5tEg6zgkP2J9DW3mxg2y3/OW114Y5nZpf4RZG9Ts0ps1Ps6coWsOvrUXZ 2ScZG/ZiaqP8XAd5JvmG/wnJu8ClBXEeMCr47+9YydowByDy0LXWHGJSnYe0Ygm3Uo+p nGTBZD1YRPAOsROPTrltpujSpbZFzYLZPTPgF7B5h9DOEEfFmMzcVJj5hkCFomJJxmjt 3V2rxpd4lzPLMoQ4IOo5Hom5U+saNhxXKgx9fJ2LIU8mgA2jQ+kIZaGJz2/nzbH66gzw 7QhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722235010; x=1722839810; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cGJ+4r8n52fnwh3nw7DAkXbq0FHhAsWnzXendtK6RBg=; b=VYinwnU62KKPaCfzEHkm/wDh5ZfWLsCgZGWeea3XQZodSG2gaZ4NXTYaBCiGA7f9XC IVuyQn2AMbAE35X8FPX1sUfjz+P3P7eevfQLd7SB/7IQ/3hT81nKht2NMmY8JLssGS0H mP5BsnsUMMJk/BWfV2VdZ+W+I0nXUiWBT2dDJgENap/sNONgfE/QvZoXhVrsM6s78zV1 LOmpPCkFFEcZn2xzGpP/ftw4znYqQBhRkI22G6Loz8ksUwpY9M4szYnHu/D17mJ6Ha3i grizwyVBf3lkipdtTjCY2CBonYf6RhWYPV7GU/fDd/2mSAiLrPOof+6CKNCAXR0BN/ir H9Ow== X-Forwarded-Encrypted: i=1; AJvYcCVrSMNr129joxn+93paIfThOFezIqxHQVNq7F/SsEP9T+qKDqRvR4aqKxFc+LBVWZGOo7vnDoUl05zL0kz1ipMRREQ= X-Gm-Message-State: AOJu0Yw+XgnBtrKYD6KD2CLnO8/Q4xNiis0lspSw6a99nIbhnFnrVY8k ZCrMPC1A2IC6ucVSWclySDx/7APONcGJVPq9p9y06r5Tt63Adr6d1/SAV9Mk1023mFyWMWgPphq 1MlTC4A7VpzXOYOyXUdtv0RsGxgA= X-Google-Smtp-Source: AGHT+IF3rX1Ul358zrZGvQPbgOWmn3EgG2QUYS0e4gVJuMRnufLSVdig55Pb5IcTiegWh4ITw/28v+WXlQ3lQA2JNNc= X-Received: by 2002:a2e:9f43:0:b0:2ef:1ba9:dc5a with SMTP id 38308e7fff4ca-2f12ee29a87mr57743991fa.28.1722235009945; Sun, 28 Jul 2024 23:36:49 -0700 (PDT) MIME-Version: 1.0 References: <20240726094618.401593-1-21cnbao@gmail.com> <20240726094618.401593-4-21cnbao@gmail.com> In-Reply-To: From: Chuanhua Han Date: Mon, 29 Jul 2024 14:36:38 +0800 Message-ID: Subject: Re: [PATCH v5 3/4] mm: support large folios swapin as a whole for zRAM-like swapfile To: Matthew Wilcox Cc: Barry Song <21cnbao@gmail.com>, akpm@linux-foundation.org, linux-mm@kvack.org, ying.huang@intel.com, baolin.wang@linux.alibaba.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, hughd@google.com, kaleshsingh@google.com, kasong@tencent.com, linux-kernel@vger.kernel.org, mhocko@suse.com, minchan@kernel.org, nphamcs@gmail.com, ryan.roberts@arm.com, senozhatsky@chromium.org, shakeel.butt@linux.dev, shy828301@gmail.com, surenb@google.com, v-songbaohua@oppo.com, xiang@kernel.org, yosryahmed@google.com, Chuanhua Han Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Queue-Id: 2BCAB8000E X-Rspamd-Server: rspam01 X-Stat-Signature: zhxfggfc4qm4iy7e6twyda3man8f4e98 X-HE-Tag: 1722235011-261720 X-HE-Meta: U2FsdGVkX18tduxONkEBFdkDYa6KNRvFZrQwvXU3IxP+FFYywl9PfCO5LrRuQAXRyoMpVj+JANFeWamCpmfIbo1ZhKJMESDTT/IyJvLCYKP5E+uNkQVkph2B2I8s/mQNZ7uC+cODUbhvxNaeUo3qcfr3VIpwNxqEhDhh2fklrmVq0tn+RJKhsRnN3httnMeRfyyuxnCqhD1L5e85n5LusxDor57dXXXTlnGYTVn2wbnsuwRLRTYSFY/0kkgoxCkwT+2pl9WZNGYtPionSXOh1+eTpwkp108UpdeI2+48XeWqhAtb2aSx1THzbCmzjrftK+4vMQ7+ElAWnr/V5ctpxLrsSq6CdzLOp3WD8FeH4oqewEDKConc3vrEu4GtAUp0wKYpTHmtWttrYAXcQM2NhUlT/qbvF3DfcFD8Yub7UV8F2IpUQ4ul/wh6SzgU1p22vfPpwJA+u4aFqDoZhamE9OECN1nWdfH2UCTQRbfGRJw2oPWi7bOiK/ZWdHANESny2lgyUz1o47vw4ewdBH+3/5yrKYEeRBm5hkspy08+LgHqmHcySzjguC9MJxaTVWzBDoRI8Lwr5j0xrWTvpx2d6XTDLeEJq171zIPuyCdfAps5dU9w2NiBHFDx+rG+MtEcX75Ri0K8gkvWQQPwuyTWAbewTtCHT+PtafCn2THCDKbVRbRsTalV3BuoMlqTJp3vtqL6XI3lI9KGWiYjtBj4BI6neap0r+aIXezSUwpsproo9NHujUVyF0oBEaQ7uLmHHVXLcG3Pf2sg/qCFacXv1CfaCX6+fMcC4noT2vvRlYuBE7915ZpVkmMehy9ZMFfasdkHFiAqaV3ymPugzzQkVBxt808N4RPBB8O9YrGkidibwItDDtidZgN7/YmIreRuhYEkLA96U6PlJgdfOz28kfov3VTHLdeoMrwWlDnQjrBiB3xMy8MD9U2cbQPq4m11lxoZI8dmL6mc0BUKuqn BaaDnm43 3LtgmP4ZeEyOnknYffcJp96t6ymiTL3j7fx4HXgrbaQBboshtB2bS4pMsyKhKhpF/DFGoBJ9Fihfm+Nnu1qmJF39Ws/oyYWdAJ0cC5vslROF6zPYlykdUZJ3DBn6r0jHKUp59jesUDgVKXw9pKqd6N5BlqmPeohdP8Gw6dJyMUhs+l4s+qXqYOrN4GlfuvR0mLgkVyy+OdkLZnK6lOEzhmQOyGvR/tFh/B8NO3c/Hz9FIenKlpy1bPAoQKZt/TjhJzrDaX8v0I7fW2rekIrPvqUwOuEt4k49nNL9a4lE2DXHFCmtnvEsM5GiC1G2a3r48L7k687BCj96K8Hnr7on5/4eC/wKzpNa++8E2HAgOVso8vGA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002285, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Matthew Wilcox =E4=BA=8E2024=E5=B9=B47=E6=9C=8829=E6= =97=A5=E5=91=A8=E4=B8=80 11:51=E5=86=99=E9=81=93=EF=BC=9A > > On Fri, Jul 26, 2024 at 09:46:17PM +1200, Barry Song wrote: > > - folio =3D vma_alloc_folio(GFP_HIGHUSER_MOVABLE, 0= , > > - vma, vmf->address, false)= ; > > + folio =3D alloc_swap_folio(vmf); > > page =3D &folio->page; > > This is no longer correct. You need to set 'page' to the precise page > that is being faulted rather than the first page of the folio. It was > fine before because it always allocated a single-page folio, but now it > must use folio_page() or folio_file_page() (whichever has the correct > semantics for you). > > Also you need to fix your test suite to notice this bug. I suggest > doing that first so that you know whether you've got the calculation > correct. > > This is no problem now, we support large folios swapin as a whole, so the head page is used here instead of the page that is being faulted. You can also refer to the current code context, now support large folios swapin as a whole, and previously only support small page swapin is not the same. --=20 Thanks, Chuanhua