From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD815CEFC2A for ; Tue, 8 Oct 2024 16:04:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D23A56B008C; Tue, 8 Oct 2024 12:04:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CD4426B0092; Tue, 8 Oct 2024 12:04:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9B916B0093; Tue, 8 Oct 2024 12:04:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 99D866B008C for ; Tue, 8 Oct 2024 12:04:48 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A526640635 for ; Tue, 8 Oct 2024 16:04:46 +0000 (UTC) X-FDA: 82650908214.20.A0B895E Received: from mail-oi1-f181.google.com (mail-oi1-f181.google.com [209.85.167.181]) by imf19.hostedemail.com (Postfix) with ESMTP id 5C6F81A000B for ; Tue, 8 Oct 2024 16:04:45 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=g-cbnu-ac-kr.20230601.gappssmtp.com header.s=20230601 header.b=WA1QBS12; spf=none (imf19.hostedemail.com: domain of chminoo@g.cbnu.ac.kr has no SPF policy when checking 209.85.167.181) smtp.mailfrom=chminoo@g.cbnu.ac.kr; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=cbnu.ac.kr (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1728403306; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RI4qCA8JgM8io7CiCSlRHOd28/LylOH+L56eOwjt9x4=; b=tWeFk68Uy4Rlu4ZttfSMwPzBJF77POBVtl7LjSGToa96V7xVNU0mEKE6dEmx27bRebNPhH YUZiryfo/1+OhCHQbfKyyQu6WMn+LBh+7CXeZGA99LU4TDjVihqjab638ceX70syqqD2X1 F9Eni6LCoUB/SgECXjb2ByBQV1ZKvzk= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=g-cbnu-ac-kr.20230601.gappssmtp.com header.s=20230601 header.b=WA1QBS12; spf=none (imf19.hostedemail.com: domain of chminoo@g.cbnu.ac.kr has no SPF policy when checking 209.85.167.181) smtp.mailfrom=chminoo@g.cbnu.ac.kr; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=cbnu.ac.kr (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1728403306; a=rsa-sha256; cv=none; b=Es7NGVLKF6vP1hbwUpcOJZvEyVSItDkCLHdQoFYis8kz8qemp+7aNkgZxe7Y8FTHuh975g rNvk5JKr17pcLRlxDlGleMo+R9zB7L0pR0u9sZuzA2r5g9RSYcLaPEbSIYSt+PVAQgJCye 7Vzsp6i2xnnxWxNqroRr12V1OeVufwY= Received: by mail-oi1-f181.google.com with SMTP id 5614622812f47-3e163e2a9fdso3377519b6e.2 for ; Tue, 08 Oct 2024 09:04:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=g-cbnu-ac-kr.20230601.gappssmtp.com; s=20230601; t=1728403483; x=1729008283; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=RI4qCA8JgM8io7CiCSlRHOd28/LylOH+L56eOwjt9x4=; b=WA1QBS12YRPVb40LfnncQDZytV8CEvHEv2XOq5gz5wr6lGBr2PG+Kgsvo/e/dzKYLc huJQ9my4NnBrLvm3mQrnQgvLlWlEEeXHzGB4kUs6dYTcSwYZCd+nrZ5765yBKBwkwpoJ XfVev1RPRC1t+u3mFolBDEM8YYVJjV1rUOIKHbR12P8f6pozodU9DfRrZTmSwIyw8wtb P5bhzgo0I6UOeY2I9Q91Yu9MIe/61IZ8Y7BKo3Bv3R42MfQRWoou4mSj+nqYvrUBn8ZR OUzuPyIwmqXU/PReJCP9YqE2/rkf9StcyIkOKkKbbeeh8OfS0L2xZoUqRl3QIFPOUZDj t5nw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1728403483; x=1729008283; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=RI4qCA8JgM8io7CiCSlRHOd28/LylOH+L56eOwjt9x4=; b=O1Pj+i9WphYcgOhM2omKBWwr8WRvI/wUj9h3qNfRm+wcbmblwc6gzI3QNIvzggipcg PzH/7nBL+YlxcUDVPwTvgkdqdm1fwKmqM6Svp0lWrlz+AWB+wXPs+NX+xybH9PBxBxep VHmi66k0QjG9P4aU59nfyjvGiB9YXZYDTvWqw9ML0BtHyrVD8zrETsl0/TYxXCXDv/kN lnKyjlt9zkCR2gdzTUXiNFlbbddoX5t72LiPRVuDReapsCJs+5EEUWQfy/Pta64kZwQI S5K0y34mEN1kyGvJfZfsrNNBfzxVffbZuuLLgc5TaOmsXYt7iSEAm7iJPNA2xfCeKeGP VYGA== X-Forwarded-Encrypted: i=1; AJvYcCXsEK1NvLjtXDrESJcC3uzW06zGJq/fhwK5pIGYEEX/mxPBcwoULBTNJqwqPdCHzEhy6v8QLNR2KQ==@kvack.org X-Gm-Message-State: AOJu0YzDAZjDOdnD8oyufXCqrm3VTODQhAk8SBmtgha5lZeA53BmFVTX pOuilgPaZ568vnjNeuf9/y7SqMlShJcugv3KZ2nWC6RnE5fLO95ETCLqOFLjPvxZBmxIMUREpwS 0rczokMkii9D+G0cH3UiFXMuDX1PmXFrMAbBj3w== X-Google-Smtp-Source: AGHT+IF3EyK3D876XPQe7CrVFK3aAvwFqwsICh0rNHyQaMCGCnzw11VxfL2z8BH7tEuPZ/2TyREIO1HgnF6c3i4vMmw= X-Received: by 2002:a05:6808:21a4:b0:3e0:42a6:386a with SMTP id 5614622812f47-3e3c156cedemr14652806b6e.42.1728403483600; Tue, 08 Oct 2024 09:04:43 -0700 (PDT) MIME-Version: 1.0 References: <20241008084411.196455-1-chminoo@g.cbnu.ac.kr> In-Reply-To: From: Minwoo Jo Date: Wed, 9 Oct 2024 01:04:32 +0900 Message-ID: Subject: Re: [PATCH] Hitshield : Something new eviction process for MGLRU To: Mathieu Desnoyers Cc: akpm@linux-foundation.org, rostedt@goodmis.org, mhiramat@kernel.org, willy@infradead.org, david@redhat.com, yuzhao@google.com, heesn@cbnu.ac.kr, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Content-Type: multipart/alternative; boundary="000000000000ab48960623f94ba2" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5C6F81A000B X-Stat-Signature: 6e7ys3ownz1daqi1pe51s3rbg8pqw5h6 X-Rspam-User: X-HE-Tag: 1728403485-704414 X-HE-Meta: U2FsdGVkX1+ZbsHhkBYj2xr7vc9v/oy83NbJkmr3l5EaJWgg21TcNRvY0N+XzZOvkc3O2y3bwzKEYOvnAMZ6Z1hVWa6cpSLTKYRkLrrkWwY45hjWKoHqRLP/WIr+UvS1R036KKNhVAY89cYko1pJULw8CnpqJNgpreDQ4k2g+KZ5m+FxvqEkRODfUiZdTTNTm94YfkSFgf8K2AEk8f7IScuPRDixSNSf/XBU+01dP93IkafW4r2LC/E7UaZL9A86Qw8jJJIxXbomrSYt6Mg8Fjy8EPxEheUsRXuUYF2dJRkRwmgDsmBgV/3nwolVe3BlrS5snyk+kY0wrgDIDl9KhFjw98KakpV21rPjxNLHjZ6r4jT2y+qv4IdXc5Ff+LL8tUA+FabJU/kbKHItPz5OMwPx/9ZowKWL1nyLLlGeQuXFGuZN3RzNZ0U5y49RkVMALGBWJz1NtOuIu4Y+Esm0oR5CdoxBtsJCFDtM2dJWixlitrHeTcygsNbVWiyu0PSrWLInxfG4kbJ/JtCS8qlNT2SkJRwJyZXnu1X5+engz7X/Jq51LC7thVuQEZoQBEsa3vJ/HZjVYHLA2XgN338o2RlhIWJQZEMdeTdr7ttacak8Db9SXTsichfMskfoZLh54iso/q/sGrs0W7aNy9RtuLLjhD3fQk2uR6GhQsQJ+ldjHCAUGkQzOLWTMJFZrwkckYXGBiKiGMcc9kjDt0Uo1Ug3VQRyWOovaYSuyeume/2cuyaEL2W2L5TgxWfMzprnLx9woL9hFdjKC6dVYSS7PtBHUCdKTKQe/QMB/ppXF61eq3xvdVIn7iNAX8XZchobPxVdF1Km4/I+3K4tP7bka7n7P1UZgN1D7W/EjN+RpOr6aeFkRbst71HJ5Hgf20/6+M91Z116o2jWHbcacZiZOHVhP7zO1FzLWefJTIKmj0uH7lt2t9g6aDWGh7+cdl3U3viqTTYNRPJBnAG5o6t VfNKXMu1 DhL1KSs1vrHDy1s4jIA6Chp3pREi3qCMV4s8m47d0Oc5UtE7nauiVXMzN9QUPiDfJD6S/0KtpU38ZH9Hn8uGUWVAYhXgKW3DLeUKjy0bjHV7tMlDFrOIpLtIYG8UDgj1Ey+bHZfPRO+bSLggDi6PO44JfX5FoP9YvLLw/3MMzNweqFMDumUglfqqCqe9vt7KrRCNzaL8iIoPGNM9hy29PES9N2BdVAwShAfDM+UC8uyWt3YmeOcEBGJ7XLC9PRI7quDYNMTMBaNL19pJqeymR3G9/lOzdx1ROWktGGrII8Y7ZqdcDubXG2YIGkQNI8XiWuHoR3QWcw+DnSzI9bSLvMJNBnfMDy0pzI2nheivp5wJ3gbzpOxZaWX6sHvIFkQxIiCpkz5kMpXArlEXlKv6LIRUKXiGzCcCt0McK7Nbq22Rk1J3ZazyRa+KpPZ0hKedD6UZ5CZ5t8E8tR8DuObeB0k1/GUKiZ90pU4LftqbMLdKx7b5grssoShbUoECgoXkK5d4/qdwYByTeV5ncDyBXF/DDzO3d738NG9DufbMCmGxDID6xxNHbZRLx7+OyOCnmD8cA0zhiMrL9v6YcCYubX5vv/KaYm8VrraO1vyIHKowXYT2vD8LQV84ayJHZsL23drBX795AQLcTJUTHyX9BSLFxrgT7xJvHTnkM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000127, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --000000000000ab48960623f94ba2 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable 2024=EB=85=84 10=EC=9B=94 8=EC=9D=BC (=ED=99=94) =EC=98=A4=ED=9B=84 10:21, = Mathieu Desnoyers =EB=8B=98=EC=9D=B4 =EC=9E=91=EC=84=B1: > On 2024-10-08 15:02, Mathieu Desnoyers wrote: > > On 2024-10-08 10:44, Minwoo Jo wrote: > >> Signed-off-by: Minwoo Jo > >> > > > > [ Any reason why no mailing lists are CC'd ? ] > > > > [...] > > Please consider CCing LKML and the linux-mm mailing lists on your reply= . > > The Documentation/process/submitting-patches.rst document describes who > should be CC'd when submitting patches. > > The script scripts/get_maintainer.pl will help you identify which > email recipients are relevant for your patch. > > Thanks, > > Mathieu > > -- > Mathieu Desnoyers > EfficiOS Inc. > https://www.efficios.com > > > [ Any reason why no mailing lists are CC'd ? ] I think I did some mistake when I mail, so I add CC to linux-mm@kvack.org (open list:MEMORY MANAGEMENT) linux-kernel@vger.kernel.org (open list) linux-trace-kernel@vger.kernel.org (open list:TRACING) > Have you considered alternative approaches, and why is this approach > better ? I used an alternative approach of creating another wrapper or value approach, but this was not good because it increased memory usage per folio, resulting in more swaps. > Do you have benchmarks of workloads that regress with this feature > enabled ? How are they affected ? I tried another two benchmarks, 7zip benchmark, YCSB. The 7zip benchmark shows a 3.1% reduction in pswpin, 2.8% reduction in pswpout, and a 2.9% reduction in runtime under 1G constraints. Under 2G constraints, pswpin decreased by 22.4%, pswpout decreased by 21.2%, and Runtime decreased by 14.8%. On 3G constraints, pswpin decreased by 3.3%, pswpout decreased by 1.3%, and runtime decreased by 1.9%. We also measured the Yahoo! Cloud Service Benchmark. YCSB showed a 69.9% decrease in pswpin, 67.1% decrease in pswpout, and a 5.1% decrease in Runtime at the 500M constraint. At 750M constraints, pswpin decreased by 83.8%, pswpout decreased by 81.0%, and runtime decreased by 2.4%. On 1G constraints, pswpin decreased by 79.5%, pswpout decreased by 76.7%, and runtime decreased by 3.8%. > Documentation should be there first, or at least something explaining > the rationale and design. I think my previous commit mail might be helpful. https://lore.kernel.org/linux-mm/ZpvY_aZV4VtMmXP-@casper.infradead.org/T/ Thank you for your response. --000000000000ab48960623f94ba2 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
2024=EB=85=84 10=EC=9B=94 8=EC=9D=BC (=ED= =99=94) =EC=98=A4=ED=9B=84 10:21, Mathieu Desnoyers <mathieu.desnoyers@efficios.com>=EB=8B= =98=EC=9D=B4 =EC=9E=91=EC=84=B1:
On 2024-10-08 15:02, Mathieu De= snoyers wrote:
> On 2024-10-08 10:44, Minwoo Jo wrote:
>> Signed-off-by: Minwoo Jo <chminoo@g.cbnu.ac.kr>
>>
>
> [ Any reason why no mailing lists are CC'd ? ]
>

[...]
> Please consider CCing LKML and the linux-mm mailing lists on your repl= y.

The Documentation/process/submitting-patches.rst document describes who
should be CC'd when submitting patches.

The script scripts/get_maintainer.pl will help you identify which
email recipients are relevant for your patch.

Thanks,

Mathieu

--
Mathieu Desnoyers
EfficiOS Inc.
h= ttps://www.efficios.com


> [ Any reason why no mailing lists= are CC'd ? ]

I think I did some mistake when I mail,= so I add CC to
linux-mm@kvack.or= g (open list:MEMORY MANAGEMENT)
linux-kernel@vger.kernel.org (open list)
linux-trace-kernel@vger.kernel.org= (open list:TRACING)
=C2=A0
> Have you considered alterna= tive approaches, and why is this approach
> better ?

I used = an alternative approach of creating another wrapper or value approach, but = this was not good because it increased memory usage per folio, resulting in= more swaps.

> Do you have benchmarks of workloads that regress w= ith this feature
> enabled ? How are they affected ?

I tried= another two benchmarks, 7zip benchmark, YCSB.

The 7zip benchmark sh= ows a 3.1% reduction in pswpin, 2.8% reduction in pswpout,
and a 2.9% r= eduction in runtime under 1G constraints.
Under 2G constraints, pswpin d= ecreased by 22.4%, pswpout decreased by 21.2%,
and Runtime decreased by= 14.8%.
On 3G constraints, pswpin decreased by 3.3%, pswpout decreased b= y 1.3%,
and runtime decreased by 1.9%.

We also measured the Yaho= o! Cloud Service Benchmark.
YCSB showed a 69.9% decrease in pswpin, 67.1= % decrease in pswpout,
and a 5.1% decrease in Runtime at the 500M const= raint.
At 750M constraints, pswpin decreased by 83.8%, pswpout decreased= by 81.0%,
and runtime decreased by 2.4%.
On 1G constraints, pswpin = decreased by 79.5%, pswpout decreased by 76.7%,
and runtime decreased b= y 3.8%.

> Documentation should be there first, or at least someth= ing explaining
> the rationale and design.

I think my previous= commit mail might be helpful.
https://lore.kernel.org/linux-= mm/ZpvY_aZV4VtMmXP-@casper.infradead.org/T/

Thank you for your r= esponse.
--000000000000ab48960623f94ba2--