From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3DBD7C433DB for ; Tue, 2 Mar 2021 05:57:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CED5B614A7 for ; Tue, 2 Mar 2021 05:56:59 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CED5B614A7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 42EA18D00DF; Tue, 2 Mar 2021 00:56:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3DDEE8D0063; Tue, 2 Mar 2021 00:56:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F3BD8D00DF; Tue, 2 Mar 2021 00:56:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0049.hostedemail.com [216.40.44.49]) by kanga.kvack.org (Postfix) with ESMTP id 18E628D0063 for ; Tue, 2 Mar 2021 00:56:59 -0500 (EST) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id C8C3B181AF5CC for ; Tue, 2 Mar 2021 05:56:58 +0000 (UTC) X-FDA: 77873875716.22.F1C5085 Received: from mail-vk1-f175.google.com (mail-vk1-f175.google.com [209.85.221.175]) by imf02.hostedemail.com (Postfix) with ESMTP id 1E034407F8D0 for ; Tue, 2 Mar 2021 05:56:56 +0000 (UTC) Received: by mail-vk1-f175.google.com with SMTP id f145so4178552vka.8 for ; Mon, 01 Mar 2021 21:56:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FyQGX2eMD6rdBbtObdA7/Z5HmES0IXIuNjRnK1kjO1s=; b=XndK7/Dhs0vxfvaUMiOisvVA4lOGqSC2DLw5kP6bHqigqwNLJoeaC1uQgZ7uSgPoQY 7OG2XduyIIq8fq9ZVXvHGCCv6Tn707+lcvUMAlaB99mynoLi0VLU9T1jSuikc9NsvzX3 4QEK4fZ/zMu4YO271Em55YtLxqWmdB5ZVP+Wle25ZjfeX+73sipYgrcpgSitPeJnPAY8 6wyhnaJpaVc4+te6ZDSqYg4D0nWi4hxjjE+SaeJwDwlhfVfbzCtOBHhRaHCLIuX2YDRd Xry0Mo4PLdDEzWazlv3J9/xKPMSgTteB08wKjMBtuf9uqwm+3fve4xFf5F6cyRkchKqp EdJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FyQGX2eMD6rdBbtObdA7/Z5HmES0IXIuNjRnK1kjO1s=; b=BwUEzpslsx7WtEZPsaosMNRIy4xGamWHxTPW8PU0PW7lVVvj3U13stY9kCrAOp01e6 OgWS7HRG40YCDNwsLIHR8kBGKoOL2JICEVjcPebA7FGN1FME6Oo7nkXwZo8xteXDyzku u85b/KlZSPCOso8eM46W0HMNi4ZEamBsBEo6+lCsU7bWKFMfFFfMldGb0G4U5FoGIeRs kOKw11tq5o/kNh8L+fTN4EBYv1XYdvUPCzMXTgCp5mWjEdK0pUWEwCbhmDpZSLp4YEBX 6xPigU+dODXd47POYU6m6yQbpJeR68H2qoDifEFjokyXTTVutuQL40THdFuBp+YGOK4j vuwQ== X-Gm-Message-State: AOAM530hIyLEPmdNKdb45EnRdjbG/BSbZQSvuua+ogjv1C90PYUtQMJ2 YvvMaO69nKxdLfQlgUO/EqKtmjgMtQIVVu3c+OE= X-Google-Smtp-Source: ABdhPJw/xVhLKZGJK07lCSlrpxQcqWqwfvmSy8bClGRVi/883vBnbM5n7MX/epQB0Bp+arN+D+tW8MkHgPT1M38xTe8= X-Received: by 2002:a1f:1255:: with SMTP id 82mr1371048vks.21.1614664617716; Mon, 01 Mar 2021 21:56:57 -0800 (PST) MIME-Version: 1.0 References: <1597061872-58724-1-git-send-email-xlpang@linux.alibaba.com> <1597061872-58724-4-git-send-email-xlpang@linux.alibaba.com> In-Reply-To: <1597061872-58724-4-git-send-email-xlpang@linux.alibaba.com> From: Shu Ming Date: Tue, 2 Mar 2021 13:56:46 +0800 Message-ID: Subject: Re: [PATCH v2 3/3] mm/slub: Use percpu partial free counter To: Xunlei Pang Cc: Vlastimil Babka , Christoph Lameter , Wen Yang , Roman Gushchin , Pekka Enberg , Konstantin Khlebnikov , David Rientjes , LKML , "linux-mm@kvack.org" Content-Type: text/plain; charset="UTF-8" X-Stat-Signature: sjbjtgydyhmo3oz4smx6tcffh5oosr1g X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1E034407F8D0 Received-SPF: none (gmail.com>: No applicable sender policy available) receiver=imf02; identity=mailfrom; envelope-from=""; helo=mail-vk1-f175.google.com; client-ip=209.85.221.175 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1614664616-575347 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Aug 10, 2020 at 8:22 PM Xunlei Pang wrote: > static inline void > @@ -2429,12 +2439,12 @@ static unsigned long partial_counter(struct kmem_cache_node *n, > unsigned long ret = 0; > > if (item == PARTIAL_FREE) { > - ret = atomic_long_read(&n->partial_free_objs); > + ret = get_partial_free(n); > } else if (item == PARTIAL_TOTAL) { > ret = atomic_long_read(&n->partial_total_objs); > } else if (item == PARTIAL_INUSE) { > ret = atomic_long_read(&n->partial_total_objs) - > - atomic_long_read(&n->partial_free_objs); > + get_partial_free(n); Is it "ret = get_partial_free(n);" above? > if ((long)ret < 0) > ret = 0; > }