From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827F9EEAA7B for ; Thu, 14 Sep 2023 22:46:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 02D538D000D; Thu, 14 Sep 2023 18:46:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EF8558D0001; Thu, 14 Sep 2023 18:46:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D99258D000D; Thu, 14 Sep 2023 18:46:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C59CD8D0001 for ; Thu, 14 Sep 2023 18:46:00 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93DFDB3B79 for ; Thu, 14 Sep 2023 22:46:00 +0000 (UTC) X-FDA: 81236687280.08.957A4DB Received: from mail-ua1-f53.google.com (mail-ua1-f53.google.com [209.85.222.53]) by imf29.hostedemail.com (Postfix) with ESMTP id E0C8712000E for ; Thu, 14 Sep 2023 22:45:58 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VasRfLug; spf=pass (imf29.hostedemail.com: domain of souravpanda@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=souravpanda@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1694731558; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=jlgPzhd084bsbLJHr71Ta/ij7PcjaBHfQeDxuJnf5Vo=; b=cwiWiyf2vHstvd9epEO7xrZD5N7GEcFfxyQbZQHZ0WO5UU8d09JAiN+LHftJOUF2O1Qk4x oHQief0bbgv3ujfSUa51rg0sopKrNA8MQuzFxXkB24rI/veL21hbs/85weGOVq2ZCOg/3t e5wYn70cLdH5yrXlqev3a6JVmsOyZwc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VasRfLug; spf=pass (imf29.hostedemail.com: domain of souravpanda@google.com designates 209.85.222.53 as permitted sender) smtp.mailfrom=souravpanda@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1694731558; a=rsa-sha256; cv=none; b=lZfoHYrGVjJKHUt41nhv/HS5YalJiRgtMB2uHx5c0f+ynqRvtoS4amODtjShd6l9Vt/osj z8a20vGSaKXlMIJhcvhebLpOuVpXPoKK4IVTDI0bZ70Yj0IIxHBSjheFw7mdvIq3v44RPO R+2fyIUXnDODevVfq8hE45I5x86PjTM= Received: by mail-ua1-f53.google.com with SMTP id a1e0cc1a2514c-7a893053770so606231241.0 for ; Thu, 14 Sep 2023 15:45:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1694731558; x=1695336358; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=jlgPzhd084bsbLJHr71Ta/ij7PcjaBHfQeDxuJnf5Vo=; b=VasRfLugbKkPnhK4N2IEcMjeSNvJM03t9eGv9vowd4Tw9BTwMnvzDRG+73WAzC/b3G BKJAaQ6UafwmtlxothXlrHnhj85got82TYExFW8T/3SBiVswZsa45RGb4XR15696V4AI dAVSWR73vG1bXsuU9L6O1IaxYz8dt6SoQ58gwpD6iququfao+ztI4Mewuc0VDUbbB1NI erOsB39kuZJm9T6ZxTKAECL2S28u31fFDBKxN3DgtuSWmo9k+C8oLKifmnuWU5SMlxLI 7fX0pRJ1h+C66N8NV6Kp/bE1YYYNtSTkygh0ceHLZeOBRUnY9Ku1Sc972hLqRRyBIw4l RNyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694731558; x=1695336358; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jlgPzhd084bsbLJHr71Ta/ij7PcjaBHfQeDxuJnf5Vo=; b=uV7sSDVMwCYPxflRdasq4mjVo/b6MGfvzXqei3MNzEXuYu0J6efhER/7riT+TjHHwk q9rXQ+KSEBJc/9PLjS6TZ7MFW1KbE8L79fxk7G0089p6DvxpGKU0xYwvD8u+fi8pM9IE 54alL7fHcth1r9O5laxaaquiYKQZdrwKSw8cuAnsfkda2HQ+kM8hnwpwa/OZ4B4r4nV8 FJZKUmZTQJn/8MZnnacP45h67rVGcwiL00qTeZeXpzlgNJyZG0Uhqk/h2uyK833VpLtM e325akcHBtQsuh6HNEdwdK/CoWmzpO5yvQ7X1IpPYreqL+k4n73WORC3S04ELlD5FImz ZSUQ== X-Gm-Message-State: AOJu0YzD/WtmttXHVc16f0R0rEVV84fkmE68DC6B7/f1et2ALaiGI63g 4rKKSgF6eAPxLnair+qoKDACoSwDmKAdMAVzn5yhvw== X-Google-Smtp-Source: AGHT+IHpBJ4+fUMGy6c2NzzE1oK3VYl6tiJCGKfsRXP1XTyPsB7/t/IqDdJyJUDT/rUe2EVaTuq8ZxLctpeYszkuwSA= X-Received: by 2002:a05:6102:222c:b0:450:985f:ef28 with SMTP id d12-20020a056102222c00b00450985fef28mr1750978vsb.5.1694731557912; Thu, 14 Sep 2023 15:45:57 -0700 (PDT) MIME-Version: 1.0 References: <20230913173000.4016218-1-souravpanda@google.com> <20230913173000.4016218-2-souravpanda@google.com> <20230913205125.GA3303@kernel.org> In-Reply-To: From: Sourav Panda Date: Thu, 14 Sep 2023 15:45:46 -0700 Message-ID: Subject: Re: [PATCH v1 1/1] mm: report per-page metadata information To: Matthew Wilcox Cc: Mike Rapoport , corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, pasha.tatashin@soleen.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Content-Type: multipart/alternative; boundary="000000000000801a22060559701c" X-Rspamd-Queue-Id: E0C8712000E X-Rspam-User: X-Stat-Signature: defen4f1z6gcnzfzkd6j4iibn1xmem6j X-Rspamd-Server: rspam01 X-HE-Tag: 1694731558-676428 X-HE-Meta: U2FsdGVkX18XRhYReKI5GNQtANo0V4Hpf1GzsgxHheYFpovkQY14YglqT9dXmtlSdSTF+xHfCVATAg+9kCWWUniFfbRyAYHDrmVwiOmycJFWztovCZtKH1rlKba3oxulnUy6G+WYJgciZfcmGKMLO5TDHxdPMWIGGbhL0PZLaFmuLmDhcY0+/1L6lcO/z0ltmgqL+URpPK29cBjsvzO7q1JFuIx2zo7t36Ti2dmBk9fayXJWj5cAgKlNCXOMbwf2KEXaR/asj6vH/+W1jaehsJNxf7YJx//CyU9YQUMz1cLw9qxp5PBYDEE5NW0VAYgMtzP5CxgZ8gQscbwfTpXvpPtDBS5iWXg+Kkki4eFeXTb12LHmQSySZcgDhhljzZp9nx2U6dskcfILVwcwecFXkAQTcoXz52Blj5bJBWgN+uXPbCMjKnliS5L/k5kFwqKG+F1MfuOcoqA9zvMzFk2R6KHRf98IlfEvHq3J9zi3vTqG1NbHfL6HPAPewfGAXapwrps0dVYR/JO8f260czJHiBffy+wewNrq8RIM2V4MMFLQxpOCwuuLyd8X+Mr+c5YuDYs7Y+XSeKRHLIIyI3CQy0ZXMRVeF+RG6+V1qd1a7dypUjaQMXRFqfcL/LtoY6iVpiCnCTaJGchc3LkRIu1giF17UC7LvcHvz1p5sXBvhtDRimrI/wT7CSo0KPa2jOd/tlCHv9GneV8ASsIhdIOfK8ATOVpXjSjHRT6DgeH0n9OPhaUdQctKhhf3lVwRc6koGWgpUzOJtp/OugyZUvlhPdzovZFwTf2S3uLLW53ESNtUtpvgH0AmZPWRax0u+lY+ULYWCZ1OLVOwXEIF5EH0T4q+dnK7yrZbWsZ5Jge1TytH4l1vq5aQDQG/egKodyRk9mWyUDrmZZxNfrKmbGM3fda83y3t1/qVB9aLnpZz4besAsKYikB9SA4FQ4JqCD52Q+FFqTAZmvBe0IjzdR3 qBj8OMj3 kbsMeTZGeSd808HukbhwARx1Zedm8NB6POTVUTxeYDZwjB6BkEpMXQUijKJCSopYZ6QVSkbat3/qmKUvujSdfKSVk34+8UJkDq86Ftt7apJJUVRg4ZCGqp7Q6DfbIgux7Z1+1Y6jVN/PpGqMrsg7TSf0TDj+ICeqhiXLFX096GMYv78OwNRg3PT9CTtw6OZwyIHU8BVgu13GvqEOe/hPeSVNQRLqcER3S8q+QSb5ShMMsVxrjw/8vPoH04vhiGhHiU6ru5EdvpQhKBnNCp98uMo2Fm8faqblusWMyeRBNaqwLd365sfXS9KUXrT54rX8jKZ+bzIOLL+A6zo6xWAHh/3a16yNiNY039XY2tokSltcMsEF24/WWLTczOm6feqZOr0YEhjob+3zWgBGX8y8Hkdd/CrrpdPhrUA/ePMe5GkWbpZHZ4oWtoVutYazeRfLdKc48DSHXmFZ9E/w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --000000000000801a22060559701c Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Thank you Matthew Wilcox. On Thu, Sep 14, 2023 at 5:48=E2=80=AFAM Matthew Wilcox wrote: > On Wed, Sep 13, 2023 at 11:51:25PM +0300, Mike Rapoport wrote: > > > @@ -387,8 +390,12 @@ static int alloc_vmemmap_page_list(unsigned long > start, unsigned long end, > > > > > > while (nr_pages--) { > > > page =3D alloc_pages_node(nid, gfp_mask, 0); > > > - if (!page) > > > + if (!page) { > > > goto out; > > > + } else { > > > + __mod_node_page_state(NODE_DATA(page_to_nid(page)= ), > > > + NR_PAGE_METADATA, 1); > > > > We can update this once for nr_pages outside the loop, cannot we? > > Except that nr_pages is being used as the loop counter. > Probably best to turn this into a normal (i =3D 0; i < nr_pages; i++) > loop, and then we can do as you say. But this isn't a particularly > interesting high-performance loop. > I agree. I shall turn this into a normal (i =3D 0; i < nr_pages; i++) loop and then make the relevant changes. --000000000000801a22060559701c Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Thank you Matthew Wilcox.

On Thu, Sep 14, 2023 at 5:48=E2=80=AFAM Matthew Wilcox <willy@infradead.org> wrote:
On Wed, Sep 13, 2023 at 11:= 51:25PM +0300, Mike Rapoport wrote:
> > @@ -387,8 +390,12 @@ static int alloc_vmemmap_page_list(unsigned = long start, unsigned long end,
> >=C2=A0
> >=C2=A0 =C2=A0 =C2=A0while (nr_pages--) {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0page =3D alloc_pag= es_node(nid, gfp_mask, 0);
> > -=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!page)
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (!page) {
> >=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0goto out;
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0} else {
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0__mod_node_page_state(NODE_DATA(page_to_nid(page)),
> > +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0NR_PAGE_METADATA, 1);
>
> We can update this once for nr_pages outside the loop, cannot we?

Except that nr_pages is being used as the loop counter.
Probably best to turn this into a normal (i =3D 0; i < nr_pages; i++) loop, and then we can do as you say.=C2=A0 But this isn't a particularl= y
interesting high-performance loop.

I ag= ree. I shall turn this into a normal (i =3D 0; i < nr_pages; i++) loop a= nd then make the relevant changes.

=C2=A0
--000000000000801a22060559701c--