From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96456C04FF9 for ; Tue, 16 Apr 2024 23:44:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D5B406B0088; Tue, 16 Apr 2024 19:44:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D0B696B0089; Tue, 16 Apr 2024 19:44:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD2C96B008C; Tue, 16 Apr 2024 19:44:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9E6656B0088 for ; Tue, 16 Apr 2024 19:44:55 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 3795F409E2 for ; Tue, 16 Apr 2024 23:44:55 +0000 (UTC) X-FDA: 82017027750.25.FB4BD00 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf22.hostedemail.com (Postfix) with ESMTP id 70A38C000C for ; Tue, 16 Apr 2024 23:44:53 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vAnlXEmp; spf=pass (imf22.hostedemail.com: domain of souravpanda@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=souravpanda@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1713311093; a=rsa-sha256; cv=none; b=DLQA4tJq/nhnT/64r8bzUpFL+iO9B6tA5pfEMO+Od7wgvRv6Y/22Xch9HH1GD4baWQ+Q3Y Z41JDx0vEpum/hXeQHBOL4N2bx0fFHvskW9tXU9bwwjb1QXVgSKM4dfzkXDFp0REP0wl6q ZXqcSHemcMAnqqc4MA0OsI+uxwyhPnw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=vAnlXEmp; spf=pass (imf22.hostedemail.com: domain of souravpanda@google.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=souravpanda@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1713311093; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ajEWa5JhijpKKEUqq0ZAjRoV3oE4FFW6E5v2WulubRs=; b=scf0HXqno74oQBSaQJTjAPfPu+/OtVOGVwJD8kM/yRH6nKAw5zY053lOKavXTCkLnZYSk3 DZLxqlaKGXqh3D6q6tBD3ZSp9kdP1nu+z8Y6jMPPLmDdowCNwscTFHi8PQEzF4O3CTw7We XeJki47H13wtDQcCLKHQ/l2C9dI8PLo= Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a523524e5baso604247666b.3 for ; Tue, 16 Apr 2024 16:44:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1713311092; x=1713915892; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=ajEWa5JhijpKKEUqq0ZAjRoV3oE4FFW6E5v2WulubRs=; b=vAnlXEmpYCOwgWqp8uLiArNQfzzw4fpROLwdOKDF7jOxhViyqNqWS2A3uEGhAnczeT eSTL96kWXbGK0fsWAknQgh1CfyZJc5KEESPBojuoZJKEMABuhmboCIV5w6ldFIe3hAx2 W/hzS4PwBsKByjFJlkI6xX0dFfbm0j6X+VfC5DLv6ID76ukAzCK0A9CBM2l6tK6kIDA5 /Lfnh2aWVyIQ7fpvHYgvdQjq8sndd1XJt4cCRApxmGLvA/pq8+gbC5A8ex1D5j7wM6Ow 3HRDA0oMw5Zdw48metHy4ZtfmqxK/OwlQWjh1vL0Iwc8NV/SsOR71NcEI+wFZcUIMQdA Q94g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1713311092; x=1713915892; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ajEWa5JhijpKKEUqq0ZAjRoV3oE4FFW6E5v2WulubRs=; b=XfWdQtOz52bVtFy16pwQ7MZk6KWhJzJYyL0/gTP7jNWsbqdr3NHj44vmpSwidWR6QJ g8j2pCrxJXpH1ns2JeETlHoL5hA5BZM6mlrZPGo2YiRTfkXYL0hJQBG/ObkpIeaJF1HN XbwLxxHhYTNYLmbOtTEaZB756jn7IVX2zavKYX+W1LVxzsw+n3Yqe8nwMr9d9Zn4G4mN QViLmxbNUzlI7z9Qo59B5IwQJU3rJOHPDvHPEEBxBAfwOP84uvd2SARtjwPR52MEzaOt Aglmzwc/K5F1DDV7KOko5O0/rI77++CS67zE55qTz2J8vKjoY9NEKyaAwohDp+P0knwK /X7g== X-Forwarded-Encrypted: i=1; AJvYcCVTsQ7h4l7+4DM9mPc1RmNlOiN30hf/M+a3P/wCAqIdSM4bGlH2dM6x4cLYoRvLNgGQnlpiQHTd/pddox1DSD8WuMk= X-Gm-Message-State: AOJu0YyJ7LXSEn1YpbLpoJTZh2G394MZBBg0cSGE2czanMZ7gNmV5pGh bgh9XuRVwWhgvtS2JP718JT0OT37+Zbu0JmDykxIMByqeP6D9dCuMpCX43suS37Vm47dXK/wosT rQowOo5XME56gKiRSZLPMxaFaG1T5iaczAnbG X-Google-Smtp-Source: AGHT+IGiIfoCmOCY/9AlyA7fqljbgJrDOqeyVH5Fk61NkvkGi+mLl1GnaYdc1C9nWWYegJ4uT0ZhNFcl+aWqWi94azo= X-Received: by 2002:a17:906:590b:b0:a52:42ee:4e10 with SMTP id h11-20020a170906590b00b00a5242ee4e10mr9703016ejq.8.1713311091580; Tue, 16 Apr 2024 16:44:51 -0700 (PDT) MIME-Version: 1.0 References: <20240416201335.3551099-1-souravpanda@google.com> In-Reply-To: From: Sourav Panda Date: Tue, 16 Apr 2024 16:44:39 -0700 Message-ID: Subject: Re: [PATCH v10] mm: report per-page metadata information To: Matthew Wilcox Cc: corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org, akpm@linux-foundation.org, mike.kravetz@oracle.com, muchun.song@linux.dev, rppt@kernel.org, david@redhat.com, rdunlap@infradead.org, chenlinxuan@uniontech.com, yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com, bhelgaas@google.com, ivan@cloudflare.com, pasha.tatashin@soleen.com, yosryahmed@google.com, hannes@cmpxchg.org, shakeelb@google.com, kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com, adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com, surenb@google.com, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, weixugc@google.com Content-Type: multipart/alternative; boundary="000000000000013f0c06163f53d4" X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 70A38C000C X-Stat-Signature: zyasornypprt8cj9em55m5nskth1d71e X-Rspam-User: X-HE-Tag: 1713311093-17778 X-HE-Meta: U2FsdGVkX18vFsEXQKMfHI4630YbBaYCX+7fNUiAQpcMXvQMH5RZ9CSUIn8IvQ85Ino7dCGCQP8B3NNZCLPARyp2YDvQ630fufVjaEaagrw+uUiDyvJeXxxbdz9MiS7Y++CeB8Bxm351p98ErYqAEZ4vaVlIL8LZ40yo/It7CPg2VKNzRNQnBlpFaMYm2nvnCRpIGxrdLo0Sgwj2D6FsSSFV3kM1qwzmRyqO5TRInZT2HbNn9IvI4tj7naPrrENVHsraWLV0d9/xAzptrQJctO/C+UV5My9dcgXxqhrTO8tcR2/87OWDvMmF8tPFiP6xLrvdKlfkGGBLYRHJwIKPPZenIGG2z8nGdPWLSNJLvOPMDf3HgoWlMVF6nQvJJ7DamjqUkB2lxmLbf8n7Mb9Wp/Czf+GZwMRJUG/uCSVTIvsP5dBE8Tv1vixGaDWwuJcZS/f01ZGrnlpY54lsGHnqt6Dhb3j4OAm3ny1fkLi4AVP5EyV0E9oPuBhiFyxhOmp/IiEQBcxqow28h447DixRb8BzJCKfxwGfl1oNkzJLs5laGp4Y3+zOJU1ttxH53g6wYMV4ssqB/S8n++/X1MsepSQ/VjCfTIPOVNAqHuxe3kHa+T6JAnHnCcs9M+lkhb9PfXN4fespVgb2mLEa4GeSB1ZRUgpjrTJgNmo4y6y9GJ6WMOstQhPVs5Qd0S+YeqqnTbU3FFibZBH49A9N2jzWtMjWqh+iu7nQWmlwuBqK94TtWJ4AnI0ubRKLZol3AerGq8FwXcKR0NpcfA6aHb6eQ3GZiSV17lzzEYihpYP3qeFD/8hbs3PksbFnon/OugAulCeQtRvAPyNeNjpVpt21irJWFtjJSIhuYULicnM0oYKVhQn/IXepOZ8jaXrB6kxeDy3Oat0RjUudRCG+YTDAX69/CMky7C4+8vM9vmXcnBh89Z8AOAqJp5smdSxOOYFpoBJqFu6W467qkNHe9D/ UWRNGsal gRTCaAjzAqb7miJ66GTKKHYWhpq3RWUdiuvwPhqsWAzG7+tgV0fMEMt2M7DNgYzqhNntKu7U6uY+potMROzZTqg7C7QAv1wYFG1QVpevxS9oZZx4T13ZdVVh0ezYhB9OG6Kb1YhXfqhd64fx60r4m9pEB9YbCTO20wD5D2oXJ1wyE011fxznrzo81dgFsSRqu9b+IohfLCFOemh+LU7Ne5s5UD/B8jLkJuCKXXRVZNgVYyBUzANUF+LiY4Q77EB0t8RVh5/QJcZZygCLeA0PnBsX40w7bcLLI7Ggt2yj/Rq1L0sp+/19WE6QFbI1pzeNk/KKYjP1niK4MtFnZr2cnBgJ38VIX1dM1c7uclL9w3RwtQ1IfaBcQDMaCQoB2uXh9H6TxOJhqCXo8bRdVkHtWvZaNYd73NY8eBNnBASY1p0ZyX/i4hObGgpPcF6K4jVNNpW+oWI3G0LByLS0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000172, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --000000000000013f0c06163f53d4 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Apr 16, 2024 at 1:52=E2=80=AFPM Matthew Wilcox wrote: > On Tue, Apr 16, 2024 at 08:13:35PM +0000, Sourav Panda wrote: > > +++ b/include/linux/mmzone.h > > @@ -217,6 +217,10 @@ enum node_stat_item { > > PGDEMOTE_KSWAPD, > > PGDEMOTE_DIRECT, > > PGDEMOTE_KHUGEPAGED, > > + NR_MEMMAP, /* Page metadata size (struct page and > page_ext) > > + * in pages > > + */ > > This is not how we write comments in the kernel ... > Thank you Matthew Wilcox for the review. I made a bad choice of copying the comments for NR_FILE_MAPPED. I shall add the comment to the top of the item, similar to what is done in PGDEMOTE_KSWAPD. Thanks again! --000000000000013f0c06163f53d4 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Tue, Apr 16, 2024 at 1:52=E2=80=AF= PM Matthew Wilcox <willy@infradead.org> wrote:
On Tue, Apr 16, 2024 at 08:13:35PM +0000, Sourav Pan= da wrote:
> +++ b/include/linux/mmzone.h
> @@ -217,6 +217,10 @@ enum node_stat_item {
>=C2=A0 =C2=A0 =C2=A0 =C2=A0PGDEMOTE_KSWAPD,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0PGDEMOTE_DIRECT,
>=C2=A0 =C2=A0 =C2=A0 =C2=A0PGDEMOTE_KHUGEPAGED,
> +=C2=A0 =C2=A0 =C2=A0NR_MEMMAP,=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 /* Page metadata size (struct page and page_ext)
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 * in pages
> +=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 */

This is not how we write comments in the kernel ...
Thank you Matthew Wilcox for the review. I made a bad choice o= f copying the comments for NR_FILE_MAPPED. I shall add the comment to the t= op of the item, similar to what is done in PGDEMOTE_KSWAPD. Thanks again!

=C2=A0
--000000000000013f0c06163f53d4--