On Tue, Apr 16, 2024 at 1:52 PM Matthew Wilcox wrote: > On Tue, Apr 16, 2024 at 08:13:35PM +0000, Sourav Panda wrote: > > +++ b/include/linux/mmzone.h > > @@ -217,6 +217,10 @@ enum node_stat_item { > > PGDEMOTE_KSWAPD, > > PGDEMOTE_DIRECT, > > PGDEMOTE_KHUGEPAGED, > > + NR_MEMMAP, /* Page metadata size (struct page and > page_ext) > > + * in pages > > + */ > > This is not how we write comments in the kernel ... > Thank you Matthew Wilcox for the review. I made a bad choice of copying the comments for NR_FILE_MAPPED. I shall add the comment to the top of the item, similar to what is done in PGDEMOTE_KSWAPD. Thanks again!