From: Sourav Panda <souravpanda@google.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: corbet@lwn.net, gregkh@linuxfoundation.org, rafael@kernel.org,
akpm@linux-foundation.org, mike.kravetz@oracle.com,
muchun.song@linux.dev, rppt@kernel.org, david@redhat.com,
rdunlap@infradead.org, chenlinxuan@uniontech.com,
yang.yang29@zte.com.cn, tomas.mudrunka@gmail.com,
bhelgaas@google.com, ivan@cloudflare.com,
pasha.tatashin@soleen.com, yosryahmed@google.com,
hannes@cmpxchg.org, shakeelb@google.com,
kirill.shutemov@linux.intel.com, wangkefeng.wang@huawei.com,
adobriyan@gmail.com, vbabka@suse.cz, Liam.Howlett@oracle.com,
surenb@google.com, linux-kernel@vger.kernel.org,
linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org,
linux-mm@kvack.org, weixugc@google.com
Subject: Re: [PATCH v10] mm: report per-page metadata information
Date: Tue, 16 Apr 2024 16:44:39 -0700 [thread overview]
Message-ID: <CANruzcR_pg9BmkhB_fLu6Dr_Y2dz75Xq+VbXW6HfCmKpjQe1jg@mail.gmail.com> (raw)
In-Reply-To: <Zh7k-jFRTe9RN2Lr@casper.infradead.org>
[-- Attachment #1: Type: text/plain, Size: 766 bytes --]
On Tue, Apr 16, 2024 at 1:52 PM Matthew Wilcox <willy@infradead.org> wrote:
> On Tue, Apr 16, 2024 at 08:13:35PM +0000, Sourav Panda wrote:
> > +++ b/include/linux/mmzone.h
> > @@ -217,6 +217,10 @@ enum node_stat_item {
> > PGDEMOTE_KSWAPD,
> > PGDEMOTE_DIRECT,
> > PGDEMOTE_KHUGEPAGED,
> > + NR_MEMMAP, /* Page metadata size (struct page and
> page_ext)
> > + * in pages
> > + */
>
> This is not how we write comments in the kernel ...
>
Thank you Matthew Wilcox for the review. I made a bad choice of copying the
comments for NR_FILE_MAPPED. I shall add the comment to the top of the
item, similar to what is done in PGDEMOTE_KSWAPD. Thanks again!
[-- Attachment #2: Type: text/html, Size: 1225 bytes --]
prev parent reply other threads:[~2024-04-16 23:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-16 20:13 Sourav Panda
2024-04-16 20:52 ` Matthew Wilcox
2024-04-16 23:44 ` Sourav Panda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANruzcR_pg9BmkhB_fLu6Dr_Y2dz75Xq+VbXW6HfCmKpjQe1jg@mail.gmail.com \
--to=souravpanda@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhelgaas@google.com \
--cc=chenlinxuan@uniontech.com \
--cc=corbet@lwn.net \
--cc=david@redhat.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=ivan@cloudflare.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=muchun.song@linux.dev \
--cc=pasha.tatashin@soleen.com \
--cc=rafael@kernel.org \
--cc=rdunlap@infradead.org \
--cc=rppt@kernel.org \
--cc=shakeelb@google.com \
--cc=surenb@google.com \
--cc=tomas.mudrunka@gmail.com \
--cc=vbabka@suse.cz \
--cc=wangkefeng.wang@huawei.com \
--cc=weixugc@google.com \
--cc=willy@infradead.org \
--cc=yang.yang29@zte.com.cn \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox