From: David Herrmann <dh.herrmann@gmail.com>
To: David Rientjes <rientjes@google.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Wanpeng Li <liwanp@linux.vnet.ibm.com>,
Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
Vladimir Cernov <gg.kaspersky@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Hugh Dickins <hughd@google.com>, linux-mm <linux-mm@kvack.org>
Subject: Re: [PATCH] mm/madvise: fix WILLNEED on SHM/ANON to actually do something
Date: Fri, 23 May 2014 23:49:28 +0200 [thread overview]
Message-ID: <CANq1E4SfL=c_ZgGwRkQWoEHEWF4q8-DVB+RsQfo6CqGQc9MoZA@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.2.02.1405231353080.13205@chino.kir.corp.google.com>
Hi
On Fri, May 23, 2014 at 10:55 PM, David Rientjes <rientjes@google.com> wrote:
> On Fri, 23 May 2014, David Herrmann wrote:
>
>> diff --git a/mm/madvise.c b/mm/madvise.c
>> index 539eeb9..a402f8f 100644
>> --- a/mm/madvise.c
>> +++ b/mm/madvise.c
>> @@ -195,7 +195,7 @@ static void force_shm_swapin_readahead(struct vm_area_struct *vma,
>> for (; start < end; start += PAGE_SIZE) {
>> index = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
>>
>> - page = find_get_page(mapping, index);
>> + page = find_get_entry(mapping, index);
>> if (!radix_tree_exceptional_entry(page)) {
>> if (page)
>> page_cache_release(page);
>
> This is already in -mm from Johannes, see
> http://marc.info/?l=linux-kernel&m=139998616712729. Check out
> http://www.ozlabs.org/~akpm/mmotm/ for this kernel.
Didn't check -mm, sorry. Thanks for the links!
David
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2014-05-23 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-23 12:12 David Herrmann
2014-05-23 20:55 ` David Rientjes
2014-05-23 21:49 ` David Herrmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANq1E4SfL=c_ZgGwRkQWoEHEWF4q8-DVB+RsQfo6CqGQc9MoZA@mail.gmail.com' \
--to=dh.herrmann@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=gg.kaspersky@gmail.com \
--cc=hannes@cmpxchg.org \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=liwanp@linux.vnet.ibm.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=rientjes@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox