From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96269CA9EB7 for ; Mon, 21 Oct 2019 15:43:38 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B79C214AE for ; Mon, 21 Oct 2019 15:43:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="kSbOVSxR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B79C214AE Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 107AC6B0006; Mon, 21 Oct 2019 11:43:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0912C6B0008; Mon, 21 Oct 2019 11:43:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E9AA76B000A; Mon, 21 Oct 2019 11:43:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0104.hostedemail.com [216.40.44.104]) by kanga.kvack.org (Postfix) with ESMTP id C4C206B0006 for ; Mon, 21 Oct 2019 11:43:37 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 464325825 for ; Mon, 21 Oct 2019 15:43:37 +0000 (UTC) X-FDA: 76068211674.20.party38_59a4734bcfa4d X-HE-Tag: party38_59a4734bcfa4d X-Filterd-Recvd-Size: 5736 Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Mon, 21 Oct 2019 15:43:35 +0000 (UTC) Received: by mail-oi1-f193.google.com with SMTP id i185so11415840oif.9 for ; Mon, 21 Oct 2019 08:43:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cnXjVYkeWXq+gubvSOjcYVnZzqsBIZ+DNJdYhPS5/D8=; b=kSbOVSxROO2ODHZOo0AzN65grokopehSUbmYsECSJU6VZS+Nr1cw7LV6r4iAcc7N6Q wzllLP+X0DveM8FqCCuVinvCaP3XnL9YCqdDKRLIgt+rSBWXCJrhGRJSCwEj6KftUioO 0G2RZFY6J41AyIPK9sMmrPMRorNfiZZJTp5ufyuGPVmC6KiDrg62GQx+BfeYcb0Dnk00 e/caau408WrMpaj5r51qcXRJcyfgpkFW4QXzy07SHQAOJOIGjTVSNPCX9FqYnJLFZw+a lxjcEwL/AFpSmr/jX73HRWC155IV+n6XsiPCIITIqBSlVnEH5R1A+3H+uOSRpVi6DTHo g2Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cnXjVYkeWXq+gubvSOjcYVnZzqsBIZ+DNJdYhPS5/D8=; b=Sld++fLDkHDy1FD6AP+pyedxDpUrRjDF+U9joV3rFqLBNSN760v1Aox/wadwKsPdTp Xp33uFU5r55qePe/hfTmTGKnByYJC3wYSCuZQthUGdKn7ghTof+42c/9WsMMjzAkGiF0 NAdAJ1ik6YeDW1GWbNv2131dED5DFUnL0/oROTsORTWmiU+b9MSOqbbDp4B9r06ya8rj X0fSsDC3dgPmfjq6QowZ5cz1WobEmrZ+rz9n/FNZiY88/eoq1FZCtkC8+3UVMzm7tWa1 WGD2D65lhX0m8dImyug/SLToMhaPEJF9J6egz4wIzBWkzx2C8u06lZRuDIJPEXG5Z64s DSAQ== X-Gm-Message-State: APjAAAXdyHRLsASRszVECkdjPcQNezpiqxp0vs4d0EPovxmz7LjvXAsu SRMH1kIeF3mj13+pXSCLW6TODUqYvr3MAjXdUB6S/w== X-Google-Smtp-Source: APXvYqxc1yCRq3k+cvMu1sAucXV2pLfdg+Ismk5+9IUGxVHljKC2H3cX5Rq52uV7mrAoht13w5nwv0u1z0tu95TtZcU= X-Received: by 2002:aca:f492:: with SMTP id s140mr20094795oih.83.1571672614698; Mon, 21 Oct 2019 08:43:34 -0700 (PDT) MIME-Version: 1.0 References: <20191017141305.146193-1-elver@google.com> <20191017141305.146193-3-elver@google.com> In-Reply-To: From: Marco Elver Date: Mon, 21 Oct 2019 17:43:22 +0200 Message-ID: Subject: Re: [PATCH v2 2/8] objtool, kcsan: Add KCSAN runtime functions to whitelist To: Dmitry Vyukov Cc: LKMM Maintainers -- Akira Yokosawa , Alan Stern , Alexander Potapenko , Andrea Parri , Andrey Konovalov , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Boqun Feng , Borislav Petkov , Daniel Axtens , Daniel Lustig , Dave Hansen , David Howells , "H. Peter Anvin" , Ingo Molnar , Jade Alglave , Joel Fernandes , Jonathan Corbet , Josh Poimboeuf , Luc Maranget , Mark Rutland , Nicholas Piggin , "Paul E. McKenney" , Peter Zijlstra , Thomas Gleixner , Will Deacon , kasan-dev , linux-arch , "open list:DOCUMENTATION" , linux-efi@vger.kernel.org, "open list:KERNEL BUILD + fi..." , LKML , Linux-MM , "the arch/x86 maintainers" Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 21 Oct 2019 at 17:15, Dmitry Vyukov wrote: > > On Thu, Oct 17, 2019 at 4:13 PM Marco Elver wrote: > > > > This patch adds KCSAN runtime functions to the objtool whitelist. > > > > Signed-off-by: Marco Elver > > --- > > tools/objtool/check.c | 17 +++++++++++++++++ > > 1 file changed, 17 insertions(+) > > > > diff --git a/tools/objtool/check.c b/tools/objtool/check.c > > index 044c9a3cb247..d1acc867b43c 100644 > > --- a/tools/objtool/check.c > > +++ b/tools/objtool/check.c > > @@ -466,6 +466,23 @@ static const char *uaccess_safe_builtin[] = { > > "__asan_report_store4_noabort", > > "__asan_report_store8_noabort", > > "__asan_report_store16_noabort", > > + /* KCSAN */ > > + "__kcsan_check_watchpoint", > > + "__kcsan_setup_watchpoint", > > + /* KCSAN/TSAN out-of-line */ > > There is no TSAN in-line instrumentation. Done @ v3. > > + "__tsan_func_entry", > > + "__tsan_func_exit", > > + "__tsan_read_range", > > There is also __tsan_write_range(), right? Isn't it safer to add it right away? Added all missing functions for v3. Many thanks for the comments! > > + "__tsan_read1", > > + "__tsan_read2", > > + "__tsan_read4", > > + "__tsan_read8", > > + "__tsan_read16", > > + "__tsan_write1", > > + "__tsan_write2", > > + "__tsan_write4", > > + "__tsan_write8", > > + "__tsan_write16", > > /* KCOV */ > > "write_comp_data", > > "__sanitizer_cov_trace_pc", > > -- > > 2.23.0.866.gb869b98d4c-goog > >