From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27A51C433F5 for ; Fri, 22 Apr 2022 10:38:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 831206B0074; Fri, 22 Apr 2022 06:38:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DF9D6B0075; Fri, 22 Apr 2022 06:38:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CE896B0078; Fri, 22 Apr 2022 06:38:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.hostedemail.com [64.99.140.25]) by kanga.kvack.org (Postfix) with ESMTP id 5EE576B0074 for ; Fri, 22 Apr 2022 06:38:26 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay11.hostedemail.com (Postfix) with ESMTP id 2A9EC81029 for ; Fri, 22 Apr 2022 10:38:26 +0000 (UTC) X-FDA: 79384165812.18.1A6A475 Received: from mail-yb1-f170.google.com (mail-yb1-f170.google.com [209.85.219.170]) by imf09.hostedemail.com (Postfix) with ESMTP id F390B140005 for ; Fri, 22 Apr 2022 10:38:23 +0000 (UTC) Received: by mail-yb1-f170.google.com with SMTP id v59so826314ybi.12 for ; Fri, 22 Apr 2022 03:38:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CsjTxEEAvysZcrGQCgnoFVKXKLqNd9huKoE9KzmmMI0=; b=svVpZpsCBwi05D6HGuAV6VNl0TnNbi1By/r9OWleeVotyMkYhrsbqEJDIDSdPkREjz 3362oZIRJFtkLcg5aEJpF3n1xd6ipXFEq/j48MVsozpuWi4XWg+JUCI54KpRFm6k9fuH iuiYLtukeDIzvPYOnFvdeD/Dh3cWMScn6ijy/wJ9dMAM+Ai2YRgE3cPtVrKFn8pBOMiS p0gTaif83J768pmvmDZo9cf506rFJd/SfdoLFgYs7uAXbxxuhhAh95UKsS8QPEpG0lM9 hAwDNyeI/sHaoL/fQQkj7rT73VhtZtRoFC2YjZupOfhfwmA9IsZitPApsKPfei2M4NAh nktA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CsjTxEEAvysZcrGQCgnoFVKXKLqNd9huKoE9KzmmMI0=; b=FMZSOB1MtmIHnuJQBkW6YuidOD/8JA2ODH9wXGVLL31VVciOUfnx98EFNL3vazn9Nn XVG7Qb92hJpT3cR6tjTZmeqYcsg25t0LZK61ySBUSz4XWO47PotofQ2FMjmRCQagOFFU 6s68h/RHozipCXW1vllzaM71dNxzb29D8Amnzl65BTHtZD+8NWhxzYD0waSycCyTWmes z0xDTsX7SvTYtEI1/+ysMNIPVO9unrwOpDGBe6cydlS0Nch+KBITwLa8i3EIERzqZ8dM qSqWjtES7BlP9T7akXG9AslyZCleuDkz/m3yvGCwFQE1RbjvSNnhlzBDrnLgDnUId9HY p+PA== X-Gm-Message-State: AOAM533Ik1iCO4UzWWeI7ycXsXAeWVbHPTPSxGReLSm55ZBcc61tRpuW EdAASeZrSyBYsQOuUecpUuqV8zcul9itqNyL7j5+fQ== X-Google-Smtp-Source: ABdhPJwoWm73p/RTkzfbVpkviY0RnM3o6+33FT79Cu+M02kBxAUNqMYZoyFQVWm/BUVU98mJ8P1OBCoMWhjNFhY8R9Y= X-Received: by 2002:a25:9b85:0:b0:63d:ad6c:aae8 with SMTP id v5-20020a259b85000000b0063dad6caae8mr3527563ybo.609.1650623904827; Fri, 22 Apr 2022 03:38:24 -0700 (PDT) MIME-Version: 1.0 References: <000000000000f46c6305dd264f30@google.com> In-Reply-To: From: Marco Elver Date: Fri, 22 Apr 2022 12:37:48 +0200 Message-ID: Subject: Re: [syzbot] WARNING in __kfence_free To: Muchun Song Cc: syzbot , akpm@linux-foundation.org, dvyukov@google.com, glider@google.com, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Roman Gushchin , cgroups@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: F390B140005 X-Stat-Signature: geimi7ifmnr59myr71umx6h5c7irucwh Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b=svVpZpsC; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf09.hostedemail.com: domain of elver@google.com designates 209.85.219.170 as permitted sender) smtp.mailfrom=elver@google.com X-HE-Tag: 1650623903-586444 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 22 Apr 2022 at 07:09, Muchun Song wrote: > > On Thu, Apr 21, 2022 at 11:12:17AM +0200, Marco Elver wrote: > > On Thu, Apr 21, 2022 at 01:58AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit: 559089e0a93d vmalloc: replace VM_NO_HUGE_VMAP with VM_ALLO.. > > > git tree: upstream > > > console output: https://syzkaller.appspot.com/x/log.txt?x=10853220f00000 > > > kernel config: https://syzkaller.appspot.com/x/.config?x=2e1f9b9947966f42 > > > dashboard link: https://syzkaller.appspot.com/bug?extid=ffe71f1ff7f8061bcc98 > > > compiler: aarch64-linux-gnu-gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > > userspace arch: arm64 > > > > > > Unfortunately, I don't have any reproducer for this issue yet. > > > > > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > > > Reported-by: syzbot+ffe71f1ff7f8061bcc98@syzkaller.appspotmail.com > > > > > > ------------[ cut here ]------------ > > > WARNING: CPU: 0 PID: 2216 at mm/kfence/core.c:1022 __kfence_free+0x84/0xc0 mm/kfence/core.c:1022 > > > > That's this warning in __kfence_free: > > > > #ifdef CONFIG_MEMCG > > KFENCE_WARN_ON(meta->objcg); > > #endif > > > > introduced in 8f0b36497303 ("mm: kfence: fix objcgs vector allocation"). > > > > Muchun, are there any circumstances where the assumption may be broken? > > Or a new bug elsewhere? > > meta->objcg always should be NULL when reaching __kfence_free(). > In theory, meta->objcg should be cleared via memcg_slab_free_hook(). > > I found the following code snippet in do_slab_free(). > > /* memcg_slab_free_hook() is already called for bulk free. */ > if (!tail) > memcg_slab_free_hook(s, &head, 1); > > The only posibility is @tail is not NULL, which is the case of > kmem_cache_free_bulk(). However, here the call trace is kfree(), > it seems to be impossible that missing call memcg_slab_free_hook(). Fair enough - we can probably wait for the bug to reoccur on another instance, and until then assume something else wrong. What is slightly suspicious is that it only occurred once on a QEMU TCG arm64 MTE instance. Thanks, -- Marco