From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 140EBD132B4 for ; Mon, 4 Nov 2024 12:17:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 679396B0088; Mon, 4 Nov 2024 07:17:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 629156B008A; Mon, 4 Nov 2024 07:17:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4F10D6B008C; Mon, 4 Nov 2024 07:17:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 30FFF6B0088 for ; Mon, 4 Nov 2024 07:17:28 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D29DA81B1A for ; Mon, 4 Nov 2024 12:17:27 +0000 (UTC) X-FDA: 82748312346.04.B9446FA Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by imf19.hostedemail.com (Postfix) with ESMTP id 2C69C1A000D for ; Mon, 4 Nov 2024 12:16:45 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Pz3qfrcj; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1730722425; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5kQZWCzIhxI9ZXfcfMMtM58/ZtX8V/ECMx6VB6xWUdw=; b=yZby2MYmPRVKS2tBDS1T6e5b2tHW+5oDPR5RuXB0y8rktQEf90z1RheBwv1tWoNKS9AlsX GlQNt6W35BKaaaUZUsLnGH/y8PvchiHcJCIQQauitVJbwZKbQFrljXvE1uaVCIhJNsgOp5 ggfAQK9YK38t9I0HPoGaV3LNi0S/97Q= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=Pz3qfrcj; spf=pass (imf19.hostedemail.com: domain of elver@google.com designates 209.85.214.178 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1730722425; a=rsa-sha256; cv=none; b=QtGnuWDecoRclEQRO/GUll4lvmwLbzE8Nww+9FErvZ7NK28bk+GvCn+hsodkhW5xjdk4sJ EnkwDqndz+IIEQizrWu38qFIk/u9nSjHUYf/ZkcDkovKd3TX66GahFor7GnEPeURcm58DY N54swES5w0PmCV3jIZe02xNOO9w0G2o= Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-20ca388d242so39481465ad.2 for ; Mon, 04 Nov 2024 04:17:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1730722645; x=1731327445; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5kQZWCzIhxI9ZXfcfMMtM58/ZtX8V/ECMx6VB6xWUdw=; b=Pz3qfrcjoV64F1yrdfKueRrzj3v1MrcCJFBtJRn6x6JttoezgmuM06VzJGy4zPxcmk lpQwJBkFFP4TN5B7keEo0LUgjEtQ3LVx1/PtoTWOWraKTjimCLBF5bNxV2R0PtJpuH8q Fu0qaB2PdtMWtwMC5kiqWk1YQ33pZ3qPcCX0U40T26gR+UOJdMAHpKaD6AbOaBaZSGhN JPTl9zJtoSMezwZ9PdBnA0I9XHoMFIhTLwjJULpglJWI+5RzJF26inJZxFeMnOOEu6om 0waWJUN51TmXi3r//9R4uBnOPOaI7d0TvF8Vzf1mjltBTCRR7xboULPjakzhVS3pOFGq mjTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730722645; x=1731327445; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5kQZWCzIhxI9ZXfcfMMtM58/ZtX8V/ECMx6VB6xWUdw=; b=atHTuggDBh50eim/asFfjgUS0jgji9E4Nrp7pd58/kWWjtg3RtnfXAOvx7RxCOBO9X wLZSjEnpC/E6rEgJblGpY0JJBmAWIkoLcEJfmrOESeUKDIkvR/+LqJX6FTUkdwIw0Alv Ou0ba6iO+kNfEZfzMrsvCGT+UZxSD2w4rIyx3kBpQPe9ge1OtP1vbsqFVA3WluYYYhrr swpOREC8bmHuKtXHQVH+RG2TXhKbcODp8EWxURnr3F90BUiM4BJcOaOv31mF95JLunik 6CnGbn9eqYselaL/mFjtg5d/PL2HxKvrXTirySb7BzimJQAY1hdxFBloSPpxfPMeWxxN f54A== X-Forwarded-Encrypted: i=1; AJvYcCWLnDJo0X+BMvYFvBb8OUpwftZ98xn5YKtGgb3IJ0z6jUfCqtyRQHhO1lxvpAcYuv6c1+1pK0/VBw==@kvack.org X-Gm-Message-State: AOJu0YxlkLQaDBF6HNubq7VX1NEf4BgMRdxXSFovlyFp9rE9d5Dt7Art vIXk/Y5VpUiiHjxNHR16HvbFhZJEVqHQE5Mx/N/f6vN0/dCaq0wBDMtP7WV6mIf/LD6gXIpF0JY KAzDmqiyeuSpa/Ja1tEmldivdjqQUdwLllmjx X-Google-Smtp-Source: AGHT+IHvf51l5Fhl0nIdVQ+m8T/XcjQYNb/wYNbXZ2oFtF4pT5gjR2FO3JZi9f58vxAaXuMVA2M5H3KK5yq06FN+nBo= X-Received: by 2002:a17:902:e884:b0:20b:3f70:2e05 with SMTP id d9443c01a7336-2111afd6c99mr175024815ad.41.1730722644347; Mon, 04 Nov 2024 04:17:24 -0800 (PST) MIME-Version: 1.0 References: <67275485.050a0220.3c8d68.0a37.GAE@google.com> <20241104114506.GC24862@noisy.programming.kicks-ass.net> In-Reply-To: <20241104114506.GC24862@noisy.programming.kicks-ass.net> From: Marco Elver Date: Mon, 4 Nov 2024 13:16:48 +0100 Message-ID: Subject: Re: [syzbot] [mm?] WARNING: locking bug in __rmqueue_pcplist To: Peter Zijlstra Cc: Vlastimil Babka , syzbot , Liam.Howlett@oracle.com, akpm@linux-foundation.org, jannh@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, lorenzo.stoakes@oracle.com, syzkaller-bugs@googlegroups.com, Sebastian Andrzej Siewior , Andrey Konovalov , kasan-dev , Andrey Ryabinin , Alexander Potapenko , Waiman Long , dvyukov@google.com, vincenzo.frascino@arm.com, paulmck@kernel.org, frederic@kernel.org, neeraj.upadhyay@kernel.org, joel@joelfernandes.org, josh@joshtriplett.org, boqun.feng@gmail.com, urezki@gmail.com, rostedt@goodmis.org, mathieu.desnoyers@efficios.com, jiangshanlai@gmail.com, qiang.zhang1211@gmail.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, bsegall@google.com, mgorman@suse.de, vschneid@redhat.com, tj@kernel.org, cl@linux.com, penberg@kernel.org, rientjes@google.com, iamjoonsoo.kim@lge.com, roman.gushchin@linux.dev, 42.hyeyoo@gmail.com, rcu@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 2C69C1A000D X-Stat-Signature: 8cwgwu5g3zuagmqs58rqyfef7e9uu7jf X-Rspam-User: X-HE-Tag: 1730722605-884203 X-HE-Meta: U2FsdGVkX193nAkbUCCQRis/ehAu8i13emHR1Y2+KE1kEHIUkmtyTXLk1Py7rN4iImdKKiY6TZanefXSbxmlV5pISPCfho/xvyflU1UQ3j46okpwYZ4JRl8vvtc9JGbm5HcEmw+hR5WuGVd+zxngRuXTznz1WaXb15qFRPYe9UBTCg4uqp5rb2rHJsB9PWXavTaVy+hCFJHUaHLKJf1MyGRlxjXxdMlriIR6rl1HGTZAix0oafF//USuDaxb/fpXi0dplVchOvSWeoe4ZAWXqZmSzTNky0XoD6D5NFyyZqErcMSZdpSJbAKkuQHGP9o/nCV8xgm5IzE1P8XiX1y9rzElYTHLjlmE8VL/ADIFDwQPRa36wNctOhsBmcCxdvMwQSS0Jc8Los24EuNkIyrjgFZnyVMrcYfraeiOGY98s0u0cJJDkUsxGesuo224RKQ+zrjkcXJHmRHoGO3w6r57OFKLxYJ08Rl7g0TiVWUAG2RIGHXeA97iSHaZ0vgPVBAvo87dLD6y9ZgF2UYBUYz/Q7UFNYXJHz+fPGZjHQC7KiR2/gFjsKjFl2sQS4icjEUDHGSdAQgKS5TB5JRnqGSC2/ixVZLEL4/MOskwTbdtqcLe1+ZTrdswI8eatSw9ZLahmJMzOzCuVsl75f6VPfPEXrW8yiVAhGKrdaLhb9CAU78bt9mZ3by6urtcbez7a30tbhqCU9P4qYwj5vIX/IHNSSa0FCufiEcUXeB9v9cbycM/eY2z2Bo/NCvQa9ttlMMOb6wJlWlS1ElwNjSCbb+ZzY+3dquQa25JTe1crGRRJKf27IXU1F/QSQ4Enfghf6MdDHGhYQ2VYSj9GMPdWcEH0srpjHYfLZejDiAH4dn5uee/c4VS2CkjWT6kxCq4GSmS4itmF7fV+BqvAoGrAG67k5CuSteRIUuAgCS/kgVGdjimwzIUz8l3ueSbbDC6TrsK0bkFxmvdgtMUEUY7K/O uz8Txbvd z70ePM3BFCAU5h9eTk8eUNcNdzaRrN80qCtorw/uvRJLHcmm9yjjGq/eEORcrNW7Ad32CoF4Gocu2uiHgTM+06F+OwnG42Hy9uDk6B+aNp/qiAB9Ghbg3Ae9xGqrq7hHJIEJhBEYtjmkfGeue5P+jgQf9Yap+T+9GLGL6qUAZFgHOHsxaW43ZF4nc9ZUQTxkgXLrU8G8Zcp7KkHiALZX9yGGqBVWVlqGDA7LemJDGQJimpsePSOhjN5j58UQt2xlvrc2wWVfLi7v7d7OsusmeNVvgeOyHuqdRO19657DlKrUsTcx9xiDSjBL6TZyWXSZMP086jfUwrJBm+CidVosEXWYFCv/5I8Pa8AVytMsMycfUCPVUzal11nFTwkUWjyXbACjfhh5oYBc4AHwxHHeTtKCuBZo0+hNP89PiEYjsAC9UlFzpTTVuVbZua4PAVwiiqzmrfnwdVjHEPTJpl/vc7Ag6ySa4oP0C4Wj9oPu/WLEFIfE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, 4 Nov 2024 at 12:45, Peter Zijlstra wrote: > > On Mon, Nov 04, 2024 at 12:25:03PM +0100, Vlastimil Babka wrote: > > On 11/4/24 12:11, Vlastimil Babka wrote: > > > >> __alloc_pages_noprof+0x292/0x710 mm/page_alloc.c:4771 > > >> alloc_pages_mpol_noprof+0x3e8/0x680 mm/mempolicy.c:2265 > > >> stack_depot_save_flags+0x666/0x830 lib/stackdepot.c:627 > > >> kasan_save_stack+0x4f/0x60 mm/kasan/common.c:48 > > >> __kasan_record_aux_stack+0xac/0xc0 mm/kasan/generic.c:544 > > >> task_work_add+0xd9/0x490 kernel/task_work.c:77 > > > > > > It seems the decision if stack depot is allowed to allocate here depends on > > > TWAF_NO_ALLOC added only recently. So does it mean it doesn't work as intended? > > > > I guess __run_posix_cpu_timers() needs to pass TWAF_NO_ALLOC too? > > Yeah, or we just accept that kasan_record_aux_stack() is a horrible > thing and shouldn't live in functions that try their bestest to > locklessly setup async work at all. > > That thing has only ever caused trouble :/ > > Also see 156172a13ff0. > > How about we do the below at the very least? I'd be in favor, it simplifies things. And stack depot should be able to replenish its pool sufficiently in the "non-aux" cases i.e. regular allocations. Worst case we fail to record some aux stacks, but I think that's only really bad if there's a bug around one of these allocations. In general the probabilities of this being a regression are extremely small - same as I argued back in https://lore.kernel.org/all/20210913112609.2651084-1-elver@google.com/