From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAC75C46CCD for ; Thu, 21 Dec 2023 20:08:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 641686B0081; Thu, 21 Dec 2023 15:08:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FB0C6B009D; Thu, 21 Dec 2023 15:08:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46A7C6B00A7; Thu, 21 Dec 2023 15:08:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 316B56B0081 for ; Thu, 21 Dec 2023 15:08:00 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0691012068C for ; Thu, 21 Dec 2023 20:08:00 +0000 (UTC) X-FDA: 81591911520.14.A327F0C Received: from mail-oa1-f45.google.com (mail-oa1-f45.google.com [209.85.160.45]) by imf21.hostedemail.com (Postfix) with ESMTP id EEC8B1C0016 for ; Thu, 21 Dec 2023 20:07:57 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OFPhFosM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of elver@google.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1703189278; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=utqNK2Z5ebr5Ah9is9CZfM+/3gvjCU4Z0H/FEO7/fZM=; b=7mhURTazVOFyYiqExG2LyrkL+3qdT+ovTntsUHaTjCTJCq8Ao0D1o7cygMmrZNo0A6rEgv cLVZi+h6b6ZI1lUs8jFANAUaflGVbTN8+lign2T6wmgRTzz58G+nQ0HqvxtsqoSN7Iz+2e 0klJ1tukvfCOYkRwwCfWGmDVmbnpb4k= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=OFPhFosM; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf21.hostedemail.com: domain of elver@google.com designates 209.85.160.45 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1703189278; a=rsa-sha256; cv=none; b=ouZCpbiJs3IcZHjlFnmy79uIHKiYjKYy7fIQi0f1KwxJjr33a4jOlQCRk1gg00zHEymsIN EsGCP8o0e8EYilrKj5dyqLNP1Rawll2M/oOFazbnBCYjfwroXC4ybrJFg44HGdbWDA3y8R ZY1pGsLVJQTwOQbuF5+zT629j0GUPcI= Received: by mail-oa1-f45.google.com with SMTP id 586e51a60fabf-2041c292da8so711946fac.3 for ; Thu, 21 Dec 2023 12:07:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1703189277; x=1703794077; darn=kvack.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=utqNK2Z5ebr5Ah9is9CZfM+/3gvjCU4Z0H/FEO7/fZM=; b=OFPhFosMJ0zhkVmQ4YGgccsC23p9oOvvUIbQ1t9c1Q1XfkxOAItOdANwEEKjg6XATU OpwjySOji+L1/yhpS8J+BlYG1UidAnQ+cd3U0knk3HWXLJ99RHe6l/DFX4LGKmynxBMW LT9bZLI/aKGGmhA4KXcGExWBIbG2CWv/7zMVyXb9fS9wL0vXPXf+sMlbz9SRxafDp47Y 4BUC/Pl9L6v2uAK5AMrBwOss7bbfjEOiazxfIsRBsB24DtQDilDNFgpsQ+rT6VhXGzeS ruQ8tDRFR9d+3040AcVAPQAgCcKCTW0ha/wgVTV9YJMk9BWkEraMM9GgsIZEUFvA21l9 fsOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703189277; x=1703794077; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=utqNK2Z5ebr5Ah9is9CZfM+/3gvjCU4Z0H/FEO7/fZM=; b=k6/XjfsHQsX+ouMdr4XsVWL6BPB4XiSDT1DDPTt1cLIbXZWZqTKmxNP0tXHl+R6Dac 2O1i3tRd0AUfEjenUgmYdmfXmhBF7Y5PaMPnRNOuVI/kcQdmhcYKSvxz/mZg/uLdod3i SHAOySo3aDJMcHCiN7Jznkw6GoYbhKmyQUKvUKV40XVIWzSsiDy9hIBzuz1r1HU99tgg AEi8fdiI6+xiEDLcMtl8v4CBytcP3TS6nHAgkU93BpAXEabtNJ4JP2Q6s1LXrGGJMauS /VqC2fam/1w2Kqe/fLAGd6OR1GyxIaDeJdo02fGm9I2LS5f7VnGHRBzK5FubEz6nn19b OWWw== X-Gm-Message-State: AOJu0YzemKK8B9qR5Fm60rTPDX3Gxpz3nPR/tuCWZgMD48XBHzCZmRPA 5vSU6Q/VcQD5jhL0RptHP5oA0M4ZIhs2W2Za8B1RsC9XQ/Sz X-Google-Smtp-Source: AGHT+IGpMLVUaZzsKBY0xBIQjvSt9huCNWw3hwHRpN3+6T2gMLLFvYaByZqI8RdgR888zFFk3Fjw5FTebhgaEGINsKU= X-Received: by 2002:a05:6870:a192:b0:203:7cb2:35 with SMTP id a18-20020a056870a19200b002037cb20035mr406025oaf.60.1703189276982; Thu, 21 Dec 2023 12:07:56 -0800 (PST) MIME-Version: 1.0 References: <20231221180042.104694-1-andrey.konovalov@linux.dev> In-Reply-To: <20231221180042.104694-1-andrey.konovalov@linux.dev> From: Marco Elver Date: Thu, 21 Dec 2023 21:07:20 +0100 Message-ID: Subject: Re: [PATCH mm] kasan: Mark unpoison_slab_object() as static To: andrey.konovalov@linux.dev Cc: Andrew Morton , Andrey Konovalov , Alexander Potapenko , Dmitry Vyukov , Vlastimil Babka , kasan-dev@googlegroups.com, Nathan Chancellor , Tetsuo Handa , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: EEC8B1C0016 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wfhc38bjctc1xxw98g87ys16ix4wc1bd X-HE-Tag: 1703189277-850105 X-HE-Meta: U2FsdGVkX1/T0c9EoRmiUJpBOhIK9hCCx2n0DwnOV71ZH2H3gRS5cUhDY0RM04HQ6UfNpBFbcYXLWZFjQMHpZId7dgUgaLEz3AunXClGkRu2fj6wPsEguZ6csEsrSzSlpox43LQF/y84tpcZa+IeQQr+nndDp3RE24dZEcJ/sm1EyFYFZh1K3iNlC9+R36pY9YH7xoIF5tx+PyFkpXtC9FggWrr8DEPlkM6BwDfZaZ4Ef8wTln0d6rOKHUKOv85IOegb7+2n0ZN/56jshwoZGip8Ba5GqIhX3YVCv61kpLfZij8wNq0H+RqLPSq9A7ih8a7N9iWarVcR7JcVR5RbxDuNYP6mqTrEIs44LE56MNPgYsAQ19EZgQ+D+rvZ8MmGYJCNXq7T/F3ds3ifQw3sgCnqMNZywgTvfNJemh7925OJpCJc7KE84kpr8SJjEav8y50Ci2cuZYveoVLrtt2zoO+Ino9rAD+O9iI0juY8e3BU14JrfuWNgP1gGnUzpoCZx2I3NXU57gjJQ7NZUnaKPBQ9z37o4VhJucX6moIt1ZBkDvvzdmC+UoknCSDC2y+BUrnNJiC6cun2MePRc0/bSrg/Bv6WwnjJsQdnd6M8lLTQ7WGvSLD4BjUDI/uCob8xVQ72lLAvLxQo2mFQP/q9IO9pNUmkqM4E3ZFLoqbrM+RZbzeYag1JaHyWDiC30/inB6ybkOsk0pAjNFt0p2Nve7lR83ZXbdQjayRiPQcG3zeCX/vHsywy/y0rvtE/9Ef400OmelAG9iKbbMNChr1X/+5cOv106mIR+d8bWlDMkdcKgK/RjwHZug8UF1JgASPSWvPgFwuGAecJBrRdA6QRXczH+4ng4Zl4BcmdzNo280EiKX+QRNbURK4syJIf1a51nx00J8TB14aOgwQ82p02J70iOP27eQ3wm81oZLcSrxmnM4aoEHTqi3StnpvMh5vgxHQfSX3j0QVGfUMBjtK eVt8hX7y s1mh8aoDWpBNYZ1g5nROc7tN55dbo1x/e8QuFKinaIgLLbQEComBIfjCe/8lqBfhbn+LowVXNMMEInegWQ6Ig+Q5FVtbTE5f5F5tmJk9m4jp9JchrCUxAAg51Ok8Ce5B8CviAoRbxnWE574CYlHKb41xxi6FF2monp+D8/s/DKNJd0t3gqym7x+5PGT7zJSbT/gG5LpKV2Kg+7cIx7qJ89AMAGZrAl34EowFLNYzLSHIIE5BMsWYqlMstSQsSTLcbTM4l4mjACvd4o6gH3XGQwnKGGMY8wOaxMBK6wLQfXVzvF5I9ycpn7p/nIGTgW+1+LQIBL0ZMDEMKDkzqRSgbJ0v9eFIovdTyFpwg7KzMJKCeSNY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 21 Dec 2023 at 19:00, wrote: > > From: Nathan Chancellor > > With -Wmissing-prototypes enabled, there is a warning that > unpoison_slab_object() has no prototype, breaking the build with > CONFIG_WERROR=y: > > mm/kasan/common.c:271:6: error: no previous prototype for 'unpoison_slab_object' [-Werror=missing-prototypes] > 271 | void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, > | ^~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > Mark the function as static, as it is not used outside of this > translation unit, clearing up the warning. > > Fixes: 3f38c3c5bc40 ("kasan: save alloc stack traces for mempool") > Signed-off-by: Nathan Chancellor > Signed-off-by: Andrey Konovalov Reviewed-by: Marco Elver > --- > > Changes v1->v2: > - Mark as "static inline" instead of just "static". > --- > mm/kasan/common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/mm/kasan/common.c b/mm/kasan/common.c > index ebb1b23d6480..f4255e807b74 100644 > --- a/mm/kasan/common.c > +++ b/mm/kasan/common.c > @@ -277,8 +277,8 @@ void __kasan_kfree_large(void *ptr, unsigned long ip) > /* The object will be poisoned by kasan_poison_pages(). */ > } > > -void unpoison_slab_object(struct kmem_cache *cache, void *object, gfp_t flags, > - bool init) > +static inline void unpoison_slab_object(struct kmem_cache *cache, void *object, > + gfp_t flags, bool init) > { > /* > * Unpoison the whole object. For kmalloc() allocations, > -- > 2.25.1 >