linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Marco Elver <elver@google.com>
To: Marco Elver <elver@google.com>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: Alexander Potapenko <glider@google.com>,
	Dmitry Vyukov <dvyukov@google.com>,
	 Andrey Konovalov <andreyknvl@google.com>,
	Jann Horn <jannh@google.com>,
	 LKML <linux-kernel@vger.kernel.org>,
	 Linux Memory Management List <linux-mm@kvack.org>,
	kasan-dev <kasan-dev@googlegroups.com>,
	 Christophe Leroy <christophe.leroy@csgroup.eu>
Subject: Re: [PATCH mm] kfence: fix reports if constant function prefixes exist
Date: Thu, 4 Mar 2021 15:43:50 +0100	[thread overview]
Message-ID: <CANpmjNPk0GYuiz1YZddJ1GjZuUXUrXFVZujoaH0UKDknpc-vgQ@mail.gmail.com> (raw)
In-Reply-To: <20210304144000.1148590-1-elver@google.com>

On Thu, 4 Mar 2021 at 15:40, Marco Elver <elver@google.com> wrote:
> Some architectures prefix all functions with a constant string ('.' on
> ppc64). Add ARCH_FUNC_PREFIX, which may optionally be defined in
> <asm/kfence.h>, so that get_stack_skipnr() can work properly.
>
> Link: https://lkml.kernel.org/r/f036c53d-7e81-763c-47f4-6024c6c5f058@csgroup.eu
> Reported-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Tested-by: Christophe Leroy <christophe.leroy@csgroup.eu>
> Signed-off-by: Marco Elver <elver@google.com>
> ---

For further context, the corresponding ppc64-enablement patch is was
just sent by Christophe:

  https://lkml.kernel.org/r/afaec81a551ef15345cb7d7563b3fac3d7041c3a.1614868445.git.christophe.leroy@csgroup.eu

But there is no strict dependency between the patches, only that the
stack traces that KFENCE prints aren't as pretty without the
ARCH_FUNC_PREFIX patch.

So it should be fine to take them through different trees, as long as
they both make the next merge window.

Thanks,
-- Marco


      reply	other threads:[~2021-03-04 14:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-04 14:40 Marco Elver
2021-03-04 14:43 ` Marco Elver [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANpmjNPk0GYuiz1YZddJ1GjZuUXUrXFVZujoaH0UKDknpc-vgQ@mail.gmail.com \
    --to=elver@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=andreyknvl@google.com \
    --cc=christophe.leroy@csgroup.eu \
    --cc=dvyukov@google.com \
    --cc=glider@google.com \
    --cc=jannh@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox