From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064DCC433F5 for ; Thu, 9 Dec 2021 10:01:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9283F6B0071; Thu, 9 Dec 2021 05:01:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D8716B0073; Thu, 9 Dec 2021 05:01:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C71A6B0074; Thu, 9 Dec 2021 05:01:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 6FBDA6B0071 for ; Thu, 9 Dec 2021 05:01:36 -0500 (EST) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 336CC85D68 for ; Thu, 9 Dec 2021 10:01:26 +0000 (UTC) X-FDA: 78897813372.20.170F412 Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by imf23.hostedemail.com (Postfix) with ESMTP id E8ECC140003 for ; Thu, 9 Dec 2021 10:01:24 +0000 (UTC) Received: by mail-ot1-f48.google.com with SMTP id 47-20020a9d0332000000b005798ac20d72so5566385otv.9 for ; Thu, 09 Dec 2021 02:01:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AwZ2q+ht+X4UdZ54dnQJfViFXAccYyFB0RjG6X/nT4g=; b=Ky/1aN74gCrR3pXS2bYGqEQoF4ja5H0lxuwpC8B3clyAJ1ArBBnxap6FkYSqx4EF6w a7Zsv/MfSIZoBnUCQdPJDWYlflLWTIkQcBaPh7sLxU9OvIc66FxM/5ob4S7wlqDJHBto rIr6wsn5M9AS8M6xV36qDOblL8rVqjuSgpAjtajm4HfNK9bmTLinUoNnPkoizHMKPi+Q DRJbIT/T6JW2YgjZlVR5sMpkB3pldk0uJ4WEkwzsTcXL4bbiswSDo4pcT7PIwbUU0xNm 7wh0uHoa9uWCnFriuyTEHLZJnpfnRkl7kHYWZInxbOFUQeobjiQXABA/PZGUy//wIVNY SOkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AwZ2q+ht+X4UdZ54dnQJfViFXAccYyFB0RjG6X/nT4g=; b=zYf8fSxZflShPRoRbNIZ+dWAVtZg047ZyoCM/957R+gxyETYznEAjSk2PvkIlX4oRZ uHOt0+mNlftDvXzov0G/TMJFBYXRHHq7hdOG5knn8FlFOZ1pXjzgvVmg9d67VMlPz2kI rBPk/5L2efY+d7+OVPDu1E30je6meGPMXKw4rThFlVnLWEj4XhpY4MU3BZYYZKD4ggNT wk20YEH+YjrE6nI68o+fMAIy/1XyuPmiwGOmzPyum4cQVXAx7686YuJ/Cf/lFc+4q7f4 fxF1hEDf3O7wMEJk3f1l2EGDyKmz4tvZJ20C6a/pvwgpLrVSca3RuQjazjxJ/LCVezo5 yB2Q== X-Gm-Message-State: AOAM530lmZl6fSSDWx7AVDmmvKbhDm+8/l/V9cz5j8yPJMJT/afwnJSq 4Fyuo7z0NbG4Ot+XJQcjaulkRFLbkDuCZMIoeE47cQ== X-Google-Smtp-Source: ABdhPJxZa3GYxRoilR/JLH9hzVT1QQ/EaqVeqSnsU3JR99zq35sqaqG5sQLyySDdxueSZkcU22FFVYWhsFTUKcZws7A= X-Received: by 2002:a9d:2ae1:: with SMTP id e88mr4211892otb.157.1639044084792; Thu, 09 Dec 2021 02:01:24 -0800 (PST) MIME-Version: 1.0 References: <20211201152604.3984495-1-elver@google.com> In-Reply-To: <20211201152604.3984495-1-elver@google.com> From: Marco Elver Date: Thu, 9 Dec 2021 11:00:00 +0100 Message-ID: Subject: Re: [PATCH] kcov: fix generic Kconfig dependencies if ARCH_WANTS_NO_INSTR To: elver@google.com, Andrew Morton Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , linux-kernel@vger.kernel.org, linux-mm@kvack.org, kasan-dev@googlegroups.com, Peter Zijlstra , Nick Desaulniers , Nathan Chancellor , Dmitry Vyukov , Andrey Konovalov , Mark Rutland , Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: E8ECC140003 X-Stat-Signature: 1fbn9zk6fcctecmc84gy1frhmqfxfy93 Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=google.com header.s=20210112 header.b="Ky/1aN74"; spf=pass (imf23.hostedemail.com: domain of elver@google.com designates 209.85.210.48 as permitted sender) smtp.mailfrom=elver@google.com; dmarc=pass (policy=reject) header.from=google.com X-HE-Tag: 1639044084-758250 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 1 Dec 2021 at 16:26, Marco Elver wrote: [...] > At the time of 0f1441b44e823, we didn't yet have ARCH_WANTS_NO_INSTR, > but now we can move the Kconfig dependency checks to the generic KCOV > option. KCOV will be available if: > > - architecture does not care about noinstr, OR > - we have objtool support (like on x86), OR > - GCC is 12.0 or newer, OR > - Clang is 13.0 or newer. > > Signed-off-by: Marco Elver I think this is good to pick up. Even though it has an x86 change in it, I think kcov changes go through -mm. Andrew, x86 maintainers, any preference? With the conclusion from [1], I think we decided it's better to take this now, given we discovered KCOV already appears broken on arm64 (likely due to noinstr) and e.g. syzbot disables it on arm64. [1] https://lkml.kernel.org/r/Yae+6clmwHox7CHN@FVFF77S0Q05N Thanks, -- Marco