From: Marco Elver <elver@google.com>
To: elver@google.com, Andrew Morton <akpm@linux-foundation.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
kasan-dev@googlegroups.com,
Peter Zijlstra <peterz@infradead.org>,
Nick Desaulniers <ndesaulniers@google.com>,
Nathan Chancellor <nathan@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Mark Rutland <mark.rutland@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] kcov: fix generic Kconfig dependencies if ARCH_WANTS_NO_INSTR
Date: Thu, 9 Dec 2021 11:00:00 +0100 [thread overview]
Message-ID: <CANpmjNPaKMsgfDo5PE_dX794otFXbJvGubxG44C8-QL66UVaUw@mail.gmail.com> (raw)
In-Reply-To: <20211201152604.3984495-1-elver@google.com>
On Wed, 1 Dec 2021 at 16:26, Marco Elver <elver@google.com> wrote:
[...]
> At the time of 0f1441b44e823, we didn't yet have ARCH_WANTS_NO_INSTR,
> but now we can move the Kconfig dependency checks to the generic KCOV
> option. KCOV will be available if:
>
> - architecture does not care about noinstr, OR
> - we have objtool support (like on x86), OR
> - GCC is 12.0 or newer, OR
> - Clang is 13.0 or newer.
>
> Signed-off-by: Marco Elver <elver@google.com>
I think this is good to pick up. Even though it has an x86 change in
it, I think kcov changes go through -mm. Andrew, x86 maintainers, any
preference?
With the conclusion from [1], I think we decided it's better to take
this now, given we discovered KCOV already appears broken on arm64
(likely due to noinstr) and e.g. syzbot disables it on arm64.
[1] https://lkml.kernel.org/r/Yae+6clmwHox7CHN@FVFF77S0Q05N
Thanks,
-- Marco
prev parent reply other threads:[~2021-12-09 10:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-01 15:26 Marco Elver
2021-12-01 15:57 ` Mark Rutland
2021-12-01 16:10 ` Marco Elver
2021-12-01 17:46 ` Mark Rutland
2021-12-01 18:16 ` Marco Elver
2021-12-01 18:28 ` Mark Rutland
2021-12-01 17:16 ` Nathan Chancellor
2021-12-02 14:50 ` Peter Zijlstra
2021-12-02 17:38 ` Marco Elver
2021-12-02 17:56 ` Peter Zijlstra
2021-12-09 10:00 ` Marco Elver [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANpmjNPaKMsgfDo5PE_dX794otFXbJvGubxG44C8-QL66UVaUw@mail.gmail.com \
--to=elver@google.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=bp@alien8.de \
--cc=catalin.marinas@arm.com \
--cc=dave.hansen@linux.intel.com \
--cc=dvyukov@google.com \
--cc=hpa@zytor.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=will@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox