From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B498C48BF6 for ; Mon, 26 Feb 2024 09:26:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 949D3940018; Mon, 26 Feb 2024 04:26:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F9CF940014; Mon, 26 Feb 2024 04:26:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C170940018; Mon, 26 Feb 2024 04:26:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 6DA31940014 for ; Mon, 26 Feb 2024 04:26:38 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 461FCA0A0E for ; Mon, 26 Feb 2024 09:26:38 +0000 (UTC) X-FDA: 81833424876.23.379F6E1 Received: from mail-vk1-f174.google.com (mail-vk1-f174.google.com [209.85.221.174]) by imf14.hostedemail.com (Postfix) with ESMTP id 71110100004 for ; Mon, 26 Feb 2024 09:26:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VWgzmPZ1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.221.174 as permitted sender) smtp.mailfrom=elver@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1708939596; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9deL/d/BcOgJ90IBVOvhsZVsKJ8Cuz+9AZRxFu2eesM=; b=KfIyiMtP8F0AbxSfYzny6KAVMo0qSC8sgNh0gIh4UGjwJdlH66BGK4llIeN75bc7v87DKs iJSnQGPl7mjuFQtda1RbszR25Jr9HA0+98alD4KIOBEmetWyTOffNZCW3XJoWGshYMMBZ9 /rfpCpiM/TJlA7rnXHD0GUICCOAQEX4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=VWgzmPZ1; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf14.hostedemail.com: domain of elver@google.com designates 209.85.221.174 as permitted sender) smtp.mailfrom=elver@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1708939596; a=rsa-sha256; cv=none; b=fOCMzjL9O/KAkUsksGvGC1g+j/F7qXyFhNticz9SkYTq2jkGeVW5ToHaS7oje/HBkSLgac HbR+VNs9DQx5Xny4IBI1B+N4ivRM369r/BHBC7qk30L32kIryeNdhEFn5dJ7w5zsiI1zTz ae+fDoMHJ5KblZsytuf9JqPlTq40ggY= Received: by mail-vk1-f174.google.com with SMTP id 71dfb90a1353d-4cdfcb24b79so224335e0c.3 for ; Mon, 26 Feb 2024 01:26:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1708939595; x=1709544395; darn=kvack.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=9deL/d/BcOgJ90IBVOvhsZVsKJ8Cuz+9AZRxFu2eesM=; b=VWgzmPZ1INvCIED68QXrE5eXwyEEEMoHXlRAbI+NdEOwVT/XgJ4pM6kMCtCtK6EDvr OUVgesiiCoDnN4NK2c6f9v6qR3BvJtH8Nn+80hdP+e7in8K68PYwvCkWWymusnLpkQTp 8AQ0T8POd/GbfoOVwHxY/mkYHelAI5f0VKrYFFbh89qDesPQbCGOFy1qeu4dQAfosXUB AZhrGvVnrthV2Q8SIxuusIqDXYSochXHcdxgw0+d+FeAnrd+vjsWHmuOjIobZBwqPiSk zojYY2lcXkAJpY1znksPRoziQlPDVlaDDDYs/EVSOUCOvyJUH8lCnIiP6oztK5SJPX8A eCxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708939595; x=1709544395; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9deL/d/BcOgJ90IBVOvhsZVsKJ8Cuz+9AZRxFu2eesM=; b=HcoK/YvIyIY92mhi7QoLIb6JMgcpN2XB1Fj9ljDgRJE8X8ko9ZUejbj+WR2YiWewye 2Aj7OVkFX5Zx0tCDCozCbbTOVVNpkvFcUgRE1kOcqxl2+z85db7ZH030Oe2nqqQ7nWbp GkTVU7DpK+nJjaELaLrwgIlGMFoR2V9bCn8qkE1hOrbKg8AlOyp/cGPmuGGe/5S+6dPD diVV3wJasSTz23N9ZDyaaX1Q1KhOPMzygXuUXD0RadRO3wyg3LkKZBa9hjgi2QYW4QLr MP0xWXhfDHlVxO1O+ov6479GQQl85+0RYTikMxoz4n5F8CbK6nsQzsjOIBetGWLVbEeT 7D8g== X-Forwarded-Encrypted: i=1; AJvYcCXFT/CymoDNUW+JhLfdxRxJbUbCsNSpi26Pgy9kZVPz8ptUtzfqtZz3lWb1CPLFstBWA6HeXSfXImgR5hDhN1ZSssg= X-Gm-Message-State: AOJu0YwlqqOg2L2y3NinT1etGFkglKefkFzvIdUCZJJaFxADyO49oo+c 4hw6KmitjT8jIXPXdLWnehj/ojrbi4kqMHwx/AG5wgEg1iUIMLXKTfql/7Rmhn5T2QAg1VfiZgF 93zSlmvRAYTXOzOdrDLIv7mdZD4W9Y0HG2NuP X-Google-Smtp-Source: AGHT+IHUnRw4mFGKo0EZ/hFZK/eG3IFnyKzaqS0jzj1uJLOk9IiRiRv/WsrXIPvhAqjXo29J5z4X1jK9bDP4OCfWkSk= X-Received: by 2002:a1f:cc84:0:b0:4b6:d63c:ca8f with SMTP id c126-20020a1fcc84000000b004b6d63cca8fmr2397957vkg.16.1708939595308; Mon, 26 Feb 2024 01:26:35 -0800 (PST) MIME-Version: 1.0 References: <91c50335-e7b6-4ae1-9dad-a0c990b52021@suse.cz> <20240219152836.11d36709c594e66fe3037f2d@linux-foundation.org> <7e31accb-db01-486f-afb8-18a3f5402d00@suse.cz> <20240220093011.bf84486d704c3814079c2aa0@linux-foundation.org> <96c51d35-15ce-42d0-b81b-7e76044e1f2b@suse.cz> In-Reply-To: From: Marco Elver Date: Mon, 26 Feb 2024 10:25:56 +0100 Message-ID: Subject: Re: regression/bisected commit 773688a6cb24b0b3c2ba40354d883348a2befa38 make my system completely unusable under high load To: Vlastimil Babka Cc: Andrew Morton , Mikhail Gavrilov , Andrey Konovalov , glider@google.com, dvyukov@google.com, eugenis@google.com, Oscar Salvador , Linux List Kernel Mailing , Linux Memory Management List Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 71110100004 X-Stat-Signature: piridan33ouaha9d7zqfe63zjgar4j7w X-HE-Tag: 1708939596-305348 X-HE-Meta: U2FsdGVkX18Gnl4WG/ahAuNnAfxs1tlrilu4JHq9GhntAkp6JIOqLDegTqPyTDkCvri1TMfy5vydWdFzOF11KcnsW4vAwCLfFEHQRSuWU2AST6aW+63Ype8nytI0hpOiUYMYu15B1aznRcYm7NanU031LGkeyFPuZCWUpuEg7275Mj0dAp0WpiyhFXl2Dw7/uQdXk/GZ3L1KnA5UswZa5WQlggh5hkcVs6zXB4nNhxBc/aVDV4fYjImt/M6CfU14ftktliI4vTPS7JekQfcZCvaMgJtnspNmmnC4P1eNpJUeQfIGzrJttBsBUUvqSgpKcy/jzGU15WfsPD2kP7z1rYlzsVQhFBhRyRgSy3G0mlZQfsgVgikXnJ3XLozBQ0fdfc0IiCN5gYN65zU23NmAFaMJ4Ukoxe8EI3lMC6vYzBW+jX9vH+QfJvGsv1OSkZZkYky837PGemEriYQgp+hQp7yiI0zRo7b+I19wBnVMRzGeCtSRNZQ/Yg4z536ac+hbyChi7zWaQxz4K4GgDtqZoG7uW17FdK1Iu0VasSyVFUuK0RuGWINqEHmqg8jIFbF5EelpF5MaaYuGtr/y5DGEdehUxCwrg9adt3IVWVwEYtlglexN4EzK32epBusXcLxUDfIEf/Epkmd9X+iXwFXcQz/12gylLuSA6JTgO3Ut4vIAm5yDYzVBD3Ag0NTexy6bxaLYswt86C6/ygkPnKGyws41XRDXncHxTsgLvsJQ8LLo1nAmuPEwFyAstmuXdJd1eULyoO0ySA7wQMCrSbSMeah0LP/B6CpjLNqQmYitml94ZWkmvmJJktdhpN42YfXWoa5yPdcVRr4+vL7QIRwv0v0uEaGtmhIVMzl8B8YEUHDUlwov95FQgrM4vWDaEbeItFt+PyY++ll7+ZaX2R53hDMJT6rNsbxHFv8Vz/XgIdRIP1muj+uzIVmnXcV3xE0iaSpvX+EHe2Zl3623Zx4 26Xrwsee rd30JvNINFJn3ibdyzYk0gDLjDbp8lFwEZ7oA4kMGHs/hjmlKDoz+h0lY+UKMGw/3J7BZhneGzVz2uC37c1JixoSpcst/Lx6eeLGdtEEr/sK/fHL+aishNRjunD8SIXNEMjIDqIfZbikokgdcxMM3HBdFJqdEznH9Hv1nzwQAG/A6W6CgxnhQsSe1kU1FEQC/ulHuEiSQnsXxZfM9FrSYEufQ/bxYvLHpVW5Tsu9Ugp03osQxIOfZnaS9I0NYSN1ku0AIU9EDMn/YR20KlTyqIw5PCpN3aSXO8UOy0jPxPVRqrdoP+r6gvbQErjNFXRalIj80vX5hjeqc2LB5fkez/VPjytgeAhCqK1jZ9+fJIu9oGvvEmVrrgi2GFbWrNTwwI6mdurv7TPpHAPMcNdTA6KK3pD62i1Xj1jyceqNPsM0jRyE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 20 Feb 2024 at 19:51, Marco Elver wrote: > > On Tue, 20 Feb 2024 at 19:16, Vlastimil Babka wrote: > > > > On 2/20/24 18:30, Andrew Morton wrote: > > > On Tue, 20 Feb 2024 10:37:03 +0500 Mikhail Gavrilov wrote: > > > > > >> On Tue, Feb 20, 2024 at 4:50=E2=80=AFAM Vlastimil Babka wrote: > > >> > > > > >> > > I'm all confused. > > >> > > > > >> > > 4434a56ec209 ("stackdepot: make fast paths lock-less again") was > > >> > > mainlined for v6.8-rc3. > > >> > > > >> > Uh sorry, I just trusted the info that it's not merged and didn't = verify > > >> > it myself. Yeah, I can see it is there. > > >> > > > >> > > >> Wait, I am talk about these two patches which is not merged yet: > > >> [PATCH v2 1/2] stackdepot: use variable size records for non-evictab= le entries > > >> [PATCH v2 2/2] kasan: revert eviction of stack traces in generic mod= e > > >> https://lore.kernel.org/linux-mm/20240129100708.39460-1-elver@google= .com/ > > > > > > A can move those into the 6.8-rc hotfixes queue, and it appears a > > > cc:stable will not be required. > > > > > > However I'm not seeing anything in the changelogs to indicate that > > > we're fixing a dramatic performance regression, nor why that > > > regressions is occurring. > > It's primarily fixing a regression of memory usage overhead for > stackdepot users in general. Performance is mostly fixed, but patch > 2/2 ("kasan: revert eviction of stack traces in generic mode") also > helps with KASAN performance because entries that were being > repeatedly evicted-then-reallocated are just allocated once and with > increasing system uptime the slow path will be taken much less. > > > We also seem have an unhappy bot with the 2/2 patch :/ although it's no= t yet > > clear if it's a genuine issue. > > > > https://lore.kernel.org/all/202402201506.b7e4b9b6-oliver.sang@intel.com= / This was confirmed to be a non-bug by RCU devs. > While it would be nice if 6.8 would not regress over 6.7 (performance > is mostly fixed, memory usage is not), waiting for confirmation what > the rcutorture issue from the bot is about might be good. > > Mikhail: since you are testing mainline, in about 4 weeks the fixes > should then reach 6.9-rc in the next merge window. Until then, if it's > not too difficult for you, you can apply those 2 patches in your own > tree. There are more issues that are fixed by "[PATCH v2 1/2] stackdepot: use variable size records for non-evictable entries". See https://lore.kernel.org/all/ZdxYXQdZDuuhcqiv@elver.google.com/ This will eventually reach stable, but it might be good to reconsider mainlining it earlier. Thanks, -- Marco