From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-23.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98CF5C433E0 for ; Wed, 13 Jan 2021 16:40:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0FD9A2339D for ; Wed, 13 Jan 2021 16:40:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0FD9A2339D Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 51D156B0166; Wed, 13 Jan 2021 11:40:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4CE858D006C; Wed, 13 Jan 2021 11:40:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3E2E38D006A; Wed, 13 Jan 2021 11:40:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0034.hostedemail.com [216.40.44.34]) by kanga.kvack.org (Postfix) with ESMTP id 285736B0166 for ; Wed, 13 Jan 2021 11:40:00 -0500 (EST) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id DBBC4180AD82F for ; Wed, 13 Jan 2021 16:39:59 +0000 (UTC) X-FDA: 77701313718.27.able77_30082712751f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id B466A3D668 for ; Wed, 13 Jan 2021 16:39:59 +0000 (UTC) X-HE-Tag: able77_30082712751f X-Filterd-Recvd-Size: 4273 Received: from mail-ot1-f47.google.com (mail-ot1-f47.google.com [209.85.210.47]) by imf39.hostedemail.com (Postfix) with ESMTP for ; Wed, 13 Jan 2021 16:39:59 +0000 (UTC) Received: by mail-ot1-f47.google.com with SMTP id i6so2490478otr.2 for ; Wed, 13 Jan 2021 08:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=718zcsFUzGW3JK8wqJnAiFUqkREV/jlMJotq/sE7w4Q=; b=SWJj7egFZVpu8ndMonBOTArDLXjWaJchbV+rLUhaDy2UGjwFeMbseW2RdF2u5VX3ot 4PjB8nCMCzbm1O7fPIL/TEYKJvzrWNz68rPznMB5x5Y2cH/OytCVm02lpRZeShfb2h+6 AWkineT2SquX0tiBdz7mZp2FXaeJ5MZb7CxuJ6YyoWNphnIqWYaLAOid7vtMnXndNpve JulNlvO2oixZDx+utacP0e+Qgw2DiuPVYjUbo5yg3zGhjLdC23GrETsoN4pwMEoYY2kz pzf/2C7U0xcN46NqR9bqXyHbyGWWUtwXNj7YzOZgcsTogRwoNCQNNJp1jhX2CveJfkwx 6Gng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=718zcsFUzGW3JK8wqJnAiFUqkREV/jlMJotq/sE7w4Q=; b=YnC2MDebJBex56Gaf2CMu9PpveCUlJMj31s99cOKjm0G6ZEaIe1GeiFODuZFInTDHq wcUNA6OcEPd6oHQabizs90zdR1IOaaEjqNDnaAZ7tenK7X+g79rsJp06PrthM/uHSkt1 wyTgb5iviUpHVwAZZdTdX6I2ORpjuWBVt675UKnyN3huZ9uOgLHANhWC5HA1DqSEBvsm S+sni8N2vTZVhkKw0ebahxIdpKqMFbrtCA2xIpbTmd1GqmfiG6p2yXrKigd2bQs3heM9 gyUYKs3uDkIe0hjva67w6plW72Zt+n8ssRGJmNCU5Xbm3KFU2UXAzMv32jM2syL9iUTt jS8w== X-Gm-Message-State: AOAM530g06ebRA4iugZxdmfadF7qPRBcUmV7plyuB6+2OEPVVT2CBLPN Qxq02yhhl/pDWcLM2orNVNcLbs9jdiIHkO40is0o5g== X-Google-Smtp-Source: ABdhPJz8omtz8YajrsBZ21cuSoyPdhfQl1j/+zYoWJGvqIou6ClU5xryuWosQGprK+fdTCwKqC2UVLTAZoYuKcKcIuE= X-Received: by 2002:a05:6830:2413:: with SMTP id j19mr1862383ots.251.1610555998526; Wed, 13 Jan 2021 08:39:58 -0800 (PST) MIME-Version: 1.0 References: <654bdeedde54e9e8d5d6250469966b0bdf288010.1610554432.git.andreyknvl@google.com> In-Reply-To: <654bdeedde54e9e8d5d6250469966b0bdf288010.1610554432.git.andreyknvl@google.com> From: Marco Elver Date: Wed, 13 Jan 2021 17:39:47 +0100 Message-ID: Subject: Re: [PATCH v2 14/14] kasan: don't run tests when KASAN is not enabled To: Andrey Konovalov Cc: Catalin Marinas , Vincenzo Frascino , Dmitry Vyukov , Alexander Potapenko , Andrew Morton , Will Deacon , Andrey Ryabinin , Peter Collingbourne , Evgenii Stepanov , Branislav Rankov , Kevin Brodsky , kasan-dev , Linux ARM , Linux Memory Management List , LKML Content-Type: text/plain; charset="UTF-8" X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 13 Jan 2021 at 17:22, Andrey Konovalov wrote: > > Don't run KASAN tests when it's disabled with kasan.mode=off to avoid > corrupting kernel memory. > > Link: https://linux-review.googlesource.com/id/I6447af436a69a94bfc35477f6bf4e2122948355e > Signed-off-by: Andrey Konovalov > --- > lib/test_kasan.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/lib/test_kasan.c b/lib/test_kasan.c > index d9f9a93922d5..0c8279d9907e 100644 > --- a/lib/test_kasan.c > +++ b/lib/test_kasan.c > @@ -47,6 +47,9 @@ static bool multishot; > */ > static int kasan_test_init(struct kunit *test) > { > + if (!kasan_enabled()) > + return -1; This should WARN_ON() or pr_err(). Otherwise it's impossible to say why the test couldn't initialize. > multishot = kasan_save_enable_multi_shot(); > hw_set_tagging_report_once(false); > return 0; > -- > 2.30.0.284.gd98b1dd5eaa7-goog >